configure | 8 + default-configs/rx-softmmu.mak | 3 + qapi/machine.json | 3 +- include/disas/dis-asm.h | 5 + include/exec/poison.h | 1 + include/hw/char/renesas_sci.h | 45 + include/hw/intc/rx_icu.h | 56 + include/hw/registerfields.h | 32 +- include/hw/rx/rx.h | 7 + include/hw/rx/rx62n.h | 91 + include/hw/timer/renesas_cmt.h | 38 + include/hw/timer/renesas_tmr.h | 53 + include/qemu/bitops.h | 38 + include/sysemu/arch_init.h | 1 + target/rx/cpu-param.h | 31 + target/rx/cpu-qom.h | 42 + target/rx/cpu.h | 181 ++ target/rx/helper.h | 31 + arch_init.c | 2 + hw/char/renesas_sci.c | 343 ++++ hw/intc/rx_icu.c | 379 ++++ hw/rx/rx-virt.c | 135 ++ hw/rx/rx62n.c | 247 +++ hw/timer/renesas_cmt.c | 278 +++ hw/timer/renesas_tmr.c | 458 +++++ target/rx/cpu.c | 217 +++ target/rx/disas.c | 1446 ++++++++++++++ target/rx/gdbstub.c | 112 ++ target/rx/helper.c | 149 ++ target/rx/op_helper.c | 470 +++++ target/rx/translate.c | 2432 ++++++++++++++++++++++++ tests/machine-none-test.c | 1 + MAINTAINERS | 19 + hw/Kconfig | 1 + hw/char/Kconfig | 3 + hw/char/Makefile.objs | 1 + hw/intc/Kconfig | 3 + hw/intc/Makefile.objs | 1 + hw/rx/Kconfig | 14 + hw/rx/Makefile.objs | 2 + hw/timer/Kconfig | 6 + hw/timer/Makefile.objs | 3 + target/rx/Makefile.objs | 11 + target/rx/insns.decode | 621 ++++++ tests/acceptance/boot_linux_console.py | 46 + 45 files changed, 8064 insertions(+), 2 deletions(-) create mode 100644 default-configs/rx-softmmu.mak create mode 100644 include/hw/char/renesas_sci.h create mode 100644 include/hw/intc/rx_icu.h create mode 100644 include/hw/rx/rx.h create mode 100644 include/hw/rx/rx62n.h create mode 100644 include/hw/timer/renesas_cmt.h create mode 100644 include/hw/timer/renesas_tmr.h create mode 100644 target/rx/cpu-param.h create mode 100644 target/rx/cpu-qom.h create mode 100644 target/rx/cpu.h create mode 100644 target/rx/helper.h create mode 100644 hw/char/renesas_sci.c create mode 100644 hw/intc/rx_icu.c create mode 100644 hw/rx/rx-virt.c create mode 100644 hw/rx/rx62n.c create mode 100644 hw/timer/renesas_cmt.c create mode 100644 hw/timer/renesas_tmr.c create mode 100644 target/rx/cpu.c create mode 100644 target/rx/disas.c create mode 100644 target/rx/gdbstub.c create mode 100644 target/rx/helper.c create mode 100644 target/rx/op_helper.c create mode 100644 target/rx/translate.c create mode 100644 hw/rx/Kconfig create mode 100644 hw/rx/Makefile.objs create mode 100644 target/rx/Makefile.objs create mode 100644 target/rx/insns.decode
Hello.
This patch series is added Renesas RX target emulation.
Changes for v25.
Update commit message.
Squashed qapi/machine.json changes.
Changes for v24.
Add note for qapi/machine.json.
Added Acked-by for 6/22.
git rebase master.
Changes for v23.
Follow master changes.
Changes for v22.
Added some include.
Changes for v21.
rebase latest master.
Remove unneeded hmp_info_tlb.
Chanegs for v20.
Reorderd patches.
Squashed v19 changes.
Changes for v19.
Follow tcg changes.
Cleanup cpu.c.
simplify rx_cpu_class_by_name and rx_load_image move to rx-virt.
My git repository is bellow.
git://git.pf.osdn.net/gitroot/y/ys/ysato/qemu.git tags/rx-20190912
Testing binaries bellow.
u-boot
Download - https://osdn.net/users/ysato/pf/qemu/dl/u-boot.bin.gz
starting
$ gzip -d u-boot.bin.gz
$ qemu-system-rx -bios u-boot.bin
linux and pico-root (only sash)
Download - https://osdn.net/users/ysato/pf/qemu/dl/zImage (kernel)
https://osdn.net/users/ysato/pf/qemu/dl/rx-qemu.dtb (DeviceTree)
starting
$ qemu-system-rx -kernel zImage -dtb rx-qemu.dtb -append "earlycon"
Philippe Mathieu-Daudé (3):
hw/registerfields.h: Add 8bit and 16bit register macros
hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core
BootLinuxConsoleTest: Test the RX-Virt machine
Richard Henderson (7):
target/rx: Disassemble rx_index_addr into a string
target/rx: Replace operand with prt_ldmi in disassembler
target/rx: Use prt_ldmi for XCHG_mr disassembly
target/rx: Emit all disassembly in one prt()
target/rx: Collect all bytes during disassembly
target/rx: Dump bytes for each insn during disassembly
hw/rx: Honor -accel qtest
Yoshinori Sato (11):
MAINTAINERS: Add RX
qemu/bitops.h: Add extract8 and extract16
target/rx: TCG translation
target/rx: TCG helper
target/rx: CPU definition
target/rx: RX disassembler
hw/intc: RX62N interrupt controller (ICUa)
hw/timer: RX62N internal timer modules
hw/char: RX62N serial communication interface (SCI)
hw/rx: RX Target hardware definition
Add rx-softmmu
configure | 8 +
default-configs/rx-softmmu.mak | 3 +
qapi/machine.json | 3 +-
include/disas/dis-asm.h | 5 +
include/exec/poison.h | 1 +
include/hw/char/renesas_sci.h | 45 +
include/hw/intc/rx_icu.h | 56 +
include/hw/registerfields.h | 32 +-
include/hw/rx/rx.h | 7 +
include/hw/rx/rx62n.h | 91 +
include/hw/timer/renesas_cmt.h | 38 +
include/hw/timer/renesas_tmr.h | 53 +
include/qemu/bitops.h | 38 +
include/sysemu/arch_init.h | 1 +
target/rx/cpu-param.h | 31 +
target/rx/cpu-qom.h | 42 +
target/rx/cpu.h | 181 ++
target/rx/helper.h | 31 +
arch_init.c | 2 +
hw/char/renesas_sci.c | 343 ++++
hw/intc/rx_icu.c | 379 ++++
hw/rx/rx-virt.c | 135 ++
hw/rx/rx62n.c | 247 +++
hw/timer/renesas_cmt.c | 278 +++
hw/timer/renesas_tmr.c | 458 +++++
target/rx/cpu.c | 217 +++
target/rx/disas.c | 1446 ++++++++++++++
target/rx/gdbstub.c | 112 ++
target/rx/helper.c | 149 ++
target/rx/op_helper.c | 470 +++++
target/rx/translate.c | 2432 ++++++++++++++++++++++++
tests/machine-none-test.c | 1 +
MAINTAINERS | 19 +
hw/Kconfig | 1 +
hw/char/Kconfig | 3 +
hw/char/Makefile.objs | 1 +
hw/intc/Kconfig | 3 +
hw/intc/Makefile.objs | 1 +
hw/rx/Kconfig | 14 +
hw/rx/Makefile.objs | 2 +
hw/timer/Kconfig | 6 +
hw/timer/Makefile.objs | 3 +
target/rx/Makefile.objs | 11 +
target/rx/insns.decode | 621 ++++++
tests/acceptance/boot_linux_console.py | 46 +
45 files changed, 8064 insertions(+), 2 deletions(-)
create mode 100644 default-configs/rx-softmmu.mak
create mode 100644 include/hw/char/renesas_sci.h
create mode 100644 include/hw/intc/rx_icu.h
create mode 100644 include/hw/rx/rx.h
create mode 100644 include/hw/rx/rx62n.h
create mode 100644 include/hw/timer/renesas_cmt.h
create mode 100644 include/hw/timer/renesas_tmr.h
create mode 100644 target/rx/cpu-param.h
create mode 100644 target/rx/cpu-qom.h
create mode 100644 target/rx/cpu.h
create mode 100644 target/rx/helper.h
create mode 100644 hw/char/renesas_sci.c
create mode 100644 hw/intc/rx_icu.c
create mode 100644 hw/rx/rx-virt.c
create mode 100644 hw/rx/rx62n.c
create mode 100644 hw/timer/renesas_cmt.c
create mode 100644 hw/timer/renesas_tmr.c
create mode 100644 target/rx/cpu.c
create mode 100644 target/rx/disas.c
create mode 100644 target/rx/gdbstub.c
create mode 100644 target/rx/helper.c
create mode 100644 target/rx/op_helper.c
create mode 100644 target/rx/translate.c
create mode 100644 hw/rx/Kconfig
create mode 100644 hw/rx/Makefile.objs
create mode 100644 target/rx/Makefile.objs
create mode 100644 target/rx/insns.decode
--
2.20.1
Patchew URL: https://patchew.org/QEMU/20191014115757.51866-1-ysato@users.sourceforge.jp/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Subject: [PATCH v26 00/21] Add RX archtecture support
Type: series
Message-id: 20191014115757.51866-1-ysato@users.sourceforge.jp
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
From https://github.com/patchew-project/qemu
- [tag update] patchew/20191014115757.51866-1-ysato@users.sourceforge.jp -> patchew/20191014115757.51866-1-ysato@users.sourceforge.jp
Switched to a new branch 'test'
3dc4ce3 BootLinuxConsoleTest: Test the RX-Virt machine
7db9f9b Add rx-softmmu
23cabcc hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core
762fe7c hw/rx: Honor -accel qtest
d91f89f hw/rx: RX Target hardware definition
0c6ffe0 hw/char: RX62N serial communication interface (SCI)
e6a5a42 hw/timer: RX62N internal timer modules
38febf0 hw/intc: RX62N interrupt controller (ICUa)
0871fb9 target/rx: Dump bytes for each insn during disassembly
136dde2 target/rx: Collect all bytes during disassembly
d541b2f target/rx: Emit all disassembly in one prt()
56e42be target/rx: Use prt_ldmi for XCHG_mr disassembly
3a4e100 target/rx: Replace operand with prt_ldmi in disassembler
152bc63 target/rx: Disassemble rx_index_addr into a string
c54404e target/rx: RX disassembler
a3f9cb6 target/rx: CPU definition
3766354 target/rx: TCG helper
44c05b7 target/rx: TCG translation
89989a0 hw/registerfields.h: Add 8bit and 16bit register macros
5aa6e53 qemu/bitops.h: Add extract8 and extract16
fcbaac0 MAINTAINERS: Add RX
=== OUTPUT BEGIN ===
1/21 Checking commit fcbaac0c6ed3 (MAINTAINERS: Add RX)
2/21 Checking commit 5aa6e538fe97 (qemu/bitops.h: Add extract8 and extract16)
3/21 Checking commit 89989a01d9ae (hw/registerfields.h: Add 8bit and 16bit register macros)
Use of uninitialized value in concatenation (.) or string at ./scripts/checkpatch.pl line 2484.
ERROR: Macros with multiple statements should be enclosed in a do - while loop
#27: FILE: include/hw/registerfields.h:25:
+#define REG8(reg, addr) \
+ enum { A_ ## reg = (addr) }; \
+ enum { R_ ## reg = (addr) };
ERROR: Macros with multiple statements should be enclosed in a do - while loop
#31: FILE: include/hw/registerfields.h:29:
+#define REG16(reg, addr) \
+ enum { A_ ## reg = (addr) }; \
+ enum { R_ ## reg = (addr) / 2 };
total: 2 errors, 0 warnings, 56 lines checked
Patch 3/21 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
4/21 Checking commit 44c05b78c659 (target/rx: TCG translation)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#20:
new file mode 100644
total: 0 errors, 1 warnings, 3065 lines checked
Patch 4/21 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
5/21 Checking commit 3766354ea070 (target/rx: TCG helper)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#21:
new file mode 100644
total: 0 errors, 1 warnings, 650 lines checked
Patch 5/21 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
6/21 Checking commit a3f9cb69bcd3 (target/rx: CPU definition)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#32:
new file mode 100644
total: 0 errors, 1 warnings, 588 lines checked
Patch 6/21 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
7/21 Checking commit c54404e8c1f4 (target/rx: RX disassembler)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#38:
new file mode 100644
total: 0 errors, 1 warnings, 1497 lines checked
Patch 7/21 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
8/21 Checking commit 152bc63f993c (target/rx: Disassemble rx_index_addr into a string)
9/21 Checking commit 3a4e100bebf4 (target/rx: Replace operand with prt_ldmi in disassembler)
10/21 Checking commit 56e42be2740a (target/rx: Use prt_ldmi for XCHG_mr disassembly)
11/21 Checking commit d541b2f36ec7 (target/rx: Emit all disassembly in one prt())
12/21 Checking commit 136dde281494 (target/rx: Collect all bytes during disassembly)
13/21 Checking commit 0871fb92b151 (target/rx: Dump bytes for each insn during disassembly)
14/21 Checking commit 38febf06b563 (hw/intc: RX62N interrupt controller (ICUa))
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#40:
new file mode 100644
total: 0 errors, 1 warnings, 445 lines checked
Patch 14/21 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
15/21 Checking commit e6a5a4234074 (hw/timer: RX62N internal timer modules)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#50:
new file mode 100644
total: 0 errors, 1 warnings, 845 lines checked
Patch 15/21 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
16/21 Checking commit 0c6ffe06866f (hw/char: RX62N serial communication interface (SCI))
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#43:
new file mode 100644
total: 0 errors, 1 warnings, 401 lines checked
Patch 16/21 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
17/21 Checking commit d91f89f85ccd (hw/rx: RX Target hardware definition)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#29:
new file mode 100644
total: 0 errors, 1 warnings, 480 lines checked
Patch 17/21 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
18/21 Checking commit 762fe7cdc83e (hw/rx: Honor -accel qtest)
19/21 Checking commit 23cabcce4ea2 (hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core)
20/21 Checking commit 7db9f9bfe9dc (Add rx-softmmu)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#59:
new file mode 100644
total: 0 errors, 1 warnings, 74 lines checked
Patch 20/21 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
21/21 Checking commit 3dc4ce3fba7e (BootLinuxConsoleTest: Test the RX-Virt machine)
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/20191014115757.51866-1-ysato@users.sourceforge.jp/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
Patchew URL: https://patchew.org/QEMU/20191014115757.51866-1-ysato@users.sourceforge.jp/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Subject: [PATCH v26 00/21] Add RX archtecture support
Type: series
Message-id: 20191014115757.51866-1-ysato@users.sourceforge.jp
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
- [tag update] patchew/20191011155546.14342-1-richard.henderson@linaro.org -> patchew/20191011155546.14342-1-richard.henderson@linaro.org
- [tag update] patchew/20191014104948.4291-1-alex.bennee@linaro.org -> patchew/20191014104948.4291-1-alex.bennee@linaro.org
- [tag update] patchew/20191014154529.287048-1-jonathan@fintelia.io -> patchew/20191014154529.287048-1-jonathan@fintelia.io
* [new tag] patchew/20191014175440.152609-1-dgilbert@redhat.com -> patchew/20191014175440.152609-1-dgilbert@redhat.com
Switched to a new branch 'test'
4c3dad1 BootLinuxConsoleTest: Test the RX-Virt machine
c142990 Add rx-softmmu
3399475 hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core
9bee373 hw/rx: Honor -accel qtest
5d46dd8 hw/rx: RX Target hardware definition
045dde2 hw/char: RX62N serial communication interface (SCI)
e083fdb hw/timer: RX62N internal timer modules
7007342 hw/intc: RX62N interrupt controller (ICUa)
abaefff target/rx: Dump bytes for each insn during disassembly
c47d1b5 target/rx: Collect all bytes during disassembly
caf127b target/rx: Emit all disassembly in one prt()
b384a35 target/rx: Use prt_ldmi for XCHG_mr disassembly
4f1a429 target/rx: Replace operand with prt_ldmi in disassembler
0497516 target/rx: Disassemble rx_index_addr into a string
e557d70 target/rx: RX disassembler
87a65d0 target/rx: CPU definition
b7f549f target/rx: TCG helper
cb05be5 target/rx: TCG translation
40b374c hw/registerfields.h: Add 8bit and 16bit register macros
1d0ff9c qemu/bitops.h: Add extract8 and extract16
6eaeb50 MAINTAINERS: Add RX
=== OUTPUT BEGIN ===
1/21 Checking commit 6eaeb50b4cee (MAINTAINERS: Add RX)
2/21 Checking commit 1d0ff9ca2614 (qemu/bitops.h: Add extract8 and extract16)
3/21 Checking commit 40b374cf6a64 (hw/registerfields.h: Add 8bit and 16bit register macros)
Use of uninitialized value in concatenation (.) or string at ./scripts/checkpatch.pl line 2484.
ERROR: Macros with multiple statements should be enclosed in a do - while loop
#27: FILE: include/hw/registerfields.h:25:
+#define REG8(reg, addr) \
+ enum { A_ ## reg = (addr) }; \
+ enum { R_ ## reg = (addr) };
ERROR: Macros with multiple statements should be enclosed in a do - while loop
#31: FILE: include/hw/registerfields.h:29:
+#define REG16(reg, addr) \
+ enum { A_ ## reg = (addr) }; \
+ enum { R_ ## reg = (addr) / 2 };
total: 2 errors, 0 warnings, 56 lines checked
Patch 3/21 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
4/21 Checking commit cb05be5ae845 (target/rx: TCG translation)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#20:
new file mode 100644
total: 0 errors, 1 warnings, 3065 lines checked
Patch 4/21 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
5/21 Checking commit b7f549ffd63a (target/rx: TCG helper)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#21:
new file mode 100644
total: 0 errors, 1 warnings, 650 lines checked
Patch 5/21 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
6/21 Checking commit 87a65d07c493 (target/rx: CPU definition)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#32:
new file mode 100644
total: 0 errors, 1 warnings, 588 lines checked
Patch 6/21 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
7/21 Checking commit e557d7025ecf (target/rx: RX disassembler)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#38:
new file mode 100644
total: 0 errors, 1 warnings, 1497 lines checked
Patch 7/21 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
8/21 Checking commit 0497516a2518 (target/rx: Disassemble rx_index_addr into a string)
9/21 Checking commit 4f1a4299e204 (target/rx: Replace operand with prt_ldmi in disassembler)
10/21 Checking commit b384a35fdae4 (target/rx: Use prt_ldmi for XCHG_mr disassembly)
11/21 Checking commit caf127b72272 (target/rx: Emit all disassembly in one prt())
12/21 Checking commit c47d1b5dcc35 (target/rx: Collect all bytes during disassembly)
13/21 Checking commit abaefffa341e (target/rx: Dump bytes for each insn during disassembly)
14/21 Checking commit 700734263aef (hw/intc: RX62N interrupt controller (ICUa))
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#40:
new file mode 100644
total: 0 errors, 1 warnings, 445 lines checked
Patch 14/21 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
15/21 Checking commit e083fdb0c716 (hw/timer: RX62N internal timer modules)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#50:
new file mode 100644
total: 0 errors, 1 warnings, 845 lines checked
Patch 15/21 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
16/21 Checking commit 045dde28e03a (hw/char: RX62N serial communication interface (SCI))
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#43:
new file mode 100644
total: 0 errors, 1 warnings, 401 lines checked
Patch 16/21 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
17/21 Checking commit 5d46dd871e1b (hw/rx: RX Target hardware definition)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#29:
new file mode 100644
total: 0 errors, 1 warnings, 480 lines checked
Patch 17/21 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
18/21 Checking commit 9bee373b0ea8 (hw/rx: Honor -accel qtest)
19/21 Checking commit 33994759788c (hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core)
20/21 Checking commit c142990c2ff1 (Add rx-softmmu)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#59:
new file mode 100644
total: 0 errors, 1 warnings, 74 lines checked
Patch 20/21 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
21/21 Checking commit 4c3dad1103b8 (BootLinuxConsoleTest: Test the RX-Virt machine)
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/20191014115757.51866-1-ysato@users.sourceforge.jp/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
Patchew URL: https://patchew.org/QEMU/20191014115757.51866-1-ysato@users.sourceforge.jp/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Subject: [PATCH v26 00/21] Add RX archtecture support
Type: series
Message-id: 20191014115757.51866-1-ysato@users.sourceforge.jp
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Switched to a new branch 'test'
e7b4c1e BootLinuxConsoleTest: Test the RX-Virt machine
2eb41c6 Add rx-softmmu
48b2733 hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core
553c47a hw/rx: Honor -accel qtest
772e51b hw/rx: RX Target hardware definition
e83ed7a hw/char: RX62N serial communication interface (SCI)
bc497be hw/timer: RX62N internal timer modules
489b78e hw/intc: RX62N interrupt controller (ICUa)
e7e59c8 target/rx: Dump bytes for each insn during disassembly
90542e9 target/rx: Collect all bytes during disassembly
59f6e53 target/rx: Emit all disassembly in one prt()
d8274fb target/rx: Use prt_ldmi for XCHG_mr disassembly
2624f8a target/rx: Replace operand with prt_ldmi in disassembler
b035061 target/rx: Disassemble rx_index_addr into a string
a03cc02 target/rx: RX disassembler
675ec3b target/rx: CPU definition
53294dd target/rx: TCG helper
bb455c1 target/rx: TCG translation
77b432f hw/registerfields.h: Add 8bit and 16bit register macros
8d8dcbf qemu/bitops.h: Add extract8 and extract16
9314e24 MAINTAINERS: Add RX
=== OUTPUT BEGIN ===
1/21 Checking commit 9314e24fff3f (MAINTAINERS: Add RX)
2/21 Checking commit 8d8dcbf0ca8c (qemu/bitops.h: Add extract8 and extract16)
3/21 Checking commit 77b432f0a09a (hw/registerfields.h: Add 8bit and 16bit register macros)
Use of uninitialized value in concatenation (.) or string at ./scripts/checkpatch.pl line 2484.
ERROR: Macros with multiple statements should be enclosed in a do - while loop
#27: FILE: include/hw/registerfields.h:25:
+#define REG8(reg, addr) \
+ enum { A_ ## reg = (addr) }; \
+ enum { R_ ## reg = (addr) };
ERROR: Macros with multiple statements should be enclosed in a do - while loop
#31: FILE: include/hw/registerfields.h:29:
+#define REG16(reg, addr) \
+ enum { A_ ## reg = (addr) }; \
+ enum { R_ ## reg = (addr) / 2 };
total: 2 errors, 0 warnings, 56 lines checked
Patch 3/21 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
4/21 Checking commit bb455c1efb29 (target/rx: TCG translation)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#20:
new file mode 100644
total: 0 errors, 1 warnings, 3065 lines checked
Patch 4/21 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
5/21 Checking commit 53294dd48033 (target/rx: TCG helper)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#21:
new file mode 100644
total: 0 errors, 1 warnings, 650 lines checked
Patch 5/21 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
6/21 Checking commit 675ec3be479b (target/rx: CPU definition)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#32:
new file mode 100644
total: 0 errors, 1 warnings, 588 lines checked
Patch 6/21 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
7/21 Checking commit a03cc022543e (target/rx: RX disassembler)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#38:
new file mode 100644
total: 0 errors, 1 warnings, 1497 lines checked
Patch 7/21 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
8/21 Checking commit b0350612e125 (target/rx: Disassemble rx_index_addr into a string)
9/21 Checking commit 2624f8abcfe9 (target/rx: Replace operand with prt_ldmi in disassembler)
10/21 Checking commit d8274fb87fd1 (target/rx: Use prt_ldmi for XCHG_mr disassembly)
11/21 Checking commit 59f6e535acea (target/rx: Emit all disassembly in one prt())
12/21 Checking commit 90542e9f8d0f (target/rx: Collect all bytes during disassembly)
13/21 Checking commit e7e59c84dff4 (target/rx: Dump bytes for each insn during disassembly)
14/21 Checking commit 489b78e048b9 (hw/intc: RX62N interrupt controller (ICUa))
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#40:
new file mode 100644
total: 0 errors, 1 warnings, 445 lines checked
Patch 14/21 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
15/21 Checking commit bc497beb9b62 (hw/timer: RX62N internal timer modules)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#50:
new file mode 100644
total: 0 errors, 1 warnings, 845 lines checked
Patch 15/21 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
16/21 Checking commit e83ed7af7074 (hw/char: RX62N serial communication interface (SCI))
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#43:
new file mode 100644
total: 0 errors, 1 warnings, 401 lines checked
Patch 16/21 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
17/21 Checking commit 772e51bc3fe9 (hw/rx: RX Target hardware definition)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#29:
new file mode 100644
total: 0 errors, 1 warnings, 480 lines checked
Patch 17/21 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
18/21 Checking commit 553c47ae44cc (hw/rx: Honor -accel qtest)
19/21 Checking commit 48b27337c69b (hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core)
20/21 Checking commit 2eb41c65d957 (Add rx-softmmu)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#59:
new file mode 100644
total: 0 errors, 1 warnings, 74 lines checked
Patch 20/21 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
21/21 Checking commit e7b4c1ea4eec (BootLinuxConsoleTest: Test the RX-Virt machine)
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/20191014115757.51866-1-ysato@users.sourceforge.jp/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
Patchew URL: https://patchew.org/QEMU/20191014115757.51866-1-ysato@users.sourceforge.jp/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Subject: [PATCH v26 00/21] Add RX archtecture support
Type: series
Message-id: 20191014115757.51866-1-ysato@users.sourceforge.jp
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Switched to a new branch 'test'
505ff3c BootLinuxConsoleTest: Test the RX-Virt machine
870da65 Add rx-softmmu
fd6d0d7 hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core
53383c1 hw/rx: Honor -accel qtest
22e9b46 hw/rx: RX Target hardware definition
54826a9 hw/char: RX62N serial communication interface (SCI)
503ddab hw/timer: RX62N internal timer modules
3a88365 hw/intc: RX62N interrupt controller (ICUa)
1e75d01 target/rx: Dump bytes for each insn during disassembly
32a5073 target/rx: Collect all bytes during disassembly
ef8739d target/rx: Emit all disassembly in one prt()
d139491 target/rx: Use prt_ldmi for XCHG_mr disassembly
fc42ea6 target/rx: Replace operand with prt_ldmi in disassembler
f69c26a target/rx: Disassemble rx_index_addr into a string
0f7826e target/rx: RX disassembler
a8ce030 target/rx: CPU definition
958916c target/rx: TCG helper
100069d target/rx: TCG translation
ef5069b hw/registerfields.h: Add 8bit and 16bit register macros
d4ac167 qemu/bitops.h: Add extract8 and extract16
2062135 MAINTAINERS: Add RX
=== OUTPUT BEGIN ===
1/21 Checking commit 206213548587 (MAINTAINERS: Add RX)
2/21 Checking commit d4ac1671bb35 (qemu/bitops.h: Add extract8 and extract16)
3/21 Checking commit ef5069b624b4 (hw/registerfields.h: Add 8bit and 16bit register macros)
Use of uninitialized value in concatenation (.) or string at ./scripts/checkpatch.pl line 2484.
ERROR: Macros with multiple statements should be enclosed in a do - while loop
#27: FILE: include/hw/registerfields.h:25:
+#define REG8(reg, addr) \
+ enum { A_ ## reg = (addr) }; \
+ enum { R_ ## reg = (addr) };
ERROR: Macros with multiple statements should be enclosed in a do - while loop
#31: FILE: include/hw/registerfields.h:29:
+#define REG16(reg, addr) \
+ enum { A_ ## reg = (addr) }; \
+ enum { R_ ## reg = (addr) / 2 };
total: 2 errors, 0 warnings, 56 lines checked
Patch 3/21 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
4/21 Checking commit 100069d81c69 (target/rx: TCG translation)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#20:
new file mode 100644
total: 0 errors, 1 warnings, 3065 lines checked
Patch 4/21 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
5/21 Checking commit 958916cceffd (target/rx: TCG helper)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#21:
new file mode 100644
total: 0 errors, 1 warnings, 650 lines checked
Patch 5/21 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
6/21 Checking commit a8ce03017900 (target/rx: CPU definition)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#32:
new file mode 100644
total: 0 errors, 1 warnings, 588 lines checked
Patch 6/21 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
7/21 Checking commit 0f7826e600fd (target/rx: RX disassembler)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#38:
new file mode 100644
total: 0 errors, 1 warnings, 1497 lines checked
Patch 7/21 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
8/21 Checking commit f69c26a9cf8b (target/rx: Disassemble rx_index_addr into a string)
9/21 Checking commit fc42ea6daa7f (target/rx: Replace operand with prt_ldmi in disassembler)
10/21 Checking commit d1394917d410 (target/rx: Use prt_ldmi for XCHG_mr disassembly)
11/21 Checking commit ef8739d5f3c3 (target/rx: Emit all disassembly in one prt())
12/21 Checking commit 32a5073242dd (target/rx: Collect all bytes during disassembly)
13/21 Checking commit 1e75d0171960 (target/rx: Dump bytes for each insn during disassembly)
14/21 Checking commit 3a8836534610 (hw/intc: RX62N interrupt controller (ICUa))
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#40:
new file mode 100644
total: 0 errors, 1 warnings, 445 lines checked
Patch 14/21 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
15/21 Checking commit 503ddab9e01b (hw/timer: RX62N internal timer modules)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#50:
new file mode 100644
total: 0 errors, 1 warnings, 845 lines checked
Patch 15/21 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
16/21 Checking commit 54826a95ab7c (hw/char: RX62N serial communication interface (SCI))
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#43:
new file mode 100644
total: 0 errors, 1 warnings, 401 lines checked
Patch 16/21 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
17/21 Checking commit 22e9b46fa5c7 (hw/rx: RX Target hardware definition)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#29:
new file mode 100644
total: 0 errors, 1 warnings, 480 lines checked
Patch 17/21 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
18/21 Checking commit 53383c1a8747 (hw/rx: Honor -accel qtest)
19/21 Checking commit fd6d0d7bf641 (hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core)
20/21 Checking commit 870da651be1c (Add rx-softmmu)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#59:
new file mode 100644
total: 0 errors, 1 warnings, 74 lines checked
Patch 20/21 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
21/21 Checking commit 505ff3c7c840 (BootLinuxConsoleTest: Test the RX-Virt machine)
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/20191014115757.51866-1-ysato@users.sourceforge.jp/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
Hi Richard, On 10/14/19 1:57 PM, Yoshinori Sato wrote: > Hello. > This patch series is added Renesas RX target emulation. If you are OK to take this series, few janitor tasks I noted while reviewing again: - Remove Message-Id in commit descriptions (various patches) - Remove version notes in commit description of patch 17 - Remove 'pick $sha1' in in commit description of patch 20 - Remove Based-on in commit description of patch 21 Thanks, Phil.
Hi Yoshinori, On 10/14/19 1:57 PM, Yoshinori Sato wrote: > Hello. > This patch series is added Renesas RX target emulation. Your series is (very) ready to get merged. IIUC it won't be merged for the next release (4.2) but will be merged first thing once 5.0 opens. You don't need to do anything (except eventually send a ping in 3 weeks). Sorry it took so long, but introducing a new target is not an easy task. Regards, Phil.
OK. No problem. I'm waiting for the merge. Thanks. --- Yoshinori Sato
On Mon, 14 Oct 2019 20:57:36 +0900, Ping. Yoshinori Sato wrote: > > Hello. > This patch series is added Renesas RX target emulation. > > Changes for v25. > Update commit message. > Squashed qapi/machine.json changes. > > Changes for v24. > Add note for qapi/machine.json. > Added Acked-by for 6/22. > git rebase master. > > Changes for v23. > Follow master changes. > > Changes for v22. > Added some include. > > Changes for v21. > rebase latest master. > Remove unneeded hmp_info_tlb. > > Chanegs for v20. > Reorderd patches. > Squashed v19 changes. > > Changes for v19. > Follow tcg changes. > Cleanup cpu.c. > simplify rx_cpu_class_by_name and rx_load_image move to rx-virt. > > My git repository is bellow. > git://git.pf.osdn.net/gitroot/y/ys/ysato/qemu.git tags/rx-20190912 > > Testing binaries bellow. > u-boot > Download - https://osdn.net/users/ysato/pf/qemu/dl/u-boot.bin.gz > > starting > $ gzip -d u-boot.bin.gz > $ qemu-system-rx -bios u-boot.bin > > linux and pico-root (only sash) > Download - https://osdn.net/users/ysato/pf/qemu/dl/zImage (kernel) > https://osdn.net/users/ysato/pf/qemu/dl/rx-qemu.dtb (DeviceTree) > > starting > $ qemu-system-rx -kernel zImage -dtb rx-qemu.dtb -append "earlycon" > > Philippe Mathieu-Daudé (3): > hw/registerfields.h: Add 8bit and 16bit register macros > hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core > BootLinuxConsoleTest: Test the RX-Virt machine > > Richard Henderson (7): > target/rx: Disassemble rx_index_addr into a string > target/rx: Replace operand with prt_ldmi in disassembler > target/rx: Use prt_ldmi for XCHG_mr disassembly > target/rx: Emit all disassembly in one prt() > target/rx: Collect all bytes during disassembly > target/rx: Dump bytes for each insn during disassembly > hw/rx: Honor -accel qtest > > Yoshinori Sato (11): > MAINTAINERS: Add RX > qemu/bitops.h: Add extract8 and extract16 > target/rx: TCG translation > target/rx: TCG helper > target/rx: CPU definition > target/rx: RX disassembler > hw/intc: RX62N interrupt controller (ICUa) > hw/timer: RX62N internal timer modules > hw/char: RX62N serial communication interface (SCI) > hw/rx: RX Target hardware definition > Add rx-softmmu > > configure | 8 + > default-configs/rx-softmmu.mak | 3 + > qapi/machine.json | 3 +- > include/disas/dis-asm.h | 5 + > include/exec/poison.h | 1 + > include/hw/char/renesas_sci.h | 45 + > include/hw/intc/rx_icu.h | 56 + > include/hw/registerfields.h | 32 +- > include/hw/rx/rx.h | 7 + > include/hw/rx/rx62n.h | 91 + > include/hw/timer/renesas_cmt.h | 38 + > include/hw/timer/renesas_tmr.h | 53 + > include/qemu/bitops.h | 38 + > include/sysemu/arch_init.h | 1 + > target/rx/cpu-param.h | 31 + > target/rx/cpu-qom.h | 42 + > target/rx/cpu.h | 181 ++ > target/rx/helper.h | 31 + > arch_init.c | 2 + > hw/char/renesas_sci.c | 343 ++++ > hw/intc/rx_icu.c | 379 ++++ > hw/rx/rx-virt.c | 135 ++ > hw/rx/rx62n.c | 247 +++ > hw/timer/renesas_cmt.c | 278 +++ > hw/timer/renesas_tmr.c | 458 +++++ > target/rx/cpu.c | 217 +++ > target/rx/disas.c | 1446 ++++++++++++++ > target/rx/gdbstub.c | 112 ++ > target/rx/helper.c | 149 ++ > target/rx/op_helper.c | 470 +++++ > target/rx/translate.c | 2432 ++++++++++++++++++++++++ > tests/machine-none-test.c | 1 + > MAINTAINERS | 19 + > hw/Kconfig | 1 + > hw/char/Kconfig | 3 + > hw/char/Makefile.objs | 1 + > hw/intc/Kconfig | 3 + > hw/intc/Makefile.objs | 1 + > hw/rx/Kconfig | 14 + > hw/rx/Makefile.objs | 2 + > hw/timer/Kconfig | 6 + > hw/timer/Makefile.objs | 3 + > target/rx/Makefile.objs | 11 + > target/rx/insns.decode | 621 ++++++ > tests/acceptance/boot_linux_console.py | 46 + > 45 files changed, 8064 insertions(+), 2 deletions(-) > create mode 100644 default-configs/rx-softmmu.mak > create mode 100644 include/hw/char/renesas_sci.h > create mode 100644 include/hw/intc/rx_icu.h > create mode 100644 include/hw/rx/rx.h > create mode 100644 include/hw/rx/rx62n.h > create mode 100644 include/hw/timer/renesas_cmt.h > create mode 100644 include/hw/timer/renesas_tmr.h > create mode 100644 target/rx/cpu-param.h > create mode 100644 target/rx/cpu-qom.h > create mode 100644 target/rx/cpu.h > create mode 100644 target/rx/helper.h > create mode 100644 hw/char/renesas_sci.c > create mode 100644 hw/intc/rx_icu.c > create mode 100644 hw/rx/rx-virt.c > create mode 100644 hw/rx/rx62n.c > create mode 100644 hw/timer/renesas_cmt.c > create mode 100644 hw/timer/renesas_tmr.c > create mode 100644 target/rx/cpu.c > create mode 100644 target/rx/disas.c > create mode 100644 target/rx/gdbstub.c > create mode 100644 target/rx/helper.c > create mode 100644 target/rx/op_helper.c > create mode 100644 target/rx/translate.c > create mode 100644 hw/rx/Kconfig > create mode 100644 hw/rx/Makefile.objs > create mode 100644 target/rx/Makefile.objs > create mode 100644 target/rx/insns.decode > > -- > 2.20.1 > >
© 2016 - 2024 Red Hat, Inc.