MAINTAINERS: Add a TILE-Gx section

[PATCH] MAINTAINERS: Add a TILE-Gx section

Posted by Philippe Mathieu-Daudé 4 years, 6 months ago

The TILE-Gx architecture was missing its section, add it.

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
 MAINTAINERS | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index 3ca814850e..a3be0a4a31 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -299,6 +299,11 @@ F: hw/sparc64/
 F: include/hw/sparc/sparc64.h
 F: disas/sparc.c
 
+TILE-Gx CPUs
+M: Chen Gang <gang.chen.5i5j@gmail.com>
+S: Maintained
+F: target/tilegx/
+
 UniCore32 TCG CPUs
 M: Guan Xuetao <gxt@mprc.pku.edu.cn>
 S: Maintained
-- 
2.21.0

Re: [PATCH] MAINTAINERS: Add a TILE-Gx section

Posted by Aleksandar Markovic 4 years, 6 months ago

12.10.2019. 09.12, "Philippe Mathieu-Daudé" <philmd@redhat.com> је
написао/ла:
>
> The TILE-Gx architecture was missing its section, add it.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
>  MAINTAINERS | 5 +++++
>  1 file changed, 5 insertions(+)
>

It is certainly good that there is a maintainer for each QEMU component.
But:

- is Chen Gang available and willing to assume the role?

- sadly, tilegx arch support was recently removed from kernel upstream.
That does not mean (in my understanding) automatic removal from QEMU, but
certainly raises some eyebrows. Should we continue supporting tilegx?
Isthete any feedback from users, or the company that owns tilegx?

Sincerely,
Aleksandar

> diff --git a/MAINTAINERS b/MAINTAINERS
> index 3ca814850e..a3be0a4a31 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -299,6 +299,11 @@ F: hw/sparc64/
>  F: include/hw/sparc/sparc64.h
>  F: disas/sparc.c
>
> +TILE-Gx CPUs
> +M: Chen Gang <gang.chen.5i5j@gmail.com>
> +S: Maintained
> +F: target/tilegx/
> +
>  UniCore32 TCG CPUs
>  M: Guan Xuetao <gxt@mprc.pku.edu.cn>
>  S: Maintained
> --
> 2.21.0
>
>

Re: [PATCH] MAINTAINERS: Add a TILE-Gx section

Posted by Philippe Mathieu-Daudé 4 years, 5 months ago

On 10/12/19 2:40 PM, Aleksandar Markovic wrote:
> 
> 12.10.2019. 09.12, "Philippe Mathieu-Daudé" <philmd@redhat.com 
> <mailto:philmd@redhat.com>> је написао/ла:
>  >
>  > The TILE-Gx architecture was missing its section, add it.
>  >
>  > Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com 
> <mailto:philmd@redhat.com>>
>  > ---
>  >  MAINTAINERS | 5 +++++
>  >  1 file changed, 5 insertions(+)
>  >
> 
> It is certainly good that there is a maintainer for each QEMU component. 
> But:
> 
> - is Chen Gang available and willing to assume the role?

One month passed, so we can assume this architecture is orphan.
I'll prepare a patch.

> - sadly, tilegx arch support was recently removed from kernel upstream. 
> That does not mean (in my understanding) automatic removal from QEMU, 
> but certainly raises some eyebrows. Should we continue supporting 
> tilegx? Isthete any feedback from users, or the company that owns tilegx?

We should properly deprecate it, to give any users a chance to notice it 
and tell us. I'll prepare another patch.

> Sincerely,
> Aleksandar
> 
>  > diff --git a/MAINTAINERS b/MAINTAINERS
>  > index 3ca814850e..a3be0a4a31 100644
>  > --- a/MAINTAINERS
>  > +++ b/MAINTAINERS
>  > @@ -299,6 +299,11 @@ F: hw/sparc64/
>  >  F: include/hw/sparc/sparc64.h
>  >  F: disas/sparc.c
>  >
>  > +TILE-Gx CPUs
>  > +M: Chen Gang <gang.chen.5i5j@gmail.com 
> <mailto:gang.chen.5i5j@gmail.com>>
>  > +S: Maintained
>  > +F: target/tilegx/
>  > +
>  >  UniCore32 TCG CPUs
>  >  M: Guan Xuetao <gxt@mprc.pku.edu.cn <mailto:gxt@mprc.pku.edu.cn>>
>  >  S: Maintained
>  > --
>  > 2.21.0
>  >
>  >
>

Re: [PATCH] MAINTAINERS: Add a TILE-Gx section

Posted by Aleksandar Markovic 4 years, 5 months ago

ū

On Monday, November 18, 2019, Philippe Mathieu-Daudé <philmd@redhat.com>
wrote:

> On 10/12/19 2:40 PM, Aleksandar Markovic wrote:
>
>>
>> 12.10.2019. 09.12, "Philippe Mathieu-Daudé" <philmd@redhat.com <mailto:
>> philmd@redhat.com>> је написао/ла:
>>  >
>>  > The TILE-Gx architecture was missing its section, add it.
>>  >
>>  > Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com <mailto:
>> philmd@redhat.com>>
>>  > ---
>>  >  MAINTAINERS | 5 +++++
>>  >  1 file changed, 5 insertions(+)
>>  >
>>
>> It is certainly good that there is a maintainer for each QEMU component.
>> But:
>>
>> - is Chen Gang available and willing to assume the role?
>>
>
> One month passed, so we can assume this architecture is orphan.
> I'll prepare a patch.
>
> - sadly, tilegx arch support was recently removed from kernel upstream.
>> That does not mean (in my understanding) automatic removal from QEMU, but
>> certainly raises some eyebrows. Should we continue supporting tilegx?
>> Isthete any feedback from users, or the company that owns tilegx?
>>
>
> We should properly deprecate it, to give any users a chance to notice it
> and tell us. I'll prepare another patch.
>
>
Philippe, all what you said here sounds reasonable and appropriate to me.
Thanks for readiness to follow up.

A.




> Sincerely,
>> Aleksandar
>>
>>  > diff --git a/MAINTAINERS b/MAINTAINERS
>>  > index 3ca814850e..a3be0a4a31 100644
>>  > --- a/MAINTAINERS
>>  > +++ b/MAINTAINERS
>>  > @@ -299,6 +299,11 @@ F: hw/sparc64/
>>  >  F: include/hw/sparc/sparc64.h
>>  >  F: disas/sparc.c
>>  >
>>  > +TILE-Gx CPUs
>>  > +M: Chen Gang <gang.chen.5i5j@gmail.com <mailto:gang.chen.5i5j@gmail.
>> com>>
>>  > +S: Maintained
>>  > +F: target/tilegx/
>>  > +
>>  >  UniCore32 TCG CPUs
>>  >  M: Guan Xuetao <gxt@mprc.pku.edu.cn <mailto:gxt@mprc.pku.edu.cn>>
>>  >  S: Maintained
>>  > --
>>  > 2.21.0
>>  >
>>  >
>>
>>
>