[v5] error: auto propagated local_err

[RFC v5 020/126] include/qom/object.h: rename Error ** parameter to more common errp

Posted by Vladimir Sementsov-Ogievskiy 6 years, 4 months ago

Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
---
 include/qom/object.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/qom/object.h b/include/qom/object.h
index 128d00c77f..716f6f655d 100644
--- a/include/qom/object.h
+++ b/include/qom/object.h
@@ -1635,9 +1635,9 @@ void object_class_property_add_uint32_ptr(ObjectClass *klass, const char *name,
  * property of type 'uint64'.
  */
 void object_property_add_uint64_ptr(Object *obj, const char *name,
-                                    const uint64_t *v, Error **Errp);
+                                    const uint64_t *v, Error **errp);
 void object_class_property_add_uint64_ptr(ObjectClass *klass, const char *name,
-                                          const uint64_t *v, Error **Errp);
+                                          const uint64_t *v, Error **errp);
 
 /**
  * object_property_add_alias:
-- 
2.21.0

Re: [RFC v5 020/126] include/qom/object.h: rename Error ** parameter to more common errp

Posted by Philippe Mathieu-Daudé 6 years, 3 months ago

On 10/11/19 6:04 PM, Vladimir Sementsov-Ogievskiy wrote:
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> ---
>   include/qom/object.h | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/include/qom/object.h b/include/qom/object.h
> index 128d00c77f..716f6f655d 100644
> --- a/include/qom/object.h
> +++ b/include/qom/object.h
> @@ -1635,9 +1635,9 @@ void object_class_property_add_uint32_ptr(ObjectClass *klass, const char *name,
>    * property of type 'uint64'.
>    */
>   void object_property_add_uint64_ptr(Object *obj, const char *name,
> -                                    const uint64_t *v, Error **Errp);
> +                                    const uint64_t *v, Error **errp);
>   void object_class_property_add_uint64_ptr(ObjectClass *klass, const char *name,
> -                                          const uint64_t *v, Error **Errp);
> +                                          const uint64_t *v, Error **errp);

Oddly the implementation already use lowercase.

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>

>   
>   /**
>    * object_property_add_alias:
>