[PULL v2 0/8] 9p patches 2019-10-10

Greg Kurz posted 8 patches 6 years, 1 month ago
Test asan passed
Test checkpatch passed
Test FreeBSD passed
Test docker-mingw@fedora passed
Test docker-clang@ubuntu passed
Test docker-quick@centos7 passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20191010131809.1284004-1-groug@kaod.org
Maintainers: Paolo Bonzini <pbonzini@redhat.com>, Greg Kurz <groug@kaod.org>
MAINTAINERS                 |   2 +-
fsdev/9p-marshal.h          |   6 +-
fsdev/file-op-9p.h          |   5 +
fsdev/qemu-fsdev-opts.c     |   7 +-
fsdev/qemu-fsdev-throttle.c |   4 +-
fsdev/qemu-fsdev-throttle.h |   2 +-
fsdev/qemu-fsdev.c          |   1 +
hw/9pfs/9p-local.c          |  28 ++-
hw/9pfs/9p-proxy.c          |   4 +
hw/9pfs/9p.c                | 534 ++++++++++++++++++++++++++++++++++++++++----
hw/9pfs/9p.h                |  60 +++++
hw/9pfs/trace-events        |  14 +-
qemu-options.hx             |  26 ++-
vl.c                        |   7 +-
14 files changed, 639 insertions(+), 61 deletions(-)
[PULL v2 0/8] 9p patches 2019-10-10
Posted by Greg Kurz 6 years, 1 month ago
The following changes since commit 98b2e3c9ab3abfe476a2b02f8f51813edb90e72d:

  Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' into staging (2019-10-08 16:08:35 +0100)

are available in the Git repository at:

  https://github.com/gkurz/qemu.git tags/9p-next-2019-10-10

for you to fetch changes up to e410bbc52a7a246858af54ce1842fadf26f39ff7:

  MAINTAINERS: Downgrade status of virtio-9p to "Odd Fixes" (2019-10-10 12:36:28 +0200)

----------------------------------------------------------------
The most notable change is that we now detect cross-device setups in the
host since it may cause inode number collision and mayhem in the guest.
A new fsdev property is added for the user to choose the appropriate
policy to handle that: either remap all inode numbers or fail I/Os to
another host device or just print out a warning (default behaviour).

This is also my last PR as _active_ maintainer of 9pfs.

----------------------------------------------------------------
Antonios Motakis (4):
      9p: unsigned type for type, version, path
      9p: Treat multiple devices on one export as an error
      9p: Added virtfs option 'multidevs=remap|forbid|warn'
      9p: stat_to_qid: implement slow path

Christian Schoenebeck (1):
      9p: Use variable length suffixes for inode remapping

Greg Kurz (3):
      9p: Simplify error path of v9fs_device_realize_common()
      fsdev: Add return value to fsdev_throttle_parse_opts()
      MAINTAINERS: Downgrade status of virtio-9p to "Odd Fixes"

 MAINTAINERS                 |   2 +-
 fsdev/9p-marshal.h          |   6 +-
 fsdev/file-op-9p.h          |   5 +
 fsdev/qemu-fsdev-opts.c     |   7 +-
 fsdev/qemu-fsdev-throttle.c |   4 +-
 fsdev/qemu-fsdev-throttle.h |   2 +-
 fsdev/qemu-fsdev.c          |   1 +
 hw/9pfs/9p-local.c          |  28 ++-
 hw/9pfs/9p-proxy.c          |   4 +
 hw/9pfs/9p.c                | 534 ++++++++++++++++++++++++++++++++++++++++----
 hw/9pfs/9p.h                |  60 +++++
 hw/9pfs/trace-events        |  14 +-
 qemu-options.hx             |  26 ++-
 vl.c                        |   7 +-
 14 files changed, 639 insertions(+), 61 deletions(-)
-- 
2.21.0


Re: [PULL v2 0/8] 9p patches 2019-10-10
Posted by Peter Maydell 6 years ago
On Thu, 10 Oct 2019 at 14:18, Greg Kurz <groug@kaod.org> wrote:
>
> The following changes since commit 98b2e3c9ab3abfe476a2b02f8f51813edb90e72d:
>
>   Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' into staging (2019-10-08 16:08:35 +0100)
>
> are available in the Git repository at:
>
>   https://github.com/gkurz/qemu.git tags/9p-next-2019-10-10
>
> for you to fetch changes up to e410bbc52a7a246858af54ce1842fadf26f39ff7:
>
>   MAINTAINERS: Downgrade status of virtio-9p to "Odd Fixes" (2019-10-10 12:36:28 +0200)
>
> ----------------------------------------------------------------
> The most notable change is that we now detect cross-device setups in the
> host since it may cause inode number collision and mayhem in the guest.
> A new fsdev property is added for the user to choose the appropriate
> policy to handle that: either remap all inode numbers or fail I/Os to
> another host device or just print out a warning (default behaviour).
>
> This is also my last PR as _active_ maintainer of 9pfs.
>
> ----------------------------------------------------------------


Applied, thanks.

Please update the changelog at https://wiki.qemu.org/ChangeLog/4.2
for any user-visible changes.

Thanks for all your work on the 9pfs code!

-- PMM

Re: [PULL v2 0/8] 9p patches 2019-10-10
Posted by Greg Kurz 6 years ago
On Mon, 14 Oct 2019 15:08:52 +0100
Peter Maydell <peter.maydell@linaro.org> wrote:

> On Thu, 10 Oct 2019 at 14:18, Greg Kurz <groug@kaod.org> wrote:
> >
> > The following changes since commit 98b2e3c9ab3abfe476a2b02f8f51813edb90e72d:
> >
> >   Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' into staging (2019-10-08 16:08:35 +0100)
> >
> > are available in the Git repository at:
> >
> >   https://github.com/gkurz/qemu.git tags/9p-next-2019-10-10
> >
> > for you to fetch changes up to e410bbc52a7a246858af54ce1842fadf26f39ff7:
> >
> >   MAINTAINERS: Downgrade status of virtio-9p to "Odd Fixes" (2019-10-10 12:36:28 +0200)
> >
> > ----------------------------------------------------------------
> > The most notable change is that we now detect cross-device setups in the
> > host since it may cause inode number collision and mayhem in the guest.
> > A new fsdev property is added for the user to choose the appropriate
> > policy to handle that: either remap all inode numbers or fail I/Os to
> > another host device or just print out a warning (default behaviour).
> >
> > This is also my last PR as _active_ maintainer of 9pfs.
> >
> > ----------------------------------------------------------------
> 
> 
> Applied, thanks.
> 
> Please update the changelog at https://wiki.qemu.org/ChangeLog/4.2
> for any user-visible changes.
> 
> Thanks for all your work on the 9pfs code!
> 

Thanks Peter, and many others, for your valuable help.

As now indicated in MAINTAINERS, I'll stay around for odd fixes, one
of which that comes to mind is to deprecate the "proxy" backend and
its companion virtfs-proxy-helper binary at some point since it isn't
supported by libvirt and will be superseded soon by "virtio-fs".

Cheers,

--
Greg

> -- PMM