The BCM2838 has many more peripherals than his little brother,
the BCM2837. With the raspi4, the Linux kernel takes more steps
to configure the various MUXed devices. At some point it started
to bug me, so I plan to add a dummy simple BCM2835_SPI block.
It is cleaner to add it as a separate device than mixed with the
AUX block. As a first step, split the UART block out.

Since this part is self-contained and my raspi4 branch is getting
too big, I'm sending it as a single series.

Regards,

Phil.

Philippe Mathieu-Daudé (3):
  hw/char: Add the BCM2835 miniuart
  hw/char/bcm2835_aux: Use the BCM2835 miniuart block
  hw: Move BCM2835 AUX device from hw/char/ to hw/misc/

 hw/char/Makefile.objs                   |   2 +-
 hw/char/bcm2835_aux.c                   | 317 -----------------------
 hw/char/bcm2835_miniuart.c              | 327 ++++++++++++++++++++++++
 hw/char/trace-events                    |   4 +
 hw/misc/Makefile.objs                   |   1 +
 hw/misc/bcm2835_aux.c                   | 189 ++++++++++++++
 hw/misc/trace-events                    |   4 +
 include/hw/arm/bcm2835_peripherals.h    |   2 +-
 include/hw/char/bcm2835_miniuart.h      |  37 +++
 include/hw/{char => misc}/bcm2835_aux.h |  10 +-
 10 files changed, 567 insertions(+), 326 deletions(-)
 delete mode 100644 hw/char/bcm2835_aux.c
 create mode 100644 hw/char/bcm2835_miniuart.c
 create mode 100644 hw/misc/bcm2835_aux.c
 create mode 100644 include/hw/char/bcm2835_miniuart.h
 rename include/hw/{char => misc}/bcm2835_aux.h (73%)

-- 
2.21.0

On Mon, 7 Oct 2019 at 18:06, Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
>
> The BCM2838 has many more peripherals than his little brother,
> the BCM2837. With the raspi4, the Linux kernel takes more steps
> to configure the various MUXed devices. At some point it started
> to bug me, so I plan to add a dummy simple BCM2835_SPI block.
> It is cleaner to add it as a separate device than mixed with the
> AUX block. As a first step, split the UART block out.
>
> Since this part is self-contained and my raspi4 branch is getting
> too big, I'm sending it as a single series.

If you squash patches 1 and 2 together and avoid doing
things like renaming all the register offset constant
names (or, for stuff like fixing up comment syntax and
checkpatch nits, do them in a preparatory patch), then it
becomes somewhat easier to review, because then you can use
git diff --color-moved and can see easily that code has
only been moved to the other file without any accidental
extra changes.

thanks
-- PMM

Patchew URL: https://patchew.org/QEMU/20191007170646.14961-1-f4bug@amsat.org/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [PATCH 0/3] hw/arm/raspi: Split the UART block from the AUX block
Message-id: 20191007170646.14961-1-f4bug@amsat.org
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Switched to a new branch 'test'
3ee4459 hw: Move BCM2835 AUX device from hw/char/ to hw/misc/
4109add hw/char/bcm2835_aux: Use the BCM2835 miniuart block
c19904e hw/char: Add the BCM2835 miniuart

=== OUTPUT BEGIN ===
1/3 Checking commit c19904eab80f (hw/char: Add the BCM2835 miniuart)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#29: 
new file mode 100644

total: 0 errors, 1 warnings, 380 lines checked

Patch 1/3 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
2/3 Checking commit 4109addacc9f (hw/char/bcm2835_aux: Use the BCM2835 miniuart block)
ERROR: do not initialise statics to 0 or NULL
#73: FILE: hw/char/bcm2835_aux.c:28:
+static const bool aux_enable_supported = false;

total: 1 errors, 0 warnings, 397 lines checked

Patch 2/3 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

3/3 Checking commit 3ee4459660f9 (hw: Move BCM2835 AUX device from hw/char/ to hw/misc/)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#53: 
rename from hw/char/bcm2835_aux.c

total: 0 errors, 1 warnings, 48 lines checked

Patch 3/3 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20191007170646.14961-1-f4bug@amsat.org/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com