[PATCH] .travis.yml: reduce scope of the --enable-debug build

Alex Bennée posted 1 patch 2 weeks ago
Test FreeBSD passed
Test docker-mingw@fedora passed
Test asan passed
Test docker-quick@centos7 passed
Test checkpatch passed
Test docker-clang@ubuntu passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20191007160708.26208-1-alex.bennee@linaro.org
.travis.yml | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)

[PATCH] .travis.yml: reduce scope of the --enable-debug build

Posted by Alex Bennée 2 weeks ago
Adding debug makes things run a bit slower so lets not hammer all the
targets.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
 .travis.yml | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/.travis.yml b/.travis.yml
index d0b9e099b9..fc0888aff5 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -124,12 +124,13 @@ matrix:
         - CACHE_NAME="${TRAVIS_BRANCH}-linux-gcc-default"
 
 
+    # --enable-debug implies --enable-debug-tcg, also runs quite a bit slower
     - env:
-        - CONFIG="--enable-debug --enable-debug-tcg --disable-user"
+        - CONFIG="--enable-debug --enable-debug-tcg --target-list=${MAIN_SOFTMMU_TARGETS}"
         - CACHE_NAME="${TRAVIS_BRANCH}-linux-gcc-debug"
 
 
-    # TCG debug can be run just on it's own and is mostly agnostic to user/softmmu distinctions
+    # TCG debug can be run just on its own and is mostly agnostic to user/softmmu distinctions
     - env:
         - CONFIG="--enable-debug-tcg --disable-system"
         - CACHE_NAME="${TRAVIS_BRANCH}-linux-gcc-debug"
-- 
2.20.1


Re: [PATCH] .travis.yml: reduce scope of the --enable-debug build

Posted by Peter Maydell 2 weeks ago
On Mon, 7 Oct 2019 at 17:22, Alex Bennée <alex.bennee@linaro.org> wrote:
>
> Adding debug makes things run a bit slower so lets not hammer all the
> targets.
>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
>  .travis.yml | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/.travis.yml b/.travis.yml
> index d0b9e099b9..fc0888aff5 100644
> --- a/.travis.yml
> +++ b/.travis.yml
> @@ -124,12 +124,13 @@ matrix:
>          - CACHE_NAME="${TRAVIS_BRANCH}-linux-gcc-default"
>
>
> +    # --enable-debug implies --enable-debug-tcg, also runs quite a bit slower
>      - env:
> -        - CONFIG="--enable-debug --enable-debug-tcg --disable-user"
> +        - CONFIG="--enable-debug --enable-debug-tcg --target-list=${MAIN_SOFTMMU_TARGETS}"
>          - CACHE_NAME="${TRAVIS_BRANCH}-linux-gcc-debug"

If (as noted in the comment) --enable-debug implies
--enable-debug-tcg, why do we need to give both options ?

thanks
-- PMM

Re: [PATCH] .travis.yml: reduce scope of the --enable-debug build

Posted by Alex Bennée 2 weeks ago
Peter Maydell <peter.maydell@linaro.org> writes:

> On Mon, 7 Oct 2019 at 17:22, Alex Bennée <alex.bennee@linaro.org> wrote:
>>
>> Adding debug makes things run a bit slower so lets not hammer all the
>> targets.
>>
>> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
>> ---
>>  .travis.yml | 5 +++--
>>  1 file changed, 3 insertions(+), 2 deletions(-)
>>
>> diff --git a/.travis.yml b/.travis.yml
>> index d0b9e099b9..fc0888aff5 100644
>> --- a/.travis.yml
>> +++ b/.travis.yml
>> @@ -124,12 +124,13 @@ matrix:
>>          - CACHE_NAME="${TRAVIS_BRANCH}-linux-gcc-default"
>>
>>
>> +    # --enable-debug implies --enable-debug-tcg, also runs quite a bit slower
>>      - env:
>> -        - CONFIG="--enable-debug --enable-debug-tcg --disable-user"
>> +        - CONFIG="--enable-debug --enable-debug-tcg --target-list=${MAIN_SOFTMMU_TARGETS}"
>>          - CACHE_NAME="${TRAVIS_BRANCH}-linux-gcc-debug"
>
> If (as noted in the comment) --enable-debug implies
> --enable-debug-tcg, why do we need to give both options ?

We don't really - I was just being verbose. I'll drop it.

>
> thanks
> -- PMM


--
Alex Bennée

Re: [PATCH] .travis.yml: reduce scope of the --enable-debug build

Posted by Philippe Mathieu-Daudé 2 weeks ago
On 10/7/19 9:05 PM, Alex Bennée wrote:
> 
> Peter Maydell <peter.maydell@linaro.org> writes:
> 
>> On Mon, 7 Oct 2019 at 17:22, Alex Bennée <alex.bennee@linaro.org> wrote:
>>>
>>> Adding debug makes things run a bit slower so lets not hammer all the
>>> targets.
>>>
>>> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
>>> ---
>>>   .travis.yml | 5 +++--
>>>   1 file changed, 3 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/.travis.yml b/.travis.yml
>>> index d0b9e099b9..fc0888aff5 100644
>>> --- a/.travis.yml
>>> +++ b/.travis.yml
>>> @@ -124,12 +124,13 @@ matrix:
>>>           - CACHE_NAME="${TRAVIS_BRANCH}-linux-gcc-default"
>>>
>>>
>>> +    # --enable-debug implies --enable-debug-tcg, also runs quite a bit slower
>>>       - env:
>>> -        - CONFIG="--enable-debug --enable-debug-tcg --disable-user"
>>> +        - CONFIG="--enable-debug --enable-debug-tcg --target-list=${MAIN_SOFTMMU_TARGETS}"
>>>           - CACHE_NAME="${TRAVIS_BRANCH}-linux-gcc-debug"
>>
>> If (as noted in the comment) --enable-debug implies
>> --enable-debug-tcg, why do we need to give both options ?
> 
> We don't really - I was just being verbose. I'll drop it.

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>