On Mon, Oct 07, 2019 at 05:31:32PM +0100, Peter Maydell wrote:
> On Sat, 5 Oct 2019 at 22:58, Michael S. Tsirkin <mst@redhat.com> wrote:
> >
> > A couple of tweaks to the bios table test weren't
> > reviewed yet but as they are really helpful to
> > the arm tests I'm pushing, and affecting only the
> > test so fairly benign (dropped assert + a comment),
> > I cut a corner and pushed them straight away.
> > Will be easy to tweak with a patch on top or revert.
> >
> > The following changes since commit 4f59102571fce49af180cfc6d4cdd2b5df7bdb14:
> >
> > Merge remote-tracking branch 'remotes/amarkovic/tags/mips-queue-oct-01-2019' into staging (2019-10-01 16:21:42 +0100)
> >
> > are available in the Git repository at:
> >
> > git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstream
> >
> > for you to fetch changes up to 9d59bed1da5e5815987879346cf708344060ea63:
> >
> > virtio: add vhost-user-fs-pci device (2019-10-05 17:43:55 -0400)
> >
> > ----------------------------------------------------------------
> > virtio, vhost, acpi: features, fixes, tests
> >
> > Tests for arm/virt ACPI tables.
> > Virtio fs support (no migration).
> > A vhost-user reconnect bugfix.
>
> Hi -- this summary of the changes just says it has
> updates to the test code, but the patches include:
>
> > Shameer Kolothum (8):
> > hw/arm/virt: Enable device memory cold/hot plug with ACPI boot
>
> which is to say actually enabling the hotplug memory feature,
> not just tweaking tests. Did you mean to put the whole feature
> in this pullreq? (If you did, that's fine, it just doesn't
> match up with the cover letter so maybe it was an accident?)
>
> thanks
> -- PMM
Yes this was intentional. I meant I was asked to merge it because of
the tests. But tests wouldn't pass without the feature :)
I've updated the description. Pls pull.
--
MST