[PATCH v2 0/2] curses: fix attribute passing

Matthew Kilgore posted 2 patches 6 years, 1 month ago
Test checkpatch passed
Test docker-mingw@fedora passed
Test docker-quick@centos7 passed
Test docker-clang@ubuntu failed
Test asan passed
Test FreeBSD passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20191004035338.25601-1-mattkilgore12@gmail.com
Maintainers: Gerd Hoffmann <kraxel@redhat.com>
ui/curses.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
[PATCH v2 0/2] curses: fix attribute passing
Posted by Matthew Kilgore 6 years, 1 month ago
This patch set fixes up ui/curses.c. A previous change to ui/curses.c,
commit 962cf8fd4fae ("ui/curses: manipulate cchar_t with standard curses
functions"), did not correctly pass the attributes from the chtype to
`setcchar()`.

The biggest issue this caused is that colors no longer work when using
the curses display, it instead renders everything in white on black.
This was fixed by correctly passing the color pair number to setcchar().
I also fixed two spots where 0xff was used instead of the bit mask
constants that are part of the curses API.

changes in v2:
- Split into two patches, one dealing with the attribute masks, and one
  dealing with correctly passing the color pair number.

Thanks,
Matthew Kilgore

Matthew Kilgore (2):
  curses: use the bit mask constants provided by curses
  curses: correctly pass the color pair to setcchar()

 ui/curses.c | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

-- 
2.23.0