Some win32 fixes

[PATCH 0/3] Some win32 fixes

Posted by Marc-André Lureau 4 years, 6 months ago

Hi,

Here are a few patches that should fix some busy looping issues
already reported >2y ago
(https://lists.gnu.org/archive/html/qemu-devel/2017-01/msg00420.html),
and fixing test-char on win32.

hmm, do we have any automated testing/CI on Windows (beside just
cross-compilation)?

thanks

Marc-André Lureau (3):
  util: WSAEWOULDBLOCK on connect should map to EINPROGRESS
  tests: skip serial test on windows
  win32: fix main-loop busy loop on socket/fd event

 tests/test-char.c  | 4 ++--
 util/async.c       | 6 +++++-
 util/oslib-win32.c | 6 +++++-
 3 files changed, 12 insertions(+), 4 deletions(-)

-- 
2.23.0

Re: [PATCH 0/3] Some win32 fixes

Posted by Alex Bennée 4 years, 6 months ago

Marc-André Lureau <marcandre.lureau@redhat.com> writes:

> Hi,
>
> Here are a few patches that should fix some busy looping issues
> already reported >2y ago
> (https://lists.gnu.org/archive/html/qemu-devel/2017-01/msg00420.html),
> and fixing test-char on win32.
>
> hmm, do we have any automated testing/CI on Windows (beside just
> cross-compilation)?

Not that I'm aware of. I did briefly look at CircleCI but never beyond
playing with my own experiments. Ultimately I find it hard to care about
Windows as I don't have a copy myself. Maybe someone else does care and
would like to explore further?

FWIW I believe Travis has Windows support now and there is also
AppVeyor. It's probably worth spreading the love around given how loaded
our Travis jobs are.

>
> thanks
>
> Marc-André Lureau (3):
>   util: WSAEWOULDBLOCK on connect should map to EINPROGRESS
>   tests: skip serial test on windows
>   win32: fix main-loop busy loop on socket/fd event
>
>  tests/test-char.c  | 4 ++--
>  util/async.c       | 6 +++++-
>  util/oslib-win32.c | 6 +++++-
>  3 files changed, 12 insertions(+), 4 deletions(-)

--
Alex Bennée

Re: [PATCH 0/3] Some win32 fixes

Posted by Thomas Huth 4 years, 6 months ago

On 01/10/2019 15.26, Marc-André Lureau wrote:
> Hi,
> 
> Here are a few patches that should fix some busy looping issues
> already reported >2y ago
> (https://lists.gnu.org/archive/html/qemu-devel/2017-01/msg00420.html),
> and fixing test-char on win32.
> 
> hmm, do we have any automated testing/CI on Windows (beside just
> cross-compilation)?

AFAIK we do not have any automated CI on Windows yet. But seems like
both, Travis and Cirrus, have Windows support, so you could add a test
to our .travis.yml or .cirrus.yml file, I think.

 Thomas

Re: [PATCH 0/3] Some win32 fixes

Posted by Paolo Bonzini 4 years, 6 months ago

On 01/10/19 15:26, Marc-André Lureau wrote:
> Hi,
> 
> Here are a few patches that should fix some busy looping issues
> already reported >2y ago
> (https://lists.gnu.org/archive/html/qemu-devel/2017-01/msg00420.html),
> and fixing test-char on win32.

Queued thanks (with s/fix/work around/ in the commit subject of
patch 3).

> hmm, do we have any automated testing/CI on Windows (beside just
> cross-compilation)?

Nope. :(

Paolo

Re: [PATCH 0/3] Some win32 fixes

Posted by Peter Maydell 4 years, 6 months ago

On Tue, 1 Oct 2019 at 14:43, Paolo Bonzini <pbonzini@redhat.com> wrote:
>
> On 01/10/19 15:26, Marc-André Lureau wrote:
> > hmm, do we have any automated testing/CI on Windows (beside just
> > cross-compilation)?
>
> Nope. :(

I did wonder whether it would be possible to get 'make check'
passing under Wine, but never investigated...

thanks
-- PMM

Re: [PATCH 0/3] Some win32 fixes

Posted by Stefan Weil 4 years, 6 months ago

Am 01.10.2019 um 15:44 schrieb Peter Maydell:
> On Tue, 1 Oct 2019 at 14:43, Paolo Bonzini <pbonzini@redhat.com> wrote:
>> On 01/10/19 15:26, Marc-André Lureau wrote:
>>> hmm, do we have any automated testing/CI on Windows (beside just
>>> cross-compilation)?
>> Nope. :(
> I did wonder whether it would be possible to get 'make check'
> passing under Wine, but never investigated...
>
> thanks
> -- PMM

Running "make check" under Wine had worked for me (well, at least
partially) in the past. Of course it is not a full replacement for tests
under Windows, but it should be sufficient to cover most of the
functionality. Usually I also use Wine to examine bug reports for Windows.

Are there test servers with Wine available?

Regards,
Stefan Weil

Re: [PATCH 0/3] Some win32 fixes

Posted by Philippe Mathieu-Daudé 4 years, 6 months ago

On 10/1/19 3:44 PM, Peter Maydell wrote:
> On Tue, 1 Oct 2019 at 14:43, Paolo Bonzini <pbonzini@redhat.com> wrote:
>>
>> On 01/10/19 15:26, Marc-André Lureau wrote:
>>> hmm, do we have any automated testing/CI on Windows (beside just
>>> cross-compilation)?
>>
>> Nope. :(
> 
> I did wonder whether it would be possible to get 'make check'
> passing under Wine, but never investigated...

Nelson Chen started to use Azure CI:

https://github.com/nelsonjchen/nc-qemu/blob/master/.azure/msys2-build.sh

He posted some notes here:

https://mindflakes.com/projects/nc-qemu/

I have this link in my CI TODO to try to upstream it and run 'make 
check' but it is not a high priority.