[v1] iotests: trivial cleanups

[PATCH 0/4] iotests: trivial cleanups

Cleber Rosa posted 4 patches 6 years, 1 month ago

Diff against v2
Download series mbox

Test docker-mingw@fedora failed

Test checkpatch passed

Test docker-clang@ubuntu failed

Test docker-quick@centos7 failed

Test FreeBSD passed

Test asan failed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20190927141728.7137-1-crosa@redhat.com

Maintainers: Kevin Wolf <kwolf@redhat.com>, Max Reitz <mreitz@redhat.com>

There is a newer version of this series

tests/qemu-iotests/044            | 4 ----
tests/qemu-iotests/common.config  | 5 -----
tests/qemu-iotests/common.filter  | 5 -----
tests/qemu-iotests/common.nbd     | 1 -
tests/qemu-iotests/common.pattern | 2 --
tests/qemu-iotests/common.qemu    | 2 --
tests/qemu-iotests/common.rc      | 5 -----
tests/qemu-iotests/common.tls     | 2 --
8 files changed, 26 deletions(-)

Expand all Fold all

[PATCH 0/4] iotests: trivial cleanups

Posted by Cleber Rosa 6 years, 1 month ago

The most trivial set of cleanups to iotests common libraries and the
044 test.

Cleber Rosa (4):
  qemu-iotests: remove bash shebang from library files
  qemu-iotests: remove forceful execution success from library files
  qemu-iotests: 044: pass is actually a noop, so remove it
  qemu-iotests: 044: remove inaccurate docstring class description

 tests/qemu-iotests/044            | 4 ----
 tests/qemu-iotests/common.config  | 5 -----
 tests/qemu-iotests/common.filter  | 5 -----
 tests/qemu-iotests/common.nbd     | 1 -
 tests/qemu-iotests/common.pattern | 2 --
 tests/qemu-iotests/common.qemu    | 2 --
 tests/qemu-iotests/common.rc      | 5 -----
 tests/qemu-iotests/common.tls     | 2 --
 8 files changed, 26 deletions(-)

-- 
2.21.0

Re: [PATCH 0/4] iotests: trivial cleanups

Posted by Max Reitz 6 years, 1 month ago

On 27.09.19 16:17, Cleber Rosa wrote:
> The most trivial set of cleanups to iotests common libraries and the
> 044 test.
> 
> Cleber Rosa (4):
>   qemu-iotests: remove bash shebang from library files
>   qemu-iotests: remove forceful execution success from library files
>   qemu-iotests: 044: pass is actually a noop, so remove it
>   qemu-iotests: 044: remove inaccurate docstring class description
> 
>  tests/qemu-iotests/044            | 4 ----
>  tests/qemu-iotests/common.config  | 5 -----
>  tests/qemu-iotests/common.filter  | 5 -----
>  tests/qemu-iotests/common.nbd     | 1 -
>  tests/qemu-iotests/common.pattern | 2 --
>  tests/qemu-iotests/common.qemu    | 2 --
>  tests/qemu-iotests/common.rc      | 5 -----
>  tests/qemu-iotests/common.tls     | 2 --
>  8 files changed, 26 deletions(-)

Looks OK to me, but I’d like to know what you think about Eric’s concern
on patch 1.

Max

Re: [PATCH 0/4] iotests: trivial cleanups

Posted by Cleber Rosa 6 years, 1 month ago

On Mon, Oct 07, 2019 at 03:09:25PM +0200, Max Reitz wrote:
> On 27.09.19 16:17, Cleber Rosa wrote:
> > The most trivial set of cleanups to iotests common libraries and the
> > 044 test.
> > 
> > Cleber Rosa (4):
> >   qemu-iotests: remove bash shebang from library files
> >   qemu-iotests: remove forceful execution success from library files
> >   qemu-iotests: 044: pass is actually a noop, so remove it
> >   qemu-iotests: 044: remove inaccurate docstring class description
> > 
> >  tests/qemu-iotests/044            | 4 ----
> >  tests/qemu-iotests/common.config  | 5 -----
> >  tests/qemu-iotests/common.filter  | 5 -----
> >  tests/qemu-iotests/common.nbd     | 1 -
> >  tests/qemu-iotests/common.pattern | 2 --
> >  tests/qemu-iotests/common.qemu    | 2 --
> >  tests/qemu-iotests/common.rc      | 5 -----
> >  tests/qemu-iotests/common.tls     | 2 --
> >  8 files changed, 26 deletions(-)
> 
> Looks OK to me, but I’d like to know what you think about Eric’s concern
> on patch 1.
> 
> Max
> 

Yep, I agree with Eric's point.  Will send a v2 shortly.

Thanks,
- Cleber.