[v1] iotests: Allow ./check -o data_file

[PATCH 06/18] iotests: Inject space into -ocompat=0.10 in 051

Posted by Max Reitz 6 years, 1 month ago

It did not matter before, but now that _make_test_img understands -o, we
should use it properly here.

Signed-off-by: Max Reitz <mreitz@redhat.com>
---
 tests/qemu-iotests/051 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/qemu-iotests/051 b/tests/qemu-iotests/051
index 53bcdbc911..9cd1d60d45 100755
--- a/tests/qemu-iotests/051
+++ b/tests/qemu-iotests/051
@@ -157,7 +157,7 @@ echo
 echo === With version 2 images enabling lazy refcounts must fail ===
 echo
 
-_make_test_img -ocompat=0.10 $size
+_make_test_img -o compat=0.10 $size
 
 run_qemu -drive file="$TEST_IMG",format=qcow2,lazy-refcounts=on
 run_qemu -drive file="$TEST_IMG",format=qcow2,lazy-refcounts=off
-- 
2.21.0

Re: [PATCH 06/18] iotests: Inject space into -ocompat=0.10 in 051

Posted by Maxim Levitsky 6 years, 1 month ago

On Fri, 2019-09-27 at 11:42 +0200, Max Reitz wrote:
> It did not matter before, but now that _make_test_img understands -o, we
> should use it properly here.
> 
> Signed-off-by: Max Reitz <mreitz@redhat.com>
> ---
>  tests/qemu-iotests/051 | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/qemu-iotests/051 b/tests/qemu-iotests/051
> index 53bcdbc911..9cd1d60d45 100755
> --- a/tests/qemu-iotests/051
> +++ b/tests/qemu-iotests/051
> @@ -157,7 +157,7 @@ echo
>  echo === With version 2 images enabling lazy refcounts must fail ===
>  echo
>  
> -_make_test_img -ocompat=0.10 $size
> +_make_test_img -o compat=0.10 $size
>  
>  run_qemu -drive file="$TEST_IMG",format=qcow2,lazy-refcounts=on
>  run_qemu -drive file="$TEST_IMG",format=qcow2,lazy-refcounts=off
Reviewed-by: Maxim Levitsky <mlevitsk@redhat.com>