target/i386: cpu.h macros clean up

[PATCH v5 0/2] target/i386: cpu.h macros clean up

Tao Xu posted 2 patches 4 years, 7 months ago

Download series mbox

Test docker-mingw@fedora passed

Test checkpatch passed

Test docker-quick@centos7 passed

Test docker-clang@ubuntu passed

Test FreeBSD passed

Test asan passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20190926021055.6970-1-tao3.xu@intel.com

Maintainers: Eduardo Habkost <ehabkost@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, Richard Henderson <rth@twiddle.net>

target/i386/cpu.c           |   8 +-
target/i386/cpu.h           | 163 +++++++++++++++++++++++-------------
target/i386/hvf/x86_cpuid.c |   2 +-
3 files changed, 111 insertions(+), 62 deletions(-)

Expand all Fold all

[PATCH v5 0/2] target/i386: cpu.h macros clean up

Posted by Tao Xu 4 years, 7 months ago

Add some comments, clean up comments over 80 chars per line. There
is an extra line in comment of CPUID_8000_0008_EBX_WBNOINVD, remove
the extra enter and spaces.

Drop the duplicated definition of cpuid AVX512_VBMI macro and rename it
as CPUID_7_0_ECX_AVX512_VBMI. Rename CPUID_7_0_ECX_VBMI2
as CPUID_7_0_ECX_AVX512_VBMI2.

Changelog:
v5:
    - correct commit messages. (Suggested by Stefano Garzarella)
v4:
    - rename CPUID_7_0_ECX_VBMI2 as CPUID_7_0_ECX_AVX512_VBMI2.
      (Suggested by Stefano Garzarella)
v3:
    - split the patch into 2 patches. (Suggested by Stefano Garzarella
      and Eduardo Habkost)
v2:
    - correct the comments over 80 chars per line. (Suggested by
      Philippe Mathieu-Daudé)

Tao Xu (2):
  target/i386: clean up comments over 80 chars per line
  target/i386: drop the duplicated definition of cpuid AVX512_VBMI macro

 target/i386/cpu.c           |   8 +-
 target/i386/cpu.h           | 163 +++++++++++++++++++++++-------------
 target/i386/hvf/x86_cpuid.c |   2 +-
 3 files changed, 111 insertions(+), 62 deletions(-)

-- 
2.20.1

Re: [PATCH v5 0/2] target/i386: cpu.h macros clean up

Posted by Eduardo Habkost 4 years, 7 months ago

On Thu, Sep 26, 2019 at 10:10:53AM +0800, Tao Xu wrote:
> Add some comments, clean up comments over 80 chars per line. There
> is an extra line in comment of CPUID_8000_0008_EBX_WBNOINVD, remove
> the extra enter and spaces.
> 
> Drop the duplicated definition of cpuid AVX512_VBMI macro and rename it
> as CPUID_7_0_ECX_AVX512_VBMI. Rename CPUID_7_0_ECX_VBMI2
> as CPUID_7_0_ECX_AVX512_VBMI2.
> 

Queued, thanks!

> Changelog:
> v5:
>     - correct commit messages. (Suggested by Stefano Garzarella)
> v4:
>     - rename CPUID_7_0_ECX_VBMI2 as CPUID_7_0_ECX_AVX512_VBMI2.
>       (Suggested by Stefano Garzarella)
> v3:
>     - split the patch into 2 patches. (Suggested by Stefano Garzarella
>       and Eduardo Habkost)
> v2:
>     - correct the comments over 80 chars per line. (Suggested by
>       Philippe Mathieu-Daudé)
> 
> Tao Xu (2):
>   target/i386: clean up comments over 80 chars per line
>   target/i386: drop the duplicated definition of cpuid AVX512_VBMI macro
> 
>  target/i386/cpu.c           |   8 +-
>  target/i386/cpu.h           | 163 +++++++++++++++++++++++-------------
>  target/i386/hvf/x86_cpuid.c |   2 +-
>  3 files changed, 111 insertions(+), 62 deletions(-)
> 
> -- 
> 2.20.1
> 

-- 
Eduardo