[v1] qemu-options.hx: remove stray quote

[PATCH] qemu-options.hx: remove stray quote

John Snow posted 1 patch 4 years, 6 months ago

Diff against v2
Download mbox

Test docker-mingw@fedora passed

Test checkpatch passed

Test docker-quick@centos7 passed

Test asan passed

Test docker-clang@ubuntu passed

Test FreeBSD passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20190924231325.25444-1-jsnow@redhat.com

There is a newer version of this series

qemu-options.hx | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Expand all Fold all

[PATCH] qemu-options.hx: remove stray quote

Posted by John Snow 4 years, 6 months ago

Signed-off-by: John Snow <jsnow@redhat.com>
---
 qemu-options.hx | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/qemu-options.hx b/qemu-options.hx
index 2a04ca6ac5..629a7b1186 100644
--- a/qemu-options.hx
+++ b/qemu-options.hx
@@ -1192,7 +1192,7 @@ Instead of @option{-fda}, @option{-fdb}, you can use:
 By default, @var{interface} is "ide" and @var{index} is automatically
 incremented:
 @example
-@value{qemu_system_x86} -drive file=a -drive file=b"
+@value{qemu_system_x86} -drive file=a -drive file=b
 @end example
 is interpreted like:
 @example
-- 
2.21.0

Re: [PATCH] qemu-options.hx: remove stray quote

Posted by Markus Armbruster 4 years, 6 months ago

John Snow <jsnow@redhat.com> writes:

> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
>  qemu-options.hx | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/qemu-options.hx b/qemu-options.hx
> index 2a04ca6ac5..629a7b1186 100644
> --- a/qemu-options.hx
> +++ b/qemu-options.hx
> @@ -1192,7 +1192,7 @@ Instead of @option{-fda}, @option{-fdb}, you can use:
>  By default, @var{interface} is "ide" and @var{index} is automatically
>  incremented:
>  @example
> -@value{qemu_system_x86} -drive file=a -drive file=b"
> +@value{qemu_system_x86} -drive file=a -drive file=b
>  @end example
>  is interpreted like:
>  @example

Messed up more than ten years ago, in commit e0e7ada1d55, faithfully
copied around ever since.  Makes me wonder how much this part of
qemu-doc is actually read.

Reviewed-by: Markus Armbruster <armbru@redhat.com>

Re: [PATCH] qemu-options.hx: remove stray quote

Posted by John Snow 4 years, 2 months ago


On 9/25/19 1:43 AM, Markus Armbruster wrote:
> John Snow <jsnow@redhat.com> writes:
> 
>> Signed-off-by: John Snow <jsnow@redhat.com>
>> ---
>>  qemu-options.hx | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/qemu-options.hx b/qemu-options.hx
>> index 2a04ca6ac5..629a7b1186 100644
>> --- a/qemu-options.hx
>> +++ b/qemu-options.hx
>> @@ -1192,7 +1192,7 @@ Instead of @option{-fda}, @option{-fdb}, you can use:
>>  By default, @var{interface} is "ide" and @var{index} is automatically
>>  incremented:
>>  @example
>> -@value{qemu_system_x86} -drive file=a -drive file=b"
>> +@value{qemu_system_x86} -drive file=a -drive file=b
>>  @end example
>>  is interpreted like:
>>  @example
> 
> Messed up more than ten years ago, in commit e0e7ada1d55, faithfully
> copied around ever since.  Makes me wonder how much this part of
> qemu-doc is actually read.
> 
> Reviewed-by: Markus Armbruster <armbru@redhat.com>
> 

Not worth the calories to merge it into a trivial roundup, either. Maybe
the error can get copied into the ReST version, too.

--js