[PULL 00/30] s390x/tcg update

David Hildenbrand posted 30 patches 4 years, 6 months ago
Test FreeBSD passed
Test docker-mingw@fedora passed
Test checkpatch failed
Test docker-clang@ubuntu passed
Test docker-quick@centos7 passed
Test asan passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20190923080712.23951-1-david@redhat.com
Maintainers: Cornelia Huck <cohuck@redhat.com>, Richard Henderson <rth@twiddle.net>, David Hildenbrand <david@redhat.com>
target/s390x/cpu.h              |   4 +
target/s390x/helper.h           |   2 +-
target/s390x/insn-data.def      |   2 +-
target/s390x/mem_helper.c       | 749 ++++++++++++++++++++++----------
target/s390x/translate.c        |  12 +-
tests/tcg/s390x/Makefile.target |   2 +
tests/tcg/s390x/mvc.c           | 109 +++++
tests/tcg/s390x/mvo.c           |  25 ++
8 files changed, 680 insertions(+), 225 deletions(-)
create mode 100644 tests/tcg/s390x/mvc.c
create mode 100644 tests/tcg/s390x/mvo.c
[PULL 00/30] s390x/tcg update
Posted by David Hildenbrand 4 years, 6 months ago
Hi Peter,

here is the updated tcg subset of the s390x update (including one more
test).

The following changes since commit 4300b7c2cd9f3f273804e8cca325842ccb93b1ad:

  Merge remote-tracking branch 'remotes/cleber/tags/python-next-pull-request' into staging (2019-09-20 17:28:43 +0100)

are available in the Git repository at:

  https://github.com/davidhildenbrand/qemu.git tags/s390x-tcg-2019-09-23

for you to fetch changes up to 5d69cbdfdd5cd6dadc9f0c986899844a0e4de703:

  tests/tcg: target/s390x: Test MVC (2019-09-23 09:28:29 +0200)

----------------------------------------------------------------
Fix a bunch of BUGs in the mem-helpers (including the MVC instruction),
especially, to make them behave correctly on faults.

----------------------------------------------------------------
David Hildenbrand (30):
  s390x/tcg: Reset exception_index to -1 instead of 0
  s390x/tcg: MVCL: Zero out unused bits of address
  s390x/tcg: MVCL: Detect destructive overlaps
  s390x/tcg: MVCL: Process max 4k bytes at a time
  s390x/tcg: MVC: Increment the length once
  s390x/tcg: MVC: Use is_destructive_overlap()
  s390x/tcg: MVPG: Check for specification exceptions
  s390x/tcg: MVPG: Properly wrap the addresses
  s390x/tcg: MVCLU/MVCLE: Process max 4k bytes at a time
  s390x/tcg: MVCS/MVCP: Check for special operation exceptions
  s390x/tcg: MVCOS: Lengths are 32 bit in 24/31-bit mode
  s390x/tcg: MVCS/MVCP: Properly wrap the length
  s390x/tcg: MVST: Check for specification exceptions
  s390x/tcg: MVST: Fix storing back the addresses to registers
  s390x/tcg: Always use MMU_USER_IDX for CONFIG_USER_ONLY
  s390x/tcg: Fault-safe memset
  s390x/tcg: Fault-safe memmove
  s390x/tcg: MVCS/MVCP: Use access_memmove()
  s390x/tcg: MVC: Fault-safe handling on destructive overlaps
  s390x/tcg: MVCLU: Fault-safe handling
  s390x/tcg: OC: Fault-safe handling
  s390x/tcg: XC: Fault-safe handling
  s390x/tcg: NC: Fault-safe handling
  s390x/tcg: MVCIN: Fault-safe handling
  s390x/tcg: MVN: Fault-safe handling
  s390x/tcg: MVZ: Fault-safe handling
  s390x/tcg: MVST: Fault-safe handling
  s390x/tcg: MVO: Fault-safe handling
  tests/tcg: target/s390x: Test MVO
  tests/tcg: target/s390x: Test MVC

 target/s390x/cpu.h              |   4 +
 target/s390x/helper.h           |   2 +-
 target/s390x/insn-data.def      |   2 +-
 target/s390x/mem_helper.c       | 749 ++++++++++++++++++++++----------
 target/s390x/translate.c        |  12 +-
 tests/tcg/s390x/Makefile.target |   2 +
 tests/tcg/s390x/mvc.c           | 109 +++++
 tests/tcg/s390x/mvo.c           |  25 ++
 8 files changed, 680 insertions(+), 225 deletions(-)
 create mode 100644 tests/tcg/s390x/mvc.c
 create mode 100644 tests/tcg/s390x/mvo.c

-- 
2.21.0


Re: [PULL 00/30] s390x/tcg update
Posted by no-reply@patchew.org 4 years, 6 months ago
Patchew URL: https://patchew.org/QEMU/20190923080712.23951-1-david@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: 20190923080712.23951-1-david@redhat.com
Subject: [PULL 00/30] s390x/tcg update
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

From https://github.com/patchew-project/qemu
 * [new tag]         patchew/20190923080712.23951-1-david@redhat.com -> patchew/20190923080712.23951-1-david@redhat.com
Switched to a new branch 'test'
2cc4ca7 tests/tcg: target/s390x: Test MVC
e9e71c5 tests/tcg: target/s390x: Test MVO
96ecdc7 s390x/tcg: MVO: Fault-safe handling
90370c5 s390x/tcg: MVST: Fault-safe handling
0d7a739 s390x/tcg: MVZ: Fault-safe handling
69e0b44 s390x/tcg: MVN: Fault-safe handling
752f7d7 s390x/tcg: MVCIN: Fault-safe handling
d13fb76 s390x/tcg: NC: Fault-safe handling
35f5eac s390x/tcg: XC: Fault-safe handling
9e18c09 s390x/tcg: OC: Fault-safe handling
c00d7eb s390x/tcg: MVCLU: Fault-safe handling
c4d0f6f s390x/tcg: MVC: Fault-safe handling on destructive overlaps
a237750 s390x/tcg: MVCS/MVCP: Use access_memmove()
1a52654 s390x/tcg: Fault-safe memmove
23a79fe s390x/tcg: Fault-safe memset
0cf4557 s390x/tcg: Always use MMU_USER_IDX for CONFIG_USER_ONLY
b49d8da s390x/tcg: MVST: Fix storing back the addresses to registers
0ffe998 s390x/tcg: MVST: Check for specification exceptions
fa839d7 s390x/tcg: MVCS/MVCP: Properly wrap the length
064b0d8 s390x/tcg: MVCOS: Lengths are 32 bit in 24/31-bit mode
9f7778f s390x/tcg: MVCS/MVCP: Check for special operation exceptions
e39e5aa s390x/tcg: MVCLU/MVCLE: Process max 4k bytes at a time
a46823b s390x/tcg: MVPG: Properly wrap the addresses
b666147 s390x/tcg: MVPG: Check for specification exceptions
bb38f52 s390x/tcg: MVC: Use is_destructive_overlap()
2ec6eb1 s390x/tcg: MVC: Increment the length once
0240a92 s390x/tcg: MVCL: Process max 4k bytes at a time
ae46582 s390x/tcg: MVCL: Detect destructive overlaps
1f4217f s390x/tcg: MVCL: Zero out unused bits of address
145e04f s390x/tcg: Reset exception_index to -1 instead of 0

=== OUTPUT BEGIN ===
1/30 Checking commit 145e04fd5b46 (s390x/tcg: Reset exception_index to -1 instead of 0)
2/30 Checking commit 1f4217fe98bf (s390x/tcg: MVCL: Zero out unused bits of address)
3/30 Checking commit ae46582ae9fc (s390x/tcg: MVCL: Detect destructive overlaps)
4/30 Checking commit 0240a922a5d3 (s390x/tcg: MVCL: Process max 4k bytes at a time)
5/30 Checking commit 2ec6eb1f4616 (s390x/tcg: MVC: Increment the length once)
6/30 Checking commit bb38f5238f20 (s390x/tcg: MVC: Use is_destructive_overlap())
7/30 Checking commit b66614710291 (s390x/tcg: MVPG: Check for specification exceptions)
8/30 Checking commit a46823ba5527 (s390x/tcg: MVPG: Properly wrap the addresses)
9/30 Checking commit e39e5aa1fb29 (s390x/tcg: MVCLU/MVCLE: Process max 4k bytes at a time)
10/30 Checking commit 9f7778fd0154 (s390x/tcg: MVCS/MVCP: Check for special operation exceptions)
11/30 Checking commit 064b0d8840dc (s390x/tcg: MVCOS: Lengths are 32 bit in 24/31-bit mode)
12/30 Checking commit fa839d764a74 (s390x/tcg: MVCS/MVCP: Properly wrap the length)
13/30 Checking commit 0ffe9989a152 (s390x/tcg: MVST: Check for specification exceptions)
14/30 Checking commit b49d8da94774 (s390x/tcg: MVST: Fix storing back the addresses to registers)
15/30 Checking commit 0cf4557440b3 (s390x/tcg: Always use MMU_USER_IDX for CONFIG_USER_ONLY)
16/30 Checking commit 23a79fe382e8 (s390x/tcg: Fault-safe memset)
17/30 Checking commit 1a52654156d7 (s390x/tcg: Fault-safe memmove)
18/30 Checking commit a237750a2aa5 (s390x/tcg: MVCS/MVCP: Use access_memmove())
19/30 Checking commit c4d0f6fa363c (s390x/tcg: MVC: Fault-safe handling on destructive overlaps)
20/30 Checking commit c00d7ebea2e0 (s390x/tcg: MVCLU: Fault-safe handling)
21/30 Checking commit 9e18c0998a89 (s390x/tcg: OC: Fault-safe handling)
22/30 Checking commit 35f5eacbeb12 (s390x/tcg: XC: Fault-safe handling)
23/30 Checking commit d13fb76627a8 (s390x/tcg: NC: Fault-safe handling)
24/30 Checking commit 752f7d75ad3d (s390x/tcg: MVCIN: Fault-safe handling)
25/30 Checking commit 69e0b44feb4d (s390x/tcg: MVN: Fault-safe handling)
26/30 Checking commit 0d7a739637de (s390x/tcg: MVZ: Fault-safe handling)
27/30 Checking commit 90370c5f7e92 (s390x/tcg: MVST: Fault-safe handling)
28/30 Checking commit 96ecdc71a9a1 (s390x/tcg: MVO: Fault-safe handling)
29/30 Checking commit e9e71c5682ab (tests/tcg: target/s390x: Test MVO)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#24: 
new file mode 100644

total: 0 errors, 1 warnings, 29 lines checked

Patch 29/30 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
30/30 Checking commit 2cc4ca7e8d71 (tests/tcg: target/s390x: Test MVC)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#30: 
new file mode 100644

ERROR: use sigaction to establish signal handlers; signal is not portable
#68: FILE: tests/tcg/s390x/mvc.c:34:
+    if (signal(SIGSEGV, handle_sigsegv) == SIG_ERR) {

total: 1 errors, 1 warnings, 113 lines checked

Patch 30/30 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20190923080712.23951-1-david@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
Re: [PULL 00/30] s390x/tcg update
Posted by no-reply@patchew.org 4 years, 6 months ago
Patchew URL: https://patchew.org/QEMU/20190923080712.23951-1-david@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: 20190923080712.23951-1-david@redhat.com
Subject: [PULL 00/30] s390x/tcg update
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

From https://github.com/patchew-project/qemu
 - [tag update]      patchew/20190923080712.23951-1-david@redhat.com -> patchew/20190923080712.23951-1-david@redhat.com
Switched to a new branch 'test'
8444594 tests/tcg: target/s390x: Test MVC
ee2ed6d tests/tcg: target/s390x: Test MVO
7b0e80e s390x/tcg: MVO: Fault-safe handling
9790bed s390x/tcg: MVST: Fault-safe handling
12658d2 s390x/tcg: MVZ: Fault-safe handling
371cae1 s390x/tcg: MVN: Fault-safe handling
87a7cbd s390x/tcg: MVCIN: Fault-safe handling
200a39a s390x/tcg: NC: Fault-safe handling
08ce1db s390x/tcg: XC: Fault-safe handling
ef2eb0b s390x/tcg: OC: Fault-safe handling
1a01d78 s390x/tcg: MVCLU: Fault-safe handling
25baafe s390x/tcg: MVC: Fault-safe handling on destructive overlaps
8848832 s390x/tcg: MVCS/MVCP: Use access_memmove()
fae34f8 s390x/tcg: Fault-safe memmove
4bb7e2d s390x/tcg: Fault-safe memset
d965ec2 s390x/tcg: Always use MMU_USER_IDX for CONFIG_USER_ONLY
5a5dcf2 s390x/tcg: MVST: Fix storing back the addresses to registers
57c4578 s390x/tcg: MVST: Check for specification exceptions
b45d82e s390x/tcg: MVCS/MVCP: Properly wrap the length
96a5992 s390x/tcg: MVCOS: Lengths are 32 bit in 24/31-bit mode
97a8db7 s390x/tcg: MVCS/MVCP: Check for special operation exceptions
ba37bf0 s390x/tcg: MVCLU/MVCLE: Process max 4k bytes at a time
f2d36b3 s390x/tcg: MVPG: Properly wrap the addresses
2b5d295 s390x/tcg: MVPG: Check for specification exceptions
e8cc891 s390x/tcg: MVC: Use is_destructive_overlap()
afc7b33 s390x/tcg: MVC: Increment the length once
9720059 s390x/tcg: MVCL: Process max 4k bytes at a time
6f05a52 s390x/tcg: MVCL: Detect destructive overlaps
cdeec53 s390x/tcg: MVCL: Zero out unused bits of address
c4938ed s390x/tcg: Reset exception_index to -1 instead of 0

=== OUTPUT BEGIN ===
1/30 Checking commit c4938edb13bc (s390x/tcg: Reset exception_index to -1 instead of 0)
2/30 Checking commit cdeec532ad35 (s390x/tcg: MVCL: Zero out unused bits of address)
3/30 Checking commit 6f05a524b299 (s390x/tcg: MVCL: Detect destructive overlaps)
4/30 Checking commit 97200592f682 (s390x/tcg: MVCL: Process max 4k bytes at a time)
5/30 Checking commit afc7b33a5e55 (s390x/tcg: MVC: Increment the length once)
6/30 Checking commit e8cc891074c3 (s390x/tcg: MVC: Use is_destructive_overlap())
7/30 Checking commit 2b5d29504cd0 (s390x/tcg: MVPG: Check for specification exceptions)
8/30 Checking commit f2d36b3cc65e (s390x/tcg: MVPG: Properly wrap the addresses)
9/30 Checking commit ba37bf02af24 (s390x/tcg: MVCLU/MVCLE: Process max 4k bytes at a time)
10/30 Checking commit 97a8db757a04 (s390x/tcg: MVCS/MVCP: Check for special operation exceptions)
11/30 Checking commit 96a599293f36 (s390x/tcg: MVCOS: Lengths are 32 bit in 24/31-bit mode)
12/30 Checking commit b45d82e2df86 (s390x/tcg: MVCS/MVCP: Properly wrap the length)
13/30 Checking commit 57c45783106b (s390x/tcg: MVST: Check for specification exceptions)
14/30 Checking commit 5a5dcf274a03 (s390x/tcg: MVST: Fix storing back the addresses to registers)
15/30 Checking commit d965ec28dd7c (s390x/tcg: Always use MMU_USER_IDX for CONFIG_USER_ONLY)
16/30 Checking commit 4bb7e2d79eb8 (s390x/tcg: Fault-safe memset)
17/30 Checking commit fae34f841740 (s390x/tcg: Fault-safe memmove)
18/30 Checking commit 88488321fd07 (s390x/tcg: MVCS/MVCP: Use access_memmove())
19/30 Checking commit 25baafe3dc44 (s390x/tcg: MVC: Fault-safe handling on destructive overlaps)
20/30 Checking commit 1a01d784e526 (s390x/tcg: MVCLU: Fault-safe handling)
21/30 Checking commit ef2eb0b81437 (s390x/tcg: OC: Fault-safe handling)
22/30 Checking commit 08ce1db165f6 (s390x/tcg: XC: Fault-safe handling)
23/30 Checking commit 200a39a6646c (s390x/tcg: NC: Fault-safe handling)
24/30 Checking commit 87a7cbd6ecb8 (s390x/tcg: MVCIN: Fault-safe handling)
25/30 Checking commit 371cae1d272f (s390x/tcg: MVN: Fault-safe handling)
26/30 Checking commit 12658d24f74c (s390x/tcg: MVZ: Fault-safe handling)
27/30 Checking commit 9790bedceafa (s390x/tcg: MVST: Fault-safe handling)
28/30 Checking commit 7b0e80e77ad1 (s390x/tcg: MVO: Fault-safe handling)
29/30 Checking commit ee2ed6d1c8e1 (tests/tcg: target/s390x: Test MVO)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#24: 
new file mode 100644

total: 0 errors, 1 warnings, 29 lines checked

Patch 29/30 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
30/30 Checking commit 8444594d1eba (tests/tcg: target/s390x: Test MVC)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#30: 
new file mode 100644

ERROR: use sigaction to establish signal handlers; signal is not portable
#68: FILE: tests/tcg/s390x/mvc.c:34:
+    if (signal(SIGSEGV, handle_sigsegv) == SIG_ERR) {

total: 1 errors, 1 warnings, 113 lines checked

Patch 30/30 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20190923080712.23951-1-david@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
Re: [PULL 00/30] s390x/tcg update
Posted by Peter Maydell 4 years, 6 months ago
On Mon, 23 Sep 2019 at 09:07, David Hildenbrand <david@redhat.com> wrote:
>
> Hi Peter,
>
> here is the updated tcg subset of the s390x update (including one more
> test).
>
> The following changes since commit 4300b7c2cd9f3f273804e8cca325842ccb93b1ad:
>
>   Merge remote-tracking branch 'remotes/cleber/tags/python-next-pull-request' into staging (2019-09-20 17:28:43 +0100)
>
> are available in the Git repository at:
>
>   https://github.com/davidhildenbrand/qemu.git tags/s390x-tcg-2019-09-23
>
> for you to fetch changes up to 5d69cbdfdd5cd6dadc9f0c986899844a0e4de703:
>
>   tests/tcg: target/s390x: Test MVC (2019-09-23 09:28:29 +0200)
>
> ----------------------------------------------------------------
> Fix a bunch of BUGs in the mem-helpers (including the MVC instruction),
> especially, to make them behave correctly on faults.
>


Applied, thanks.

Please update the changelog at https://wiki.qemu.org/ChangeLog/4.2
for any user-visible changes.

-- PMM