roms: Add a 'make help' target alias

[PATCH] roms: Add a 'make help' target alias

Posted by Philippe Mathieu-Daudé 4 years, 7 months ago

Various C projects provide a 'make help' target. Our root directory
does so. The roms/ directory lacks a such rule, but already displays
a help output when the default target is called.
Add a 'help' target aliased to the default one, to avoid:

  $ make -C roms help
  make: *** No rule to make target 'help'.  Stop.

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
 roms/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/roms/Makefile b/roms/Makefile
index 6cf07d3b44..3ffd13cc7e 100644
--- a/roms/Makefile
+++ b/roms/Makefile
@@ -51,7 +51,7 @@ SEABIOS_EXTRAVERSION="-prebuilt.qemu.org"
 #
 EDK2_EFIROM = edk2/BaseTools/Source/C/bin/EfiRom
 
-default:
+default help:
 	@echo "nothing is build by default"
 	@echo "available build targets:"
 	@echo "  bios               -- update bios.bin (seabios)"
-- 
2.20.1

Re: [PATCH] roms: Add a 'make help' target alias

Posted by Peter Maydell 4 years, 7 months ago

On Fri, 20 Sep 2019 at 18:12, Philippe Mathieu-Daudé <philmd@redhat.com> wrote:
>
> Various C projects provide a 'make help' target. Our root directory
> does so. The roms/ directory lacks a such rule, but already displays
> a help output when the default target is called.
> Add a 'help' target aliased to the default one, to avoid:
>
>   $ make -C roms help
>   make: *** No rule to make target 'help'.  Stop.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
>  roms/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/roms/Makefile b/roms/Makefile
> index 6cf07d3b44..3ffd13cc7e 100644
> --- a/roms/Makefile
> +++ b/roms/Makefile
> @@ -51,7 +51,7 @@ SEABIOS_EXTRAVERSION="-prebuilt.qemu.org"
>  #
>  EDK2_EFIROM = edk2/BaseTools/Source/C/bin/EfiRom
>
> -default:
> +default help:
>         @echo "nothing is build by default"

If you felt like fixing a typo, there's one here: should
be "is built"...

>         @echo "available build targets:"
>         @echo "  bios               -- update bios.bin (seabios)"
> --
> 2.20.1

thanks
-- PMM

Re: [PATCH] roms: Add a 'make help' target alias

Posted by John Snow 4 years, 7 months ago


On 9/20/19 1:11 PM, Philippe Mathieu-Daudé wrote:
> Various C projects provide a 'make help' target. Our root directory
> does so. The roms/ directory lacks a such rule, but already displays
> a help output when the default target is called.
> Add a 'help' target aliased to the default one, to avoid:
> 
>   $ make -C roms help
>   make: *** No rule to make target 'help'.  Stop.
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
>  roms/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/roms/Makefile b/roms/Makefile
> index 6cf07d3b44..3ffd13cc7e 100644
> --- a/roms/Makefile
> +++ b/roms/Makefile
> @@ -51,7 +51,7 @@ SEABIOS_EXTRAVERSION="-prebuilt.qemu.org"
>  #
>  EDK2_EFIROM = edk2/BaseTools/Source/C/bin/EfiRom
>  
> -default:
> +default help:
>  	@echo "nothing is build by default"
>  	@echo "available build targets:"
>  	@echo "  bios               -- update bios.bin (seabios)"
> 

Reviewed-by: John Snow <jsnow@redhat.com>

The typo can be fixed with a trivial patch or squashed into this fix,
the purity of such things doesn't matter to me.

--js

Re: [PATCH] roms: Add a 'make help' target alias

Posted by Laszlo Ersek 4 years, 7 months ago

On 09/20/19 19:11, Philippe Mathieu-Daudé wrote:
> Various C projects provide a 'make help' target. Our root directory
> does so. The roms/ directory lacks a such rule, but already displays
> a help output when the default target is called.
> Add a 'help' target aliased to the default one, to avoid:
> 
>   $ make -C roms help
>   make: *** No rule to make target 'help'.  Stop.
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
>  roms/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/roms/Makefile b/roms/Makefile
> index 6cf07d3b44..3ffd13cc7e 100644
> --- a/roms/Makefile
> +++ b/roms/Makefile
> @@ -51,7 +51,7 @@ SEABIOS_EXTRAVERSION="-prebuilt.qemu.org"
>  #
>  EDK2_EFIROM = edk2/BaseTools/Source/C/bin/EfiRom
>  
> -default:
> +default help:
>  	@echo "nothing is build by default"
>  	@echo "available build targets:"
>  	@echo "  bios               -- update bios.bin (seabios)"
> 

How about we just print: "help yourself"?

Just kidding. :P

Reviewed-by: Laszlo Ersek <lersek@redhat.com>

Thanks!
Laszlo