Audio 20190919 patches

[Qemu-devel] [PULL 00/26] Audio 20190919 patches

Posted by Gerd Hoffmann 4 years, 7 months ago

The following changes since commit f8c3db33a5e863291182f8862ddf81618a7c6194:

  target/sparc: Switch to do_transaction_failed() hook (2019-09-17 12:01:00 +0100)

are available in the Git repository at:

  git://git.kraxel.org/qemu tags/audio-20190919-pull-request

for you to fetch changes up to cf0c1c2aa32db5d658c3c797ad995a6d571bad96:

  audio: fix ALSA period-length typo in documentation (2019-09-19 10:32:48 +0200)

----------------------------------------------------------------
audio: make mixeng optional.
audio: add surround sound support.
audio: documentation fixes.

----------------------------------------------------------------

Kővágó, Zoltán (24):
  audio: api for mixeng code free backends
  alsaaudio: port to the new audio backend api
  coreaudio: port to the new audio backend api
  dsoundaudio: port to the new audio backend api
  noaudio: port to the new audio backend api
  ossaudio: port to the new audio backend api
  paaudio: port to the new audio backend api
  sdlaudio: port to the new audio backend api
  spiceaudio: port to the new audio backend api
  wavaudio: port to the new audio backend api
  audio: remove remains of the old backend api
  audio: unify input and output mixeng buffer management
  audio: common rate control code for timer based outputs
  audio: split ctl_* functions into enable_* and volume_*
  audio: add mixeng option (documentation)
  audio: make mixeng optional
  paaudio: get/put_buffer functions
  audio: support more than two channels in volume setting
  audio: replace shift in audio_pcm_info with bytes_per_frame
  audio: basic support for multichannel audio
  paaudio: channel-map option
  usb-audio: do not count on avail bytes actually available
  usb-audio: support more than two channels of audio
  usbaudio: change playback counters to 64 bit

Stefan Hajnoczi (2):
  audio: fix buffer-length typo in documentation
  audio: fix ALSA period-length typo in documentation

 configure               |   5 -
 audio/audio.h           |  10 +
 audio/audio_int.h       |  79 ++++--
 audio/audio_pt_int.h    |  22 --
 audio/audio_template.h  |  31 ++-
 audio/dsound_template.h |  53 ++--
 audio/alsaaudio.c       | 378 ++++++++-------------------
 audio/audio.c           | 527 +++++++++++++++++++++++++++++---------
 audio/audio_pt_int.c    | 173 -------------
 audio/coreaudio.c       | 143 ++++++-----
 audio/dsoundaudio.c     | 383 ++++++++-------------------
 audio/noaudio.c         |  76 +++---
 audio/ossaudio.c        | 376 ++++++++++-----------------
 audio/paaudio.c         | 554 +++++++++++++---------------------------
 audio/sdlaudio.c        | 104 ++++----
 audio/spiceaudio.c      | 260 +++++++------------
 audio/wavaudio.c        |  78 ++----
 hw/usb/dev-audio.c      | 461 ++++++++++++++++++++++++++++-----
 audio/Makefile.objs     |   1 -
 qapi/audio.json         |  12 +-
 qemu-options.hx         |  23 +-
 21 files changed, 1719 insertions(+), 2030 deletions(-)
 delete mode 100644 audio/audio_pt_int.h
 delete mode 100644 audio/audio_pt_int.c

-- 
2.18.1

Re: [Qemu-devel] [PULL 00/26] Audio 20190919 patches

Posted by Peter Maydell 4 years, 7 months ago

On Thu, 19 Sep 2019 at 09:38, Gerd Hoffmann <kraxel@redhat.com> wrote:
>
> The following changes since commit f8c3db33a5e863291182f8862ddf81618a7c6194:
>
>   target/sparc: Switch to do_transaction_failed() hook (2019-09-17 12:01:00 +0100)
>
> are available in the Git repository at:
>
>   git://git.kraxel.org/qemu tags/audio-20190919-pull-request
>
> for you to fetch changes up to cf0c1c2aa32db5d658c3c797ad995a6d571bad96:
>
>   audio: fix ALSA period-length typo in documentation (2019-09-19 10:32:48 +0200)
>
> ----------------------------------------------------------------
> audio: make mixeng optional.
> audio: add surround sound support.
> audio: documentation fixes.
>

Hi; I'm afraid this fails to build on OSX/FreeBSD/OpenBSD/Windows,
with format string issues:

/Users/pm215/src/qemu-for-merges/audio/wavaudio.c:50:15: error: format
specifies type 'size_t' (aka 'unsigned long') but the argument has
type 'int64_t' (aka 'long long') [-Werror,-Wformat]
              bytes, strerror(errno));
              ^~~~~
/Users/pm215/src/qemu-for-merges/audio/audio_int.h:257:52: note:
expanded from macro 'dolog'
#define dolog(fmt, ...) AUD_log(AUDIO_CAP, fmt, ## __VA_ARGS__)
                                                   ^~~~~~~~~~~


thanks
-- PMM

Re: [Qemu-devel] [PULL 00/26] Audio 20190919 patches

Posted by Eric Blake 4 years, 7 months ago

On 9/19/19 10:15 AM, Peter Maydell wrote:
> On Thu, 19 Sep 2019 at 09:38, Gerd Hoffmann <kraxel@redhat.com> wrote:
>>
>> The following changes since commit f8c3db33a5e863291182f8862ddf81618a7c6194:
>>
>>   target/sparc: Switch to do_transaction_failed() hook (2019-09-17 12:01:00 +0100)
>>
>> are available in the Git repository at:
>>
>>   git://git.kraxel.org/qemu tags/audio-20190919-pull-request
>>
>> for you to fetch changes up to cf0c1c2aa32db5d658c3c797ad995a6d571bad96:
>>
>>   audio: fix ALSA period-length typo in documentation (2019-09-19 10:32:48 +0200)
>>
>> ----------------------------------------------------------------
>> audio: make mixeng optional.
>> audio: add surround sound support.
>> audio: documentation fixes.
>>
> 
> Hi; I'm afraid this fails to build on OSX/FreeBSD/OpenBSD/Windows,
> with format string issues:
> 
> /Users/pm215/src/qemu-for-merges/audio/wavaudio.c:50:15: error: format
> specifies type 'size_t' (aka 'unsigned long') but the argument has
> type 'int64_t' (aka 'long long') [-Werror,-Wformat]
>               bytes, strerror(errno));
>               ^~~~~

As long as you spin a v2, it's also worth fixing a typo I found in 15/26.

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org

Re: [Qemu-devel] [PULL 00/26] Audio 20190919 patches

Posted by Zoltán Kővágó 4 years, 7 months ago

On 2019-09-19 17:28, Eric Blake wrote:
> On 9/19/19 10:15 AM, Peter Maydell wrote:
>> On Thu, 19 Sep 2019 at 09:38, Gerd Hoffmann <kraxel@redhat.com> wrote:
>>>
>>> The following changes since commit f8c3db33a5e863291182f8862ddf81618a7c6194:
>>>
>>>    target/sparc: Switch to do_transaction_failed() hook (2019-09-17 12:01:00 +0100)
>>>
>>> are available in the Git repository at:
>>>
>>>    git://git.kraxel.org/qemu tags/audio-20190919-pull-request
>>>
>>> for you to fetch changes up to cf0c1c2aa32db5d658c3c797ad995a6d571bad96:
>>>
>>>    audio: fix ALSA period-length typo in documentation (2019-09-19 10:32:48 +0200)
>>>
>>> ----------------------------------------------------------------
>>> audio: make mixeng optional.
>>> audio: add surround sound support.
>>> audio: documentation fixes.
>>>
>>
>> Hi; I'm afraid this fails to build on OSX/FreeBSD/OpenBSD/Windows,
>> with format string issues:
>>
>> /Users/pm215/src/qemu-for-merges/audio/wavaudio.c:50:15: error: format
>> specifies type 'size_t' (aka 'unsigned long') but the argument has
>> type 'int64_t' (aka 'long long') [-Werror,-Wformat]
>>                bytes, strerror(errno));
>>                ^~~~~
> 
> As long as you spin a v2, it's also worth fixing a typo I found in 15/26.
> 

Thanks, fixed in v4, along with the compilation problem.