[Qemu-devel] [PULL 0/4] Ui 20190919 patches

Gerd Hoffmann posted 4 patches 4 years, 7 months ago
Test asan failed
Test FreeBSD passed
Test docker-mingw@fedora passed
Test docker-clang@ubuntu passed
Test checkpatch failed
Test docker-quick@centos7 passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20190919070918.16059-1-kraxel@redhat.com
Maintainers: Gerd Hoffmann <kraxel@redhat.com>
docs/barrier.txt         | 370 +++++++++++++++++++
include/ui/egl-helpers.h |   2 +-
ui/input-barrier.h       | 112 ++++++
ui/vnc.h                 |   4 +-
ui/egl-headless.c        |   4 +-
ui/egl-helpers.c         |   6 +-
ui/input-barrier.c       | 750 +++++++++++++++++++++++++++++++++++++++
ui/vnc-enc-tight.c       | 219 ++++++------
ui/vnc-enc-zlib.c        |  11 +-
ui/vnc-enc-zrle.c        |  68 ++--
ui/vnc-enc-zrle.inc.c    |   2 +-
ui/vnc.c                 |  29 +-
ui/Makefile.objs         |   1 +
13 files changed, 1409 insertions(+), 169 deletions(-)
create mode 100644 docs/barrier.txt
create mode 100644 ui/input-barrier.h
create mode 100644 ui/input-barrier.c
[Qemu-devel] [PULL 0/4] Ui 20190919 patches
Posted by Gerd Hoffmann 4 years, 7 months ago
The following changes since commit 89ea03a7dc83ca36b670ba7f787802791fcb04b1:

  Merge remote-tracking branch 'remotes/huth-gitlab/tags/m68k-pull-2019-09-07' into staging (2019-09-09 09:48:34 +0100)

are available in the Git repository at:

  git://git.kraxel.org/qemu tags/ui-20190919-pull-request

for you to fetch changes up to 6bf21f3d83e95bcc4ba35a7a07cc6655e8b010b0:

  vnc: fix memory leak when vnc disconnect (2019-09-17 13:45:10 +0200)

----------------------------------------------------------------
ui: add barrier client.
ui: bugfixes for vnc & egl.

----------------------------------------------------------------

Gerd Hoffmann (2):
  ui/egl: fix framebuffer reads
  vnc: fix websocket field in events

Laurent Vivier (1):
  ui: add an embedded Barrier client

Li Qiang (1):
  vnc: fix memory leak when vnc disconnect

 docs/barrier.txt         | 370 +++++++++++++++++++
 include/ui/egl-helpers.h |   2 +-
 ui/input-barrier.h       | 112 ++++++
 ui/vnc.h                 |   4 +-
 ui/egl-headless.c        |   4 +-
 ui/egl-helpers.c         |   6 +-
 ui/input-barrier.c       | 750 +++++++++++++++++++++++++++++++++++++++
 ui/vnc-enc-tight.c       | 219 ++++++------
 ui/vnc-enc-zlib.c        |  11 +-
 ui/vnc-enc-zrle.c        |  68 ++--
 ui/vnc-enc-zrle.inc.c    |   2 +-
 ui/vnc.c                 |  29 +-
 ui/Makefile.objs         |   1 +
 13 files changed, 1409 insertions(+), 169 deletions(-)
 create mode 100644 docs/barrier.txt
 create mode 100644 ui/input-barrier.h
 create mode 100644 ui/input-barrier.c

-- 
2.18.1


Re: [Qemu-devel] [PULL 0/4] Ui 20190919 patches
Posted by Peter Maydell 4 years, 7 months ago
On Thu, 19 Sep 2019 at 08:11, Gerd Hoffmann <kraxel@redhat.com> wrote:
>
> The following changes since commit 89ea03a7dc83ca36b670ba7f787802791fcb04b1:
>
>   Merge remote-tracking branch 'remotes/huth-gitlab/tags/m68k-pull-2019-09-07' into staging (2019-09-09 09:48:34 +0100)
>
> are available in the Git repository at:
>
>   git://git.kraxel.org/qemu tags/ui-20190919-pull-request
>
> for you to fetch changes up to 6bf21f3d83e95bcc4ba35a7a07cc6655e8b010b0:
>
>   vnc: fix memory leak when vnc disconnect (2019-09-17 13:45:10 +0200)
>
> ----------------------------------------------------------------
> ui: add barrier client.
> ui: bugfixes for vnc & egl.
>
> ----------------------------------------------------------------
>
> Gerd Hoffmann (2):
>   ui/egl: fix framebuffer reads
>   vnc: fix websocket field in events
>
> Laurent Vivier (1):
>   ui: add an embedded Barrier client
>
> Li Qiang (1):
>   vnc: fix memory leak when vnc disconnect

Dropping this pullreq because Li raised an issue with patch 4.

thanks
-- PMM

Re: [Qemu-devel] [PULL 0/4] Ui 20190919 patches
Posted by Gerd Hoffmann 4 years, 7 months ago
On Thu, Sep 19, 2019 at 11:13:30AM +0100, Peter Maydell wrote:
> On Thu, 19 Sep 2019 at 08:11, Gerd Hoffmann <kraxel@redhat.com> wrote:
> >
> > The following changes since commit 89ea03a7dc83ca36b670ba7f787802791fcb04b1:
> >
> >   Merge remote-tracking branch 'remotes/huth-gitlab/tags/m68k-pull-2019-09-07' into staging (2019-09-09 09:48:34 +0100)
> >
> > are available in the Git repository at:
> >
> >   git://git.kraxel.org/qemu tags/ui-20190919-pull-request
> >
> > for you to fetch changes up to 6bf21f3d83e95bcc4ba35a7a07cc6655e8b010b0:
> >
> >   vnc: fix memory leak when vnc disconnect (2019-09-17 13:45:10 +0200)
> >
> > ----------------------------------------------------------------
> > ui: add barrier client.
> > ui: bugfixes for vnc & egl.
> >
> > ----------------------------------------------------------------
> >
> > Gerd Hoffmann (2):
> >   ui/egl: fix framebuffer reads
> >   vnc: fix websocket field in events
> >
> > Laurent Vivier (1):
> >   ui: add an embedded Barrier client
> >
> > Li Qiang (1):
> >   vnc: fix memory leak when vnc disconnect
> 
> Dropping this pullreq because Li raised an issue with patch 4.

Discussion here:
 https://lists.gnu.org/archive/html/qemu-devel/2019-09/msg00030.html
  https://lists.gnu.org/archive/html/qemu-devel/2019-09/msg04161.html
   https://lists.gnu.org/archive/html/qemu-devel/2019-09/msg04220.html

Summary: all fine, there is no race.

cheers,
  Gerd


Re: [Qemu-devel] [PULL 0/4] Ui 20190919 patches
Posted by no-reply@patchew.org 4 years, 7 months ago
Patchew URL: https://patchew.org/QEMU/20190919070918.16059-1-kraxel@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: 20190919070918.16059-1-kraxel@redhat.com
Subject: [Qemu-devel] [PULL 0/4] Ui 20190919 patches
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
8c23403 vnc: fix memory leak when vnc disconnect
43a8bdb ui: add an embedded Barrier client
7dc6f4c vnc: fix websocket field in events
aca6a4a ui/egl: fix framebuffer reads

=== OUTPUT BEGIN ===
1/4 Checking commit aca6a4ab1693 (ui/egl: fix framebuffer reads)
2/4 Checking commit 7dc6f4caa2ef (vnc: fix websocket field in events)
3/4 Checking commit 43a8bdb1f7e6 (ui: add an embedded Barrier client)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#60: 
new file mode 100644

total: 0 errors, 1 warnings, 1239 lines checked

Patch 3/4 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
4/4 Checking commit 8c234039a34e (vnc: fix memory leak when vnc disconnect)
ERROR: spaces required around that '*' (ctx:WxB)
#120: FILE: ui/vnc-enc-tight.c:355:
+        data = (uint##bpp##_t *)vs->tight->tight.buffer;                \
                               ^

total: 1 errors, 0 warnings, 869 lines checked

Patch 4/4 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20190919070918.16059-1-kraxel@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
Re: [Qemu-devel] [PULL 0/4] Ui 20190919 patches
Posted by Peter Maydell 4 years, 7 months ago
On Thu, 19 Sep 2019 at 08:11, Gerd Hoffmann <kraxel@redhat.com> wrote:
>
> The following changes since commit 89ea03a7dc83ca36b670ba7f787802791fcb04b1:
>
>   Merge remote-tracking branch 'remotes/huth-gitlab/tags/m68k-pull-2019-09-07' into staging (2019-09-09 09:48:34 +0100)
>
> are available in the Git repository at:
>
>   git://git.kraxel.org/qemu tags/ui-20190919-pull-request
>
> for you to fetch changes up to 6bf21f3d83e95bcc4ba35a7a07cc6655e8b010b0:
>
>   vnc: fix memory leak when vnc disconnect (2019-09-17 13:45:10 +0200)
>
> ----------------------------------------------------------------
> ui: add barrier client.
> ui: bugfixes for vnc & egl.
>


Applied, thanks.

Please update the changelog at https://wiki.qemu.org/ChangeLog/4.2
for any user-visible changes.

-- PMM