[v2] vhost-user: save features if the char dev is closed

[Qemu-devel] [PATCH v2] vhost-user: save features if the char dev is closed

Adrian Moreno posted 1 patch 6 years ago

Diff against v1 v3
Download mbox

Test docker-clang@ubuntu passed

Test FreeBSD passed

Test docker-mingw@fedora passed

Test asan failed

Test checkpatch passed

Test docker-quick@centos7 passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20190918084834.9729-1-amorenoz@redhat.com

Maintainers: Jason Wang <jasowang@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>

There is a newer version of this series

net/vhost-user.c | 4 ++++
1 file changed, 4 insertions(+)

Expand all Fold all

[Qemu-devel] [PATCH v2] vhost-user: save features if the char dev is closed

Posted by Adrian Moreno 6 years ago

That way the state can be correctly restored when the device is opened
again. This might happen if the backend is restarted.

Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=1738768
Reported-by: Pei Zhang <pezhang@redhat.com>
Fixes: 6ab79a20af3a (do not call vhost_net_cleanup() on running net from char user event)
Cc: ddstreet@canonical.com
Cc: Michael S. Tsirkin <mst@redhat.com>

Signed-off-by: Adrian Moreno <amorenoz@redhat.com>
---
 net/vhost-user.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/net/vhost-user.c b/net/vhost-user.c
index 51921de443..014199d600 100644
--- a/net/vhost-user.c
+++ b/net/vhost-user.c
@@ -235,6 +235,10 @@ static void chr_closed_bh(void *opaque)

     s = DO_UPCAST(NetVhostUserState, nc, ncs[0]);

+    if (s->vhost_net) {
+        s->acked_features = vhost_net_get_acked_features(s->vhost_net);
+    }
+
     qmp_set_link(name, false, &err);

     qemu_chr_fe_set_handlers(&s->chr, NULL, NULL, net_vhost_user_event,
-- 
2.21.0

Re: [Qemu-devel] [PATCH v2] vhost-user: save features if the char dev is closed

Posted by no-reply@patchew.org 6 years ago

Patchew URL: https://patchew.org/QEMU/20190918084834.9729-1-amorenoz@redhat.com/



Hi,

This series failed the asan build test. Please find the testing commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.

=== TEST SCRIPT BEGIN ===
#!/bin/bash
export ARCH=x86_64
make docker-image-fedora V=1 NETWORK=1
time make docker-test-debug@fedora TARGET_LIST=x86_64-softmmu J=14 NETWORK=1
=== TEST SCRIPT END ===

  CC      qobject/qlit.o
  CC      qobject/qjson.o

Encoding error:
'utf-8' codec can't decode byte 0x95 in position 799: invalid start byte
The full traceback has been saved in /tmp/sphinx-err-mhg776xj.log, if you want to report the issue to the developers.
  CC      qobject/qobject.o


The full log is available at
http://patchew.org/logs/20190918084834.9729-1-amorenoz@redhat.com/testing.asan/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com

asan: false positive? (Was Re: [Qemu-devel] [PATCH v2] vhost-user: save features if the char dev is closed)

Posted by Michael S. Tsirkin 6 years ago

On Wed, Sep 18, 2019 at 10:10:05AM -0700, no-reply@patchew.org wrote:
> Patchew URL: https://patchew.org/QEMU/20190918084834.9729-1-amorenoz@redhat.com/
> 
> 
> 
> Hi,
> 
> This series failed the asan build test. Please find the testing commands and
> their output below. If you have Docker installed, you can probably reproduce it
> locally.
> 
> === TEST SCRIPT BEGIN ===
> #!/bin/bash
> export ARCH=x86_64
> make docker-image-fedora V=1 NETWORK=1
> time make docker-test-debug@fedora TARGET_LIST=x86_64-softmmu J=14 NETWORK=1
> === TEST SCRIPT END ===
> 
>   CC      qobject/qlit.o
>   CC      qobject/qjson.o
> 
> Encoding error:
> 'utf-8' codec can't decode byte 0x95 in position 799: invalid start byte
> The full traceback has been saved in /tmp/sphinx-err-mhg776xj.log, if you want to report the issue to the developers.
>   CC      qobject/qobject.o
> 
> 
> The full log is available at
> http://patchew.org/logs/20190918084834.9729-1-amorenoz@redhat.com/testing.asan/?type=message.

What happened here?
Does anyone know?

> ---
> Email generated automatically by Patchew [https://patchew.org/].
> Please send your feedback to patchew-devel@redhat.com