1. Patchew
  2. QEMU
  3. View series

[Qemu-devel] [PATCH v2 0/6] tests/acceptance: Add tests for the PReP/40p machine

Philippe Mathieu-Daudé posted 6 patches 6 years, 1 month ago
Test docker-clang@ubuntu failed
Test FreeBSD failed
Test checkpatch passed
Test docker-quick@centos7 failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20190915211940.30427-1-f4bug@amsat.org
There is a newer version of this series
.travis.yml                      |  18 +++-
MAINTAINERS                      |   1 +
tests/acceptance/ppc_prep_40p.py | 150 +++++++++++++++++++++++++++++++
3 files changed, 167 insertions(+), 2 deletions(-)
create mode 100644 tests/acceptance/ppc_prep_40p.py
[Qemu-devel] [PATCH v2 0/6] tests/acceptance: Add tests for the PReP/40p machine
Posted by Philippe Mathieu-Daudé 6 years, 1 month ago 
Quick tests worth to avoid regressions with the 40p machine.
idea from the "Maintainers, please tell us how to boot your machines"
thread:
https://lists.gnu.org/archive/html/qemu-devel/2019-03/msg04177.html

v2: Split Travis job, added Hervé R-b tag
v1: https://lists.gnu.org/archive/html/qemu-devel/2019-06/msg05896.html

Regards,

Phil.

Philippe Mathieu-Daudé (6):
  tests/acceptance: Add test that runs NetBSD 4.0 installer on PRep/40p
  tests/acceptance: Test Open Firmware on the PReP/40p
  tests/acceptance: Test OpenBIOS on the PReP/40p
  tests/acceptance: Test Sandalfoot initrd on the PReP/40p
  .travis.yml: Let the avocado job run the 40p tests
  .travis.yml: Split enterprise vs. hobbyist acceptance test job

 .travis.yml                      |  18 +++-
 MAINTAINERS                      |   1 +
 tests/acceptance/ppc_prep_40p.py | 150 +++++++++++++++++++++++++++++++
 3 files changed, 167 insertions(+), 2 deletions(-)
 create mode 100644 tests/acceptance/ppc_prep_40p.py

-- 
2.20.1
Re: [Qemu-devel] [PATCH v2 0/6] tests/acceptance: Add tests for the PReP/40p machine
Posted by David Gibson 6 years, 1 month ago 
On Sun, Sep 15, 2019 at 11:19:34PM +0200, Philippe Mathieu-Daudé wrote:
> Quick tests worth to avoid regressions with the 40p machine.
> idea from the "Maintainers, please tell us how to boot your machines"
> thread:
> https://lists.gnu.org/archive/html/qemu-devel/2019-03/msg04177.html
> 
> v2: Split Travis job, added Hervé R-b tag
> v1: https://lists.gnu.org/archive/html/qemu-devel/2019-06/msg05896.html
> 
> Regards,
> 
> Phil.

I'm guessing you're expecting these to go in via the testing tree, in
which case

Acked-by: David Gibson <david@gibson.dropbear.id.au>

Or do you want me to take them via the ppc tree?

> 
> Philippe Mathieu-Daudé (6):
>   tests/acceptance: Add test that runs NetBSD 4.0 installer on PRep/40p
>   tests/acceptance: Test Open Firmware on the PReP/40p
>   tests/acceptance: Test OpenBIOS on the PReP/40p
>   tests/acceptance: Test Sandalfoot initrd on the PReP/40p
>   .travis.yml: Let the avocado job run the 40p tests
>   .travis.yml: Split enterprise vs. hobbyist acceptance test job
> 
>  .travis.yml                      |  18 +++-
>  MAINTAINERS                      |   1 +
>  tests/acceptance/ppc_prep_40p.py | 150 +++++++++++++++++++++++++++++++
>  3 files changed, 167 insertions(+), 2 deletions(-)
>  create mode 100644 tests/acceptance/ppc_prep_40p.py
> 

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson
Re: [Qemu-devel] [PATCH v2 0/6] tests/acceptance: Add tests for the PReP/40p machine
Posted by Philippe Mathieu-Daudé 6 years, 1 month ago 
Hi David,

On 9/16/19 2:42 AM, David Gibson wrote:
> On Sun, Sep 15, 2019 at 11:19:34PM +0200, Philippe Mathieu-Daudé wrote:
>> Quick tests worth to avoid regressions with the 40p machine.
>> idea from the "Maintainers, please tell us how to boot your machines"
>> thread:
>> https://lists.gnu.org/archive/html/qemu-devel/2019-03/msg04177.html
>>
>> v2: Split Travis job, added Hervé R-b tag
>> v1: https://lists.gnu.org/archive/html/qemu-devel/2019-06/msg05896.html
>>
>> Regards,
>>
>> Phil.
> 
> I'm guessing you're expecting these to go in via the testing tree, in
> which case
> 
> Acked-by: David Gibson <david@gibson.dropbear.id.au>

Thanks, appreciated :)

> Or do you want me to take them via the ppc tree?

I think the 'testing tree' should focus on the CI/testing
infrastructure, while each subsystem maintainers should care about the
tests covering their subsystem (the testing tree maintainers might not
have the required knowledge to be sure a test is correctly implemented).

In this particular case I assume you don't have much knowledge of that
PPC machine, which is a hobbyist one, but since you are the PPC
maintainer, I'd rather see this going via your tree :)

Alex/Cleber/Eduardo, any comment on this position?

Thanks,

Phil.

>> Philippe Mathieu-Daudé (6):
>>   tests/acceptance: Add test that runs NetBSD 4.0 installer on PRep/40p
>>   tests/acceptance: Test Open Firmware on the PReP/40p
>>   tests/acceptance: Test OpenBIOS on the PReP/40p
>>   tests/acceptance: Test Sandalfoot initrd on the PReP/40p
>>   .travis.yml: Let the avocado job run the 40p tests
>>   .travis.yml: Split enterprise vs. hobbyist acceptance test job
>>
>>  .travis.yml                      |  18 +++-
>>  MAINTAINERS                      |   1 +
>>  tests/acceptance/ppc_prep_40p.py | 150 +++++++++++++++++++++++++++++++
>>  3 files changed, 167 insertions(+), 2 deletions(-)
>>  create mode 100644 tests/acceptance/ppc_prep_40p.py
>>
>
Re: [Qemu-devel] [PATCH v2 0/6] tests/acceptance: Add tests for the PReP/40p machine
Posted by Alex Bennée 6 years, 1 month ago 
Philippe Mathieu-Daudé <philmd@redhat.com> writes:

> Hi David,
>
> On 9/16/19 2:42 AM, David Gibson wrote:
>> On Sun, Sep 15, 2019 at 11:19:34PM +0200, Philippe Mathieu-Daudé wrote:
>>> Quick tests worth to avoid regressions with the 40p machine.
>>> idea from the "Maintainers, please tell us how to boot your machines"
>>> thread:
>>> https://lists.gnu.org/archive/html/qemu-devel/2019-03/msg04177.html
>>>
>>> v2: Split Travis job, added Hervé R-b tag
>>> v1: https://lists.gnu.org/archive/html/qemu-devel/2019-06/msg05896.html
>>>
>>> Regards,
>>>
>>> Phil.
>>
>> I'm guessing you're expecting these to go in via the testing tree, in
>> which case
>>
>> Acked-by: David Gibson <david@gibson.dropbear.id.au>
>
> Thanks, appreciated :)
>
>> Or do you want me to take them via the ppc tree?
>
> I think the 'testing tree' should focus on the CI/testing
> infrastructure, while each subsystem maintainers should care about the
> tests covering their subsystem (the testing tree maintainers might not
> have the required knowledge to be sure a test is correctly implemented).
>
> In this particular case I assume you don't have much knowledge of that
> PPC machine, which is a hobbyist one, but since you are the PPC
> maintainer, I'd rather see this going via your tree :)
>
> Alex/Cleber/Eduardo, any comment on this position?

Once we have a .travis.yml I'm happy with it can go in via another tree
no problem. See other thread....

>
> Thanks,
>
> Phil.
>
>>> Philippe Mathieu-Daudé (6):
>>>   tests/acceptance: Add test that runs NetBSD 4.0 installer on PRep/40p
>>>   tests/acceptance: Test Open Firmware on the PReP/40p
>>>   tests/acceptance: Test OpenBIOS on the PReP/40p
>>>   tests/acceptance: Test Sandalfoot initrd on the PReP/40p
>>>   .travis.yml: Let the avocado job run the 40p tests
>>>   .travis.yml: Split enterprise vs. hobbyist acceptance test job
>>>
>>>  .travis.yml                      |  18 +++-
>>>  MAINTAINERS                      |   1 +
>>>  tests/acceptance/ppc_prep_40p.py | 150 +++++++++++++++++++++++++++++++
>>>  3 files changed, 167 insertions(+), 2 deletions(-)
>>>  create mode 100644 tests/acceptance/ppc_prep_40p.py
>>>
>>


--
Alex Bennée
Re: [Qemu-devel] [PATCH v2 0/6] tests/acceptance: Add tests for the PReP/40p machine
Posted by Philippe Mathieu-Daudé 6 years, 1 month ago 
On 9/16/19 11:52 AM, Alex Bennée wrote:
> 
> Philippe Mathieu-Daudé <philmd@redhat.com> writes:
> 
>> Hi David,
>>
>> On 9/16/19 2:42 AM, David Gibson wrote:
>>> On Sun, Sep 15, 2019 at 11:19:34PM +0200, Philippe Mathieu-Daudé wrote:
>>>> Quick tests worth to avoid regressions with the 40p machine.
>>>> idea from the "Maintainers, please tell us how to boot your machines"
>>>> thread:
>>>> https://lists.gnu.org/archive/html/qemu-devel/2019-03/msg04177.html
>>>>
>>>> v2: Split Travis job, added Hervé R-b tag
>>>> v1: https://lists.gnu.org/archive/html/qemu-devel/2019-06/msg05896.html
>>>>
>>>> Regards,
>>>>
>>>> Phil.
>>>
>>> I'm guessing you're expecting these to go in via the testing tree, in
>>> which case
>>>
>>> Acked-by: David Gibson <david@gibson.dropbear.id.au>
>>
>> Thanks, appreciated :)
>>
>>> Or do you want me to take them via the ppc tree?
>>
>> I think the 'testing tree' should focus on the CI/testing
>> infrastructure, while each subsystem maintainers should care about the
>> tests covering their subsystem (the testing tree maintainers might not
>> have the required knowledge to be sure a test is correctly implemented).
>>
>> In this particular case I assume you don't have much knowledge of that
>> PPC machine, which is a hobbyist one, but since you are the PPC
>> maintainer, I'd rather see this going via your tree :)
>>
>> Alex/Cleber/Eduardo, any comment on this position?
> 
> Once we have a .travis.yml I'm happy with it can go in via another tree
> no problem. See other thread....

Good :)

David can take patches 1-5 (I tagged patch 6 as RFC but messed something
with git-publish and lost it when I sent this series).

Thanks!

>>>> Philippe Mathieu-Daudé (6):
>>>>   tests/acceptance: Add test that runs NetBSD 4.0 installer on PRep/40p
>>>>   tests/acceptance: Test Open Firmware on the PReP/40p
>>>>   tests/acceptance: Test OpenBIOS on the PReP/40p
>>>>   tests/acceptance: Test Sandalfoot initrd on the PReP/40p
>>>>   .travis.yml: Let the avocado job run the 40p tests
>>>>   .travis.yml: Split enterprise vs. hobbyist acceptance test job
>>>>
>>>>  .travis.yml                      |  18 +++-
>>>>  MAINTAINERS                      |   1 +
>>>>  tests/acceptance/ppc_prep_40p.py | 150 +++++++++++++++++++++++++++++++
>>>>  3 files changed, 167 insertions(+), 2 deletions(-)
>>>>  create mode 100644 tests/acceptance/ppc_prep_40p.py
>>>>
>>>
> 
> 
> --
> Alex Bennée
>
Re: [Qemu-devel] [Qemu-ppc] [PATCH v2 0/6] tests/acceptance: Add tests for the PReP/40p machine
Posted by David Gibson 6 years, 1 month ago 
On Mon, Sep 16, 2019 at 11:56:06AM +0200, Philippe Mathieu-Daudé wrote:
> On 9/16/19 11:52 AM, Alex Bennée wrote:
> > 
> > Philippe Mathieu-Daudé <philmd@redhat.com> writes:
> > 
> >> Hi David,
> >>
> >> On 9/16/19 2:42 AM, David Gibson wrote:
> >>> On Sun, Sep 15, 2019 at 11:19:34PM +0200, Philippe Mathieu-Daudé wrote:
> >>>> Quick tests worth to avoid regressions with the 40p machine.
> >>>> idea from the "Maintainers, please tell us how to boot your machines"
> >>>> thread:
> >>>> https://lists.gnu.org/archive/html/qemu-devel/2019-03/msg04177.html
> >>>>
> >>>> v2: Split Travis job, added Hervé R-b tag
> >>>> v1: https://lists.gnu.org/archive/html/qemu-devel/2019-06/msg05896.html
> >>>>
> >>>> Regards,
> >>>>
> >>>> Phil.
> >>>
> >>> I'm guessing you're expecting these to go in via the testing tree, in
> >>> which case
> >>>
> >>> Acked-by: David Gibson <david@gibson.dropbear.id.au>
> >>
> >> Thanks, appreciated :)
> >>
> >>> Or do you want me to take them via the ppc tree?
> >>
> >> I think the 'testing tree' should focus on the CI/testing
> >> infrastructure, while each subsystem maintainers should care about the
> >> tests covering their subsystem (the testing tree maintainers might not
> >> have the required knowledge to be sure a test is correctly implemented).
> >>
> >> In this particular case I assume you don't have much knowledge of that
> >> PPC machine, which is a hobbyist one, but since you are the PPC
> >> maintainer, I'd rather see this going via your tree :)
> >>
> >> Alex/Cleber/Eduardo, any comment on this position?
> > 
> > Once we have a .travis.yml I'm happy with it can go in via another tree
> > no problem. See other thread....
> 
> Good :)
> 
> David can take patches 1-5 (I tagged patch 6 as RFC but messed something
> with git-publish and lost it when I sent this series).

Ok, I've taken patches 1-5 into my ppc-for-4.2 tree.

> 
> Thanks!
> 
> >>>> Philippe Mathieu-Daudé (6):
> >>>>   tests/acceptance: Add test that runs NetBSD 4.0 installer on PRep/40p
> >>>>   tests/acceptance: Test Open Firmware on the PReP/40p
> >>>>   tests/acceptance: Test OpenBIOS on the PReP/40p
> >>>>   tests/acceptance: Test Sandalfoot initrd on the PReP/40p
> >>>>   .travis.yml: Let the avocado job run the 40p tests
> >>>>   .travis.yml: Split enterprise vs. hobbyist acceptance test job
> >>>>
> >>>>  .travis.yml                      |  18 +++-
> >>>>  MAINTAINERS                      |   1 +
> >>>>  tests/acceptance/ppc_prep_40p.py | 150 +++++++++++++++++++++++++++++++
> >>>>  3 files changed, 167 insertions(+), 2 deletions(-)
> >>>>  create mode 100644 tests/acceptance/ppc_prep_40p.py
> >>>>
> >>>
> > 
> > 
> 

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson
Re: [Qemu-devel] [Qemu-ppc] [PATCH v2 0/6] tests/acceptance: Add tests for the PReP/40p machine
Posted by David Gibson 6 years, 1 month ago 
On Tue, Sep 17, 2019 at 12:19:52PM +1000, David Gibson wrote:
> On Mon, Sep 16, 2019 at 11:56:06AM +0200, Philippe Mathieu-Daudé wrote:
> > On 9/16/19 11:52 AM, Alex Bennée wrote:
> > > 
> > > Philippe Mathieu-Daudé <philmd@redhat.com> writes:
> > > 
> > >> Hi David,
> > >>
> > >> On 9/16/19 2:42 AM, David Gibson wrote:
> > >>> On Sun, Sep 15, 2019 at 11:19:34PM +0200, Philippe Mathieu-Daudé wrote:
> > >>>> Quick tests worth to avoid regressions with the 40p machine.
> > >>>> idea from the "Maintainers, please tell us how to boot your machines"
> > >>>> thread:
> > >>>> https://lists.gnu.org/archive/html/qemu-devel/2019-03/msg04177.html
> > >>>>
> > >>>> v2: Split Travis job, added Hervé R-b tag
> > >>>> v1: https://lists.gnu.org/archive/html/qemu-devel/2019-06/msg05896.html
> > >>>>
> > >>>> Regards,
> > >>>>
> > >>>> Phil.
> > >>>
> > >>> I'm guessing you're expecting these to go in via the testing tree, in
> > >>> which case
> > >>>
> > >>> Acked-by: David Gibson <david@gibson.dropbear.id.au>
> > >>
> > >> Thanks, appreciated :)
> > >>
> > >>> Or do you want me to take them via the ppc tree?
> > >>
> > >> I think the 'testing tree' should focus on the CI/testing
> > >> infrastructure, while each subsystem maintainers should care about the
> > >> tests covering their subsystem (the testing tree maintainers might not
> > >> have the required knowledge to be sure a test is correctly implemented).
> > >>
> > >> In this particular case I assume you don't have much knowledge of that
> > >> PPC machine, which is a hobbyist one, but since you are the PPC
> > >> maintainer, I'd rather see this going via your tree :)
> > >>
> > >> Alex/Cleber/Eduardo, any comment on this position?
> > > 
> > > Once we have a .travis.yml I'm happy with it can go in via another tree
> > > no problem. See other thread....
> > 
> > Good :)
> > 
> > David can take patches 1-5 (I tagged patch 6 as RFC but messed something
> > with git-publish and lost it when I sent this series).
> 
> Ok, I've taken patches 1-5 into my ppc-for-4.2 tree.

Hrm.  Judging by both the continued comments on this thread, and the
fact it breaks the travis build, seems like this series needs a little
more work.  I've pulled it out of ppc-for-4.2 again, and I'll wait for
the next spin.

> 
> > 
> > Thanks!
> > 
> > >>>> Philippe Mathieu-Daudé (6):
> > >>>>   tests/acceptance: Add test that runs NetBSD 4.0 installer on PRep/40p
> > >>>>   tests/acceptance: Test Open Firmware on the PReP/40p
> > >>>>   tests/acceptance: Test OpenBIOS on the PReP/40p
> > >>>>   tests/acceptance: Test Sandalfoot initrd on the PReP/40p
> > >>>>   .travis.yml: Let the avocado job run the 40p tests
> > >>>>   .travis.yml: Split enterprise vs. hobbyist acceptance test job
> > >>>>
> > >>>>  .travis.yml                      |  18 +++-
> > >>>>  MAINTAINERS                      |   1 +
> > >>>>  tests/acceptance/ppc_prep_40p.py | 150 +++++++++++++++++++++++++++++++
> > >>>>  3 files changed, 167 insertions(+), 2 deletions(-)
> > >>>>  create mode 100644 tests/acceptance/ppc_prep_40p.py
> > >>>>
> > >>>
> > > 
> > > 
> > 
> 



-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson
Re: [Qemu-devel] [Qemu-ppc] [PATCH v2 0/6] tests/acceptance: Add tests for the PReP/40p machine
Posted by Philippe Mathieu-Daudé 6 years, 1 month ago 
On 9/17/19 1:40 PM, David Gibson wrote:
> On Tue, Sep 17, 2019 at 12:19:52PM +1000, David Gibson wrote:
>> On Mon, Sep 16, 2019 at 11:56:06AM +0200, Philippe Mathieu-Daudé wrote:
>>> On 9/16/19 11:52 AM, Alex Bennée wrote:
>>>>
>>>> Philippe Mathieu-Daudé <philmd@redhat.com> writes:
>>>>
>>>>> Hi David,
>>>>>
>>>>> On 9/16/19 2:42 AM, David Gibson wrote:
>>>>>> On Sun, Sep 15, 2019 at 11:19:34PM +0200, Philippe Mathieu-Daudé wrote:
>>>>>>> Quick tests worth to avoid regressions with the 40p machine.
>>>>>>> idea from the "Maintainers, please tell us how to boot your machines"
>>>>>>> thread:
>>>>>>> https://lists.gnu.org/archive/html/qemu-devel/2019-03/msg04177.html
>>>>>>>
>>>>>>> v2: Split Travis job, added Hervé R-b tag
>>>>>>> v1: https://lists.gnu.org/archive/html/qemu-devel/2019-06/msg05896.html
>>>>>>>
>>>>>>> Regards,
>>>>>>>
>>>>>>> Phil.
>>>>>>
>>>>>> I'm guessing you're expecting these to go in via the testing tree, in
>>>>>> which case
>>>>>>
>>>>>> Acked-by: David Gibson <david@gibson.dropbear.id.au>
>>>>>
>>>>> Thanks, appreciated :)
>>>>>
>>>>>> Or do you want me to take them via the ppc tree?
>>>>>
>>>>> I think the 'testing tree' should focus on the CI/testing
>>>>> infrastructure, while each subsystem maintainers should care about the
>>>>> tests covering their subsystem (the testing tree maintainers might not
>>>>> have the required knowledge to be sure a test is correctly implemented).
>>>>>
>>>>> In this particular case I assume you don't have much knowledge of that
>>>>> PPC machine, which is a hobbyist one, but since you are the PPC
>>>>> maintainer, I'd rather see this going via your tree :)
>>>>>
>>>>> Alex/Cleber/Eduardo, any comment on this position?
>>>>
>>>> Once we have a .travis.yml I'm happy with it can go in via another tree
>>>> no problem. See other thread....
>>>
>>> Good :)
>>>
>>> David can take patches 1-5 (I tagged patch 6 as RFC but messed something
>>> with git-publish and lost it when I sent this series).
>>
>> Ok, I've taken patches 1-5 into my ppc-for-4.2 tree.
> 
> Hrm.  Judging by both the continued comments on this thread, and the
> fact it breaks the travis build, seems like this series needs a little
> more work.  I've pulled it out of ppc-for-4.2 again, and I'll wait for
> the next spin.

OK, sorry :|
Re: [Qemu-devel] [PATCH v2 0/6] tests/acceptance: Add tests for the PReP/40p machine
Posted by Eduardo Habkost 6 years, 1 month ago 
On Mon, Sep 16, 2019 at 11:28:23AM +0200, Philippe Mathieu-Daudé wrote:
> Hi David,
> 
> On 9/16/19 2:42 AM, David Gibson wrote:
> > On Sun, Sep 15, 2019 at 11:19:34PM +0200, Philippe Mathieu-Daudé wrote:
> >> Quick tests worth to avoid regressions with the 40p machine.
> >> idea from the "Maintainers, please tell us how to boot your machines"
> >> thread:
> >> https://lists.gnu.org/archive/html/qemu-devel/2019-03/msg04177.html
> >>
> >> v2: Split Travis job, added Hervé R-b tag
> >> v1: https://lists.gnu.org/archive/html/qemu-devel/2019-06/msg05896.html
> >>
> >> Regards,
> >>
> >> Phil.
> > 
> > I'm guessing you're expecting these to go in via the testing tree, in
> > which case
> > 
> > Acked-by: David Gibson <david@gibson.dropbear.id.au>
> 
> Thanks, appreciated :)
> 
> > Or do you want me to take them via the ppc tree?
> 
> I think the 'testing tree' should focus on the CI/testing
> infrastructure, while each subsystem maintainers should care about the
> tests covering their subsystem (the testing tree maintainers might not
> have the required knowledge to be sure a test is correctly implemented).
> 
> In this particular case I assume you don't have much knowledge of that
> PPC machine, which is a hobbyist one, but since you are the PPC
> maintainer, I'd rather see this going via your tree :)
> 
> Alex/Cleber/Eduardo, any comment on this position?

This makes sense to me.  We don't need all new tests to go
through the same tree.

-- 
Eduardo

Patchew 2.1-devel-b67e4c2

© 2016 - 2025 Red Hat, Inc.