1. Patchew
  2. QEMU
  3. View series

[Qemu-devel] [PATCH] configure: Add xkbcommon configure options

James Le Cuirot posted 1 patch 6 years, 1 month ago
Test docker-clang@ubuntu passed
Test FreeBSD passed
Test checkpatch passed
Test docker-quick@centos7 passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20190914145155.19360-1-chewi@gentoo.org
configure | 5 +++++
1 file changed, 5 insertions(+)
[Qemu-devel] [PATCH] configure: Add xkbcommon configure options
Posted by James Le Cuirot 6 years, 1 month ago 
This dependency is currently "automagic", which is bad for distributions.

Signed-off-by: James Le Cuirot <chewi@gentoo.org>
---
 configure | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/configure b/configure
index 30aad233d1..30544f52e6 100755
--- a/configure
+++ b/configure
@@ -1521,6 +1521,10 @@ for opt do
   ;;
   --disable-libpmem) libpmem=no
   ;;
+  --enable-xkbcommon) xkbcommon=yes
+  ;;
+  --disable-xkbcommon) xkbcommon=no
+  ;;
   *)
       echo "ERROR: unknown option $opt"
       echo "Try '$0 --help' for more information"
@@ -1804,6 +1808,7 @@ disabled with --disable-FEATURE, default is enabled if available:
   capstone        capstone disassembler support
   debug-mutex     mutex debugging support
   libpmem         libpmem support
+  xkbcommon       xkbcommon support
 
 NOTE: The object files are built at the place where configure is launched
 EOF
-- 
2.23.0
Re: [Qemu-devel] [PATCH] configure: Add xkbcommon configure options
Posted by Philippe Mathieu-Daudé 6 years, 1 month ago 
On 9/14/19 4:51 PM, James Le Cuirot wrote:
> This dependency is currently "automagic", which is bad for distributions.
> 

Fixes: 6a021536e23
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>

> Signed-off-by: James Le Cuirot <chewi@gentoo.org>
> ---
>  configure | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/configure b/configure
> index 30aad233d1..30544f52e6 100755
> --- a/configure
> +++ b/configure
> @@ -1521,6 +1521,10 @@ for opt do
>    ;;
>    --disable-libpmem) libpmem=no
>    ;;
> +  --enable-xkbcommon) xkbcommon=yes
> +  ;;
> +  --disable-xkbcommon) xkbcommon=no
> +  ;;
>    *)
>        echo "ERROR: unknown option $opt"
>        echo "Try '$0 --help' for more information"
> @@ -1804,6 +1808,7 @@ disabled with --disable-FEATURE, default is enabled if available:
>    capstone        capstone disassembler support
>    debug-mutex     mutex debugging support
>    libpmem         libpmem support
> +  xkbcommon       xkbcommon support
>  
>  NOTE: The object files are built at the place where configure is launched
>  EOF
>
Re: [Qemu-devel] [Qemu-trivial] [PATCH] configure: Add xkbcommon configure options
Posted by Laurent Vivier 6 years, 1 month ago 
Le 14/09/2019 à 16:51, James Le Cuirot a écrit :
> This dependency is currently "automagic", which is bad for distributions.
> 
> Signed-off-by: James Le Cuirot <chewi@gentoo.org>
> ---
>  configure | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/configure b/configure
> index 30aad233d1..30544f52e6 100755
> --- a/configure
> +++ b/configure
> @@ -1521,6 +1521,10 @@ for opt do
>    ;;
>    --disable-libpmem) libpmem=no
>    ;;
> +  --enable-xkbcommon) xkbcommon=yes
> +  ;;
> +  --disable-xkbcommon) xkbcommon=no
> +  ;;
>    *)
>        echo "ERROR: unknown option $opt"
>        echo "Try '$0 --help' for more information"
> @@ -1804,6 +1808,7 @@ disabled with --disable-FEATURE, default is enabled if available:
>    capstone        capstone disassembler support
>    debug-mutex     mutex debugging support
>    libpmem         libpmem support
> +  xkbcommon       xkbcommon support
>  
>  NOTE: The object files are built at the place where configure is launched
>  EOF
> 

Reviewed-by: Laurent Vivier <laurent@vivier.eu>

cc: Gerd Hoffmann <kraxel@redhat.com>
Re: [Qemu-devel] [Qemu-trivial] [PATCH] configure: Add xkbcommon configure options
Posted by Gerd Hoffmann 6 years, 1 month ago 
On Mon, Sep 16, 2019 at 10:15:15AM +0200, Laurent Vivier wrote:
> Le 14/09/2019 à 16:51, James Le Cuirot a écrit :
> > This dependency is currently "automagic", which is bad for distributions.
> > 
> > Signed-off-by: James Le Cuirot <chewi@gentoo.org>
> > ---
> >  configure | 5 +++++
> >  1 file changed, 5 insertions(+)
> > 
> > diff --git a/configure b/configure
> > index 30aad233d1..30544f52e6 100755
> > --- a/configure
> > +++ b/configure
> > @@ -1521,6 +1521,10 @@ for opt do
> >    ;;
> >    --disable-libpmem) libpmem=no
> >    ;;
> > +  --enable-xkbcommon) xkbcommon=yes
> > +  ;;
> > +  --disable-xkbcommon) xkbcommon=no
> > +  ;;
> >    *)
> >        echo "ERROR: unknown option $opt"
> >        echo "Try '$0 --help' for more information"
> > @@ -1804,6 +1808,7 @@ disabled with --disable-FEATURE, default is enabled if available:
> >    capstone        capstone disassembler support
> >    debug-mutex     mutex debugging support
> >    libpmem         libpmem support
> > +  xkbcommon       xkbcommon support
> >  
> >  NOTE: The object files are built at the place where configure is launched
> >  EOF
> > 
> 
> Reviewed-by: Laurent Vivier <laurent@vivier.eu>
> 
> cc: Gerd Hoffmann <kraxel@redhat.com>

Reviewed-by: Gerd Hoffmann <kraxel@redhat.com>
Re: [Qemu-devel] [Qemu-trivial] [PATCH] configure: Add xkbcommon configure options
Posted by Laurent Vivier 6 years, 1 month ago 
Le 19/09/2019 à 10:37, Gerd Hoffmann a écrit :
> On Mon, Sep 16, 2019 at 10:15:15AM +0200, Laurent Vivier wrote:
>> Le 14/09/2019 à 16:51, James Le Cuirot a écrit :
>>> This dependency is currently "automagic", which is bad for distributions.
>>>
>>> Signed-off-by: James Le Cuirot <chewi@gentoo.org>
>>> ---
>>>  configure | 5 +++++
>>>  1 file changed, 5 insertions(+)
>>>
>>> diff --git a/configure b/configure
>>> index 30aad233d1..30544f52e6 100755
>>> --- a/configure
>>> +++ b/configure
>>> @@ -1521,6 +1521,10 @@ for opt do
>>>    ;;
>>>    --disable-libpmem) libpmem=no
>>>    ;;
>>> +  --enable-xkbcommon) xkbcommon=yes
>>> +  ;;
>>> +  --disable-xkbcommon) xkbcommon=no
>>> +  ;;
>>>    *)
>>>        echo "ERROR: unknown option $opt"
>>>        echo "Try '$0 --help' for more information"
>>> @@ -1804,6 +1808,7 @@ disabled with --disable-FEATURE, default is enabled if available:
>>>    capstone        capstone disassembler support
>>>    debug-mutex     mutex debugging support
>>>    libpmem         libpmem support
>>> +  xkbcommon       xkbcommon support
>>>  
>>>  NOTE: The object files are built at the place where configure is launched
>>>  EOF
>>>
>>
>> Reviewed-by: Laurent Vivier <laurent@vivier.eu>
>>
>> cc: Gerd Hoffmann <kraxel@redhat.com>
> 
> Reviewed-by: Gerd Hoffmann <kraxel@redhat.com>
> 

Gerd,

do you take this through your ui branch or should I take through the
trivial patches branch?

Thanks,
Laurent
Re: [Qemu-devel] [Qemu-trivial] [PATCH] configure: Add xkbcommon configure options
Posted by Gerd Hoffmann 6 years, 1 month ago 
On Thu, Sep 19, 2019 at 12:16:43PM +0200, Laurent Vivier wrote:
> Le 19/09/2019 à 10:37, Gerd Hoffmann a écrit :
> > On Mon, Sep 16, 2019 at 10:15:15AM +0200, Laurent Vivier wrote:
> >> Le 14/09/2019 à 16:51, James Le Cuirot a écrit :
> >>> This dependency is currently "automagic", which is bad for distributions.
> >>>
> >>> Signed-off-by: James Le Cuirot <chewi@gentoo.org>
> >>> ---
> >>>  configure | 5 +++++
> >>>  1 file changed, 5 insertions(+)
> >>>
> >>> diff --git a/configure b/configure
> >>> index 30aad233d1..30544f52e6 100755
> >>> --- a/configure
> >>> +++ b/configure
> >>> @@ -1521,6 +1521,10 @@ for opt do
> >>>    ;;
> >>>    --disable-libpmem) libpmem=no
> >>>    ;;
> >>> +  --enable-xkbcommon) xkbcommon=yes
> >>> +  ;;
> >>> +  --disable-xkbcommon) xkbcommon=no
> >>> +  ;;
> >>>    *)
> >>>        echo "ERROR: unknown option $opt"
> >>>        echo "Try '$0 --help' for more information"
> >>> @@ -1804,6 +1808,7 @@ disabled with --disable-FEATURE, default is enabled if available:
> >>>    capstone        capstone disassembler support
> >>>    debug-mutex     mutex debugging support
> >>>    libpmem         libpmem support
> >>> +  xkbcommon       xkbcommon support
> >>>  
> >>>  NOTE: The object files are built at the place where configure is launched
> >>>  EOF
> >>>
> >>
> >> Reviewed-by: Laurent Vivier <laurent@vivier.eu>
> >>
> >> cc: Gerd Hoffmann <kraxel@redhat.com>
> > 
> > Reviewed-by: Gerd Hoffmann <kraxel@redhat.com>
> > 
> 
> Gerd,
> 
> do you take this through your ui branch or should I take through the
> trivial patches branch?

Trivial branch is fine (have not picked this up b/c I saw qemu-trivial
on cc).

cheers,
  Gerd

> 
> Thanks,
> Laurent
Re: [Qemu-devel] [Qemu-trivial] [PATCH] configure: Add xkbcommon configure options
Posted by Laurent Vivier 6 years, 1 month ago 
Le 19/09/2019 à 13:01, Gerd Hoffmann a écrit :
> On Thu, Sep 19, 2019 at 12:16:43PM +0200, Laurent Vivier wrote:
>> Le 19/09/2019 à 10:37, Gerd Hoffmann a écrit :
>>> On Mon, Sep 16, 2019 at 10:15:15AM +0200, Laurent Vivier wrote:
>>>> Le 14/09/2019 à 16:51, James Le Cuirot a écrit :
>>>>> This dependency is currently "automagic", which is bad for distributions.
>>>>>
>>>>> Signed-off-by: James Le Cuirot <chewi@gentoo.org>
>>>>> ---
>>>>>  configure | 5 +++++
>>>>>  1 file changed, 5 insertions(+)
>>>>>
>>>>> diff --git a/configure b/configure
>>>>> index 30aad233d1..30544f52e6 100755
>>>>> --- a/configure
>>>>> +++ b/configure
>>>>> @@ -1521,6 +1521,10 @@ for opt do
>>>>>    ;;
>>>>>    --disable-libpmem) libpmem=no
>>>>>    ;;
>>>>> +  --enable-xkbcommon) xkbcommon=yes
>>>>> +  ;;
>>>>> +  --disable-xkbcommon) xkbcommon=no
>>>>> +  ;;
>>>>>    *)
>>>>>        echo "ERROR: unknown option $opt"
>>>>>        echo "Try '$0 --help' for more information"
>>>>> @@ -1804,6 +1808,7 @@ disabled with --disable-FEATURE, default is enabled if available:
>>>>>    capstone        capstone disassembler support
>>>>>    debug-mutex     mutex debugging support
>>>>>    libpmem         libpmem support
>>>>> +  xkbcommon       xkbcommon support
>>>>>  
>>>>>  NOTE: The object files are built at the place where configure is launched
>>>>>  EOF
>>>>>
>>>>
>>>> Reviewed-by: Laurent Vivier <laurent@vivier.eu>
>>>>
>>>> cc: Gerd Hoffmann <kraxel@redhat.com>
>>>
>>> Reviewed-by: Gerd Hoffmann <kraxel@redhat.com>
>>>
>>
>> Gerd,
>>
>> do you take this through your ui branch or should I take through the
>> trivial patches branch?
> 
> Trivial branch is fine (have not picked this up b/c I saw qemu-trivial
> on cc).

Applied to my trivial-patches branch.

Thanks,
Laurent

Patchew 2.1-devel-b67e4c2

© 2016 - 2025 Red Hat, Inc.