build: Don't ignore qapi-visit-core.c

[Qemu-devel] [PATCH] build: Don't ignore qapi-visit-core.c

Posted by Eric Blake 6 years ago

This file is version-controlled, and not generated from a .json file.

Fixes: bf582c3461b
Reported-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Eric Blake <eblake@redhat.com>
---
 .gitignore | 1 +
 1 file changed, 1 insertion(+)

diff --git a/.gitignore b/.gitignore
index e9bbc006d39e..7de868d1eab4 100644
--- a/.gitignore
+++ b/.gitignore
@@ -41,6 +41,7 @@
 /qapi/qapi-types-*.[ch]
 /qapi/qapi-types.[ch]
 /qapi/qapi-visit-*.[ch]
+!/qapi/qapi-visit-core.c
 /qapi/qapi-visit.[ch]
 /qapi/qapi-doc.texi
 /qemu-doc.html
-- 
2.21.0

Re: [Qemu-devel] [PATCH] build: Don't ignore qapi-visit-core.c

Posted by Thomas Huth 6 years ago

On 12/09/2019 20.46, Eric Blake wrote:
> This file is version-controlled, and not generated from a .json file.
> 
> Fixes: bf582c3461b
> Reported-by: Thomas Huth <thuth@redhat.com>
> Signed-off-by: Eric Blake <eblake@redhat.com>
> ---
>  .gitignore | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/.gitignore b/.gitignore
> index e9bbc006d39e..7de868d1eab4 100644
> --- a/.gitignore
> +++ b/.gitignore
> @@ -41,6 +41,7 @@
>  /qapi/qapi-types-*.[ch]
>  /qapi/qapi-types.[ch]
>  /qapi/qapi-visit-*.[ch]
> +!/qapi/qapi-visit-core.c
>  /qapi/qapi-visit.[ch]
>  /qapi/qapi-doc.texi
>  /qemu-doc.html
> 

Thanks!

Reviewed-by: Thomas Huth <thuth@redhat.com>

Re: [Qemu-devel] [PATCH] build: Don't ignore qapi-visit-core.c

Posted by Philippe Mathieu-Daudé 6 years ago

On 9/12/19 8:46 PM, Eric Blake wrote:
> This file is version-controlled, and not generated from a .json file.
> 
> Fixes: bf582c3461b
> Reported-by: Thomas Huth <thuth@redhat.com>

Good catch!

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>

> Signed-off-by: Eric Blake <eblake@redhat.com>
> ---
>  .gitignore | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/.gitignore b/.gitignore
> index e9bbc006d39e..7de868d1eab4 100644
> --- a/.gitignore
> +++ b/.gitignore
> @@ -41,6 +41,7 @@
>  /qapi/qapi-types-*.[ch]
>  /qapi/qapi-types.[ch]
>  /qapi/qapi-visit-*.[ch]
> +!/qapi/qapi-visit-core.c
>  /qapi/qapi-visit.[ch]
>  /qapi/qapi-doc.texi
>  /qemu-doc.html
>

Re: [Qemu-devel] [PATCH] build: Don't ignore qapi-visit-core.c

Posted by Eric Blake 6 years ago

cc: qemu-trivial

On 9/12/19 1:46 PM, Eric Blake wrote:
> This file is version-controlled, and not generated from a .json file.
> 
> Fixes: bf582c3461b
> Reported-by: Thomas Huth <thuth@redhat.com>
> Signed-off-by: Eric Blake <eblake@redhat.com>
> ---
>  .gitignore | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/.gitignore b/.gitignore
> index e9bbc006d39e..7de868d1eab4 100644
> --- a/.gitignore
> +++ b/.gitignore
> @@ -41,6 +41,7 @@
>  /qapi/qapi-types-*.[ch]
>  /qapi/qapi-types.[ch]
>  /qapi/qapi-visit-*.[ch]
> +!/qapi/qapi-visit-core.c
>  /qapi/qapi-visit.[ch]
>  /qapi/qapi-doc.texi
>  /qemu-doc.html
> 

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org

Re: [Qemu-devel] [PATCH] build: Don't ignore qapi-visit-core.c

Posted by Laurent Vivier 6 years ago

Le 13/09/2019 à 13:34, Eric Blake a écrit :
> cc: qemu-trivial
> 
> On 9/12/19 1:46 PM, Eric Blake wrote:
>> This file is version-controlled, and not generated from a .json file.
>>
>> Fixes: bf582c3461b
>> Reported-by: Thomas Huth <thuth@redhat.com>
>> Signed-off-by: Eric Blake <eblake@redhat.com>
>> ---
>>  .gitignore | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/.gitignore b/.gitignore
>> index e9bbc006d39e..7de868d1eab4 100644
>> --- a/.gitignore
>> +++ b/.gitignore
>> @@ -41,6 +41,7 @@
>>  /qapi/qapi-types-*.[ch]
>>  /qapi/qapi-types.[ch]
>>  /qapi/qapi-visit-*.[ch]
>> +!/qapi/qapi-visit-core.c
>>  /qapi/qapi-visit.[ch]
>>  /qapi/qapi-doc.texi
>>  /qemu-doc.html
>>
> 

Applied to my trivial-patches branch.

Thanks,
Laurent