[Qemu-devel] [RFC v2 0/2] vhost-user: in-band notifications

Johannes Berg posted 2 patches 4 years, 7 months ago
Test docker-clang@ubuntu failed
Test FreeBSD passed
Test checkpatch failed
Test docker-quick@centos7 passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20190911134539.25650-1-johannes@sipsolutions.net
Maintainers: "Michael S. Tsirkin" <mst@redhat.com>
[Qemu-devel] [RFC v2 0/2] vhost-user: in-band notifications
Posted by Johannes Berg 4 years, 7 months ago
Here's a respin of both the docs and the code, hopefully addressing
most of the requests from review. Let me know if I've missed anything
or not done it in the way you thought.

Thanks,
johannes



Re: [Qemu-devel] [RFC v2 0/2] vhost-user: in-band notifications
Posted by no-reply@patchew.org 4 years, 7 months ago
Patchew URL: https://patchew.org/QEMU/20190911134539.25650-1-johannes@sipsolutions.net/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [Qemu-devel] [RFC v2 0/2] vhost-user: in-band notifications
Message-id: 20190911134539.25650-1-johannes@sipsolutions.net
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Switched to a new branch 'test'
9f34f61 libvhost-user: implement in-band notifications
8f4b013 docs: vhost-user: add in-band kick/call messages

=== OUTPUT BEGIN ===
1/2 Checking commit 8f4b0138608c (docs: vhost-user: add in-band kick/call messages)
2/2 Checking commit 9f34f61c2044 (libvhost-user: implement in-band notifications)
ERROR: code indent should never use tabs
#183: FILE: contrib/libvhost-user/libvhost-user.c:1508:
+^I   dev->vq[index].handler, index);$

total: 1 errors, 0 warnings, 211 lines checked

Patch 2/2 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20190911134539.25650-1-johannes@sipsolutions.net/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com