Hi Laurent,

Few patches I'v been writting while trying to figure out this issue:
http://lists.nongnu.org/archive/html/qemu-arm/2018-01/msg00514.html

As usual with linux-user files, this series will trigger some checkpatch
benign warnings.

Regards,

Phil.

Since v5:
- dropped 'Verify recvfrom(addr)' since failing LTP testsuite (see [1])
- also define print_sockfd() for bind() (patches #6 and #7)

Since v4:
- rebased on master (no change)

Since v3:
- addressed Laurent comments
- added print_sockfd()
- removed the print_sockaddr_ptr() patch, also the two
  getsockname()/recvfrom() patches for after 3.0.

Since v2:
- display invalid pointer in print_timeval() and print_timezone()
- do not display gettimeofday() arguments

Since v1:
- addressed Laurent comments
- added 'last' argument to print_sockaddr()
- reordered series, so patches already correct can get applied directly
- dropped "linux-user/syscall: simplify recvfrom()" for now

v1: http://lists.nongnu.org/archive/html/qemu-devel/2018-01/msg05855.html
v2: http://lists.nongnu.org/archive/html/qemu-devel/2018-06/msg08216.html
v3: http://lists.nongnu.org/archive/html/qemu-devel/2018-07/msg00411.html
v5: https://lists.gnu.org/archive/html/qemu-devel/2018-10/msg02067.html
[1] https://lists.gnu.org/archive/html/qemu-devel/2018-10/msg02807.html

Philippe Mathieu-Daudé (8):
  linux-user/strace: Display invalid pointer in print_timeval()
  linux-user/strace: Add print_timezone()
  linux-user/strace: Improve settimeofday()
  linux-user/syscall: Introduce target_sockaddr_nl
  linux-user/strace: Dump AF_NETLINK sockaddr content
  linux-user/strace: Add print_sockfd()
  linux-user/strace: Improve bind() output
  linux-user/strace: Let print_sockaddr() have a 'last' argument

 linux-user/strace.c       | 121 ++++++++++++++++++++++++++++++++++----
 linux-user/strace.list    |   4 +-
 linux-user/syscall.c      |   6 +-
 linux-user/syscall_defs.h |   7 +++
 4 files changed, 121 insertions(+), 17 deletions(-)

-- 
2.20.1

Patchew URL: https://patchew.org/QEMU/20190908061543.25136-1-f4bug@amsat.org/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: 20190908061543.25136-1-f4bug@amsat.org
Subject: [Qemu-devel] [PATCH v6 0/8] linux-user: strace improvements
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
d2015e2 linux-user/strace: Let print_sockaddr() have a 'last' argument
4c7df4b linux-user/strace: Improve bind() output
6523a43 linux-user/strace: Add print_sockfd()
073f6fd linux-user/strace: Dump AF_NETLINK sockaddr content
2abd312 linux-user/syscall: Introduce target_sockaddr_nl
0f5e8ed linux-user/strace: Improve settimeofday()
19233df linux-user/strace: Add print_timezone()
be098a1 linux-user/strace: Display invalid pointer in print_timeval()

=== OUTPUT BEGIN ===
1/8 Checking commit be098a139807 (linux-user/strace: Display invalid pointer in print_timeval())
2/8 Checking commit 19233df8c5da (linux-user/strace: Add print_timezone())
ERROR: storage class should be at the beginning of the declaration
#19: FILE: linux-user/strace.c:66:
+UNUSED static void print_timezone(abi_ulong, int);

total: 1 errors, 0 warnings, 33 lines checked

Patch 2/8 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

3/8 Checking commit 0f5e8ed953bf (linux-user/strace: Improve settimeofday())
4/8 Checking commit 2abd31260722 (linux-user/syscall: Introduce target_sockaddr_nl)
5/8 Checking commit 073f6fdfe338 (linux-user/strace: Dump AF_NETLINK sockaddr content)
6/8 Checking commit 6523a43281c4 (linux-user/strace: Add print_sockfd())
7/8 Checking commit 4c7df4b3b8c7 (linux-user/strace: Improve bind() output)
8/8 Checking commit d2015e24e08c (linux-user/strace: Let print_sockaddr() have a 'last' argument)
ERROR: storage class should be at the beginning of the declaration
#22: FILE: linux-user/strace.c:70:
+UNUSED static void print_sockaddr(abi_ulong addr, abi_long addrlen, int);

total: 1 errors, 0 warnings, 40 lines checked

Patch 8/8 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20190908061543.25136-1-f4bug@amsat.org/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com