tests/Makefile: Do not print the name of the check-block.sh shell script

[Qemu-devel] [PATCH] tests/Makefile: Do not print the name of the check-block.sh shell script

Posted by Thomas Huth 4 years, 7 months ago

The check script is already printing out which iotest is currently
running, so printing out the name of the check-block.sh shell script
looks superfluous here.

Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 tests/Makefile.include | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/Makefile.include b/tests/Makefile.include
index f5ac09549c..a36317ac87 100644
--- a/tests/Makefile.include
+++ b/tests/Makefile.include
@@ -1097,7 +1097,7 @@ QEMU_IOTESTS_HELPERS-$(call land,$(CONFIG_SOFTMMU),$(CONFIG_LINUX)) = tests/qemu
 check-tests/check-block.sh: tests/check-block.sh qemu-img$(EXESUF) \
 		qemu-io$(EXESUF) qemu-nbd$(EXESUF) $(QEMU_IOTESTS_HELPERS-y) \
 		$(patsubst %,%/all,$(filter %-softmmu,$(TARGET_DIRS)))
-	$<
+	@$<
 
 .PHONY: $(patsubst %, check-%, $(check-qapi-schema-y))
 $(patsubst %, check-%, $(check-qapi-schema-y)): check-%.json: $(SRC_PATH)/%.json
-- 
2.18.1

Re: [Qemu-devel] [PATCH] tests/Makefile: Do not print the name of the check-block.sh shell script

Posted by John Snow 4 years, 7 months ago


On 9/6/19 7:35 AM, Thomas Huth wrote:
> The check script is already printing out which iotest is currently
> running, so printing out the name of the check-block.sh shell script
> looks superfluous here.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>

Makes sense.

Acked-by: John Snow <jsnow@redhat.com>

> ---
>  tests/Makefile.include | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/Makefile.include b/tests/Makefile.include
> index f5ac09549c..a36317ac87 100644
> --- a/tests/Makefile.include
> +++ b/tests/Makefile.include
> @@ -1097,7 +1097,7 @@ QEMU_IOTESTS_HELPERS-$(call land,$(CONFIG_SOFTMMU),$(CONFIG_LINUX)) = tests/qemu
>  check-tests/check-block.sh: tests/check-block.sh qemu-img$(EXESUF) \
>  		qemu-io$(EXESUF) qemu-nbd$(EXESUF) $(QEMU_IOTESTS_HELPERS-y) \
>  		$(patsubst %,%/all,$(filter %-softmmu,$(TARGET_DIRS)))
> -	$<
> +	@$<
>  
>  .PHONY: $(patsubst %, check-%, $(check-qapi-schema-y))
>  $(patsubst %, check-%, $(check-qapi-schema-y)): check-%.json: $(SRC_PATH)/%.json
>

Re: [Qemu-devel] [PATCH] tests/Makefile: Do not print the name of the check-block.sh shell script

Posted by Max Reitz 4 years, 7 months ago

On 06.09.19 13:35, Thomas Huth wrote:
> The check script is already printing out which iotest is currently
> running, so printing out the name of the check-block.sh shell script
> looks superfluous here.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>  tests/Makefile.include | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Max Reitz <mreitz@redhat.com>

(Not sure which tree you’d like this to go through...)

Re: [Qemu-devel] [PATCH] tests/Makefile: Do not print the name of the check-block.sh shell script

Posted by Thomas Huth 4 years, 7 months ago

On 10/09/2019 12.53, Max Reitz wrote:
> On 06.09.19 13:35, Thomas Huth wrote:
>> The check script is already printing out which iotest is currently
>> running, so printing out the name of the check-block.sh shell script
>> looks superfluous here.
>>
>> Signed-off-by: Thomas Huth <thuth@redhat.com>
>> ---
>>  tests/Makefile.include | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Reviewed-by: Max Reitz <mreitz@redhat.com>
> 
> (Not sure which tree you’d like this to go through...)

I think either your block tree or trivial would be appropriate?

 Thomas

Re: [Qemu-devel] [PATCH] tests/Makefile: Do not print the name of the check-block.sh shell script

Posted by Max Reitz 4 years, 7 months ago

On 10.09.19 12:55, Thomas Huth wrote:
> On 10/09/2019 12.53, Max Reitz wrote:
>> On 06.09.19 13:35, Thomas Huth wrote:
>>> The check script is already printing out which iotest is currently
>>> running, so printing out the name of the check-block.sh shell script
>>> looks superfluous here.
>>>
>>> Signed-off-by: Thomas Huth <thuth@redhat.com>
>>> ---
>>>  tests/Makefile.include | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> Reviewed-by: Max Reitz <mreitz@redhat.com>
>>
>> (Not sure which tree you’d like this to go through...)
> 
> I think either your block tree or trivial would be appropriate?

OK then, I’ve taken it. :-)

Max