[Qemu-devel] [PATCH] travis.yml: Install libcap-dev for testing virito-9p

Thomas Huth posted 1 patch 4 years, 7 months ago
Test docker-clang@ubuntu failed
Test FreeBSD passed
Test checkpatch passed
Test docker-mingw@fedora passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20190905113346.2473-1-thuth@redhat.com
Maintainers: "Philippe Mathieu-Daudé" <philmd@redhat.com>, "Alex Bennée" <alex.bennee@linaro.org>, Fam Zheng <fam@euphon.net>
.travis.yml | 1 +
1 file changed, 1 insertion(+)
[Qemu-devel] [PATCH] travis.yml: Install libcap-dev for testing virito-9p
Posted by Thomas Huth 4 years, 7 months ago
So far we were not testing virtio-9p in Travis yet, since we forgot to
install libcap-devel. Do it now to get some more test coverage.

Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 .travis.yml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/.travis.yml b/.travis.yml
index 92b00927d4..1d46442020 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -15,6 +15,7 @@ addons:
       - libaio-dev
       - libattr1-dev
       - libbrlapi-dev
+      - libcap-dev
       - libcap-ng-dev
       - libgcc-4.8-dev
       - libgnutls-dev
-- 
2.18.1


Re: [Qemu-devel] [PATCH] travis.yml: Install libcap-dev for testing virito-9p
Posted by Philippe Mathieu-Daudé 4 years, 7 months ago
"virito-9p" -> "virtio-9p" in subject

On 9/5/19 1:33 PM, Thomas Huth wrote:
> So far we were not testing virtio-9p in Travis yet, since we forgot to
> install libcap-devel. Do it now to get some more test coverage.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>  .travis.yml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/.travis.yml b/.travis.yml
> index 92b00927d4..1d46442020 100644
> --- a/.travis.yml
> +++ b/.travis.yml
> @@ -15,6 +15,7 @@ addons:
>        - libaio-dev
>        - libattr1-dev
>        - libbrlapi-dev
> +      - libcap-dev
>        - libcap-ng-dev
>        - libgcc-4.8-dev
>        - libgnutls-dev
> 

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>

Re: [Qemu-devel] [PATCH] travis.yml: Install libcap-dev for testing virito-9p
Posted by Greg Kurz 4 years, 7 months ago
On Thu,  5 Sep 2019 13:33:46 +0200
Thomas Huth <thuth@redhat.com> wrote:

> So far we were not testing virtio-9p in Travis yet, since we forgot to
> install libcap-devel. Do it now to get some more test coverage.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---

Acked-by: Greg Kurz <groug@kaod.org>

and

Tested-by: Greg Kurz <groug@kaod.org>

Whose tree is this going through BTW ?

>  .travis.yml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/.travis.yml b/.travis.yml
> index 92b00927d4..1d46442020 100644
> --- a/.travis.yml
> +++ b/.travis.yml
> @@ -15,6 +15,7 @@ addons:
>        - libaio-dev
>        - libattr1-dev
>        - libbrlapi-dev
> +      - libcap-dev
>        - libcap-ng-dev
>        - libgcc-4.8-dev
>        - libgnutls-dev


Re: [Qemu-devel] [PATCH] travis.yml: Install libcap-dev for testing virito-9p
Posted by Thomas Huth 4 years, 7 months ago
On 05/09/2019 14.07, Greg Kurz wrote:
> On Thu,  5 Sep 2019 13:33:46 +0200
> Thomas Huth <thuth@redhat.com> wrote:
> 
>> So far we were not testing virtio-9p in Travis yet, since we forgot to
>> install libcap-devel. Do it now to get some more test coverage.
>>
>> Signed-off-by: Thomas Huth <thuth@redhat.com>
>> ---
> 
> Acked-by: Greg Kurz <groug@kaod.org>
> 
> and
> 
> Tested-by: Greg Kurz <groug@kaod.org>
> 
> Whose tree is this going through BTW ?

According to MAINTAINERS, .travis.yml is taken care of by Alex and Fam,
so I hope they will pick this patch up. Otherwise, I think it could also
go via trivial (now on CC: ), since it's just a one-liner.

 Thomas

Re: [Qemu-devel] [PATCH] travis.yml: Install libcap-dev for testing virito-9p
Posted by Alex Bennée 4 years, 7 months ago
Thomas Huth <thuth@redhat.com> writes:

> On 05/09/2019 14.07, Greg Kurz wrote:
>> On Thu,  5 Sep 2019 13:33:46 +0200
>> Thomas Huth <thuth@redhat.com> wrote:
>>
>>> So far we were not testing virtio-9p in Travis yet, since we forgot to
>>> install libcap-devel. Do it now to get some more test coverage.
>>>
>>> Signed-off-by: Thomas Huth <thuth@redhat.com>
>>> ---
>>
>> Acked-by: Greg Kurz <groug@kaod.org>
>>
>> and
>>
>> Tested-by: Greg Kurz <groug@kaod.org>
>>
>> Whose tree is this going through BTW ?
>
> According to MAINTAINERS, .travis.yml is taken care of by Alex and Fam,
> so I hope they will pick this patch up. Otherwise, I think it could also
> go via trivial (now on CC: ), since it's just a one-liner.

Sure I'll grab it for the next iteration of testing/next - the queue is
quite full at the moment.


--
Alex Bennée

Re: [Qemu-devel] [PATCH] travis.yml: Install libcap-dev for testing virito-9p
Posted by Greg Kurz 4 years, 7 months ago
On Thu, 5 Sep 2019 14:07:01 +0200
Greg Kurz <groug@kaod.org> wrote:

> On Thu,  5 Sep 2019 13:33:46 +0200
> Thomas Huth <thuth@redhat.com> wrote:
> 
> > So far we were not testing virtio-9p in Travis yet, since we forgot to
> > install libcap-devel. Do it now to get some more test coverage.
> > 
> > Signed-off-by: Thomas Huth <thuth@redhat.com>
> > ---
> 
> Acked-by: Greg Kurz <groug@kaod.org>
> 

Hmm... shouldn't libcap-dev be added in the "Acceptance (Functional) tests"
section as well, near line 260 ?

> and
> 
> Tested-by: Greg Kurz <groug@kaod.org>
> 
> Whose tree is this going through BTW ?
> 
> >  .travis.yml | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/.travis.yml b/.travis.yml
> > index 92b00927d4..1d46442020 100644
> > --- a/.travis.yml
> > +++ b/.travis.yml
> > @@ -15,6 +15,7 @@ addons:
> >        - libaio-dev
> >        - libattr1-dev
> >        - libbrlapi-dev
> > +      - libcap-dev
> >        - libcap-ng-dev
> >        - libgcc-4.8-dev
> >        - libgnutls-dev
> 


Re: [Qemu-devel] [PATCH] travis.yml: Install libcap-dev for testing virito-9p
Posted by Thomas Huth 4 years, 7 months ago
On 05/09/2019 14.18, Greg Kurz wrote:
> On Thu, 5 Sep 2019 14:07:01 +0200
> Greg Kurz <groug@kaod.org> wrote:
> 
>> On Thu,  5 Sep 2019 13:33:46 +0200
>> Thomas Huth <thuth@redhat.com> wrote:
>>
>>> So far we were not testing virtio-9p in Travis yet, since we forgot to
>>> install libcap-devel. Do it now to get some more test coverage.
>>>
>>> Signed-off-by: Thomas Huth <thuth@redhat.com>
>>> ---
>>
>> Acked-by: Greg Kurz <groug@kaod.org>
>>
> 
> Hmm... shouldn't libcap-dev be added in the "Acceptance (Functional) tests"
> section as well, near line 260 ?

Unless there is a test for 9p in the "check-acceptance" suite, it likely
does not make a difference - 9p would just get built one more additional
time, but it won't be tested afterwards.

 Thomas