gitlab-ci.yml: Install libattr1-dev and libcap-dev to test virtio-9p

[Qemu-devel] [PATCH] gitlab-ci.yml: Install libattr1-dev and libcap-dev to test virtio-9p

Posted by Thomas Huth 4 years, 7 months ago

So far the gitlab-ci was not testing virtio-9p yet, since we did not
install libattr1-dev and libcap-dev in any of the pipelines. Do it
now to get some more test coverage.

Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 .gitlab-ci.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index cd4c03372b..ed8067f5cf 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -59,7 +59,7 @@ build-user:
 
 build-clang:
  script:
- - apt-get install -y -qq clang libsdl2-dev
+ - apt-get install -y -qq clang libsdl2-dev libattr1-dev libcap-dev
       xfslibs-dev libiscsi-dev libnfs-dev libseccomp-dev gnutls-dev librbd-dev
  - ./configure --cc=clang --cxx=clang++ --enable-werror
       --target-list="alpha-softmmu arm-softmmu m68k-softmmu mips64-softmmu
-- 
2.18.1

Re: [Qemu-devel] [PATCH] gitlab-ci.yml: Install libattr1-dev and libcap-dev to test virtio-9p

Posted by Greg Kurz 4 years, 7 months ago

On Thu,  5 Sep 2019 13:17:29 +0200
Thomas Huth <thuth@redhat.com> wrote:

> So far the gitlab-ci was not testing virtio-9p yet, since we did not
> install libattr1-dev and libcap-dev in any of the pipelines. Do it
> now to get some more test coverage.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>  .gitlab-ci.yml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
> index cd4c03372b..ed8067f5cf 100644
> --- a/.gitlab-ci.yml
> +++ b/.gitlab-ci.yml
> @@ -59,7 +59,7 @@ build-user:
>  
>  build-clang:
>   script:
> - - apt-get install -y -qq clang libsdl2-dev
> + - apt-get install -y -qq clang libsdl2-dev libattr1-dev libcap-dev
>        xfslibs-dev libiscsi-dev libnfs-dev libseccomp-dev gnutls-dev librbd-dev
>   - ./configure --cc=clang --cxx=clang++ --enable-werror
>        --target-list="alpha-softmmu arm-softmmu m68k-softmmu mips64-softmmu

I don't know gitlab-ci at all but shouldn't these libs be added to some
other builds as well ?

Apart from that, this change looks okay so:

Acked-by: Greg Kurz <groug@kaod.org>

Re: [Qemu-devel] [PATCH] gitlab-ci.yml: Install libattr1-dev and libcap-dev to test virtio-9p

Posted by Thomas Huth 4 years, 7 months ago

On 05/09/2019 14.21, Greg Kurz wrote:
> On Thu,  5 Sep 2019 13:17:29 +0200
> Thomas Huth <thuth@redhat.com> wrote:
> 
>> So far the gitlab-ci was not testing virtio-9p yet, since we did not
>> install libattr1-dev and libcap-dev in any of the pipelines. Do it
>> now to get some more test coverage.
>>
>> Signed-off-by: Thomas Huth <thuth@redhat.com>
>> ---
>>  .gitlab-ci.yml | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
>> index cd4c03372b..ed8067f5cf 100644
>> --- a/.gitlab-ci.yml
>> +++ b/.gitlab-ci.yml
>> @@ -59,7 +59,7 @@ build-user:
>>  
>>  build-clang:
>>   script:
>> - - apt-get install -y -qq clang libsdl2-dev
>> + - apt-get install -y -qq clang libsdl2-dev libattr1-dev libcap-dev
>>        xfslibs-dev libiscsi-dev libnfs-dev libseccomp-dev gnutls-dev librbd-dev
>>   - ./configure --cc=clang --cxx=clang++ --enable-werror
>>        --target-list="alpha-softmmu arm-softmmu m68k-softmmu mips64-softmmu
> 
> I don't know gitlab-ci at all but shouldn't these libs be added to some
> other builds as well ?

Currently the "features" are distributed over the different pipelines,
so that the build in total does not take too long. Looking at how long
the travis stuff takes, I'd also like to try to keep it short here.

 Thomas