warn(3), warnx(3), err(3), and errx(3) print to stderr even when the --syslog
option was given.  In this case messages to stderr are likely to be lost and
this makes troubleshooting hard.  Use "fuse_log.h" APIs instead of <err.h>.

Stefan Hajnoczi (2):
  virtiofsd: replace warn(3) and warnx(3) with fuse_warning()
  virtiofsd: replace err(3) and errx(3) with fuse_err()

 contrib/virtiofsd/passthrough_ll.c | 143 ++++++++++++++++++-----------
 contrib/virtiofsd/seccomp.c        |  15 ++-
 2 files changed, 99 insertions(+), 59 deletions(-)

-- 
2.21.0

* Stefan Hajnoczi (stefanha@redhat.com) wrote:
> warn(3), warnx(3), err(3), and errx(3) print to stderr even when the --syslog
> option was given.  In this case messages to stderr are likely to be lost and
> this makes troubleshooting hard.  Use "fuse_log.h" APIs instead of <err.h>.
> 
> Stefan Hajnoczi (2):
>   virtiofsd: replace warn(3) and warnx(3) with fuse_warning()
>   virtiofsd: replace err(3) and errx(3) with fuse_err()
> 
>  contrib/virtiofsd/passthrough_ll.c | 143 ++++++++++++++++++-----------
>  contrib/virtiofsd/seccomp.c        |  15 ++-
>  2 files changed, 99 insertions(+), 59 deletions(-)

Thanks, I've added these to my world; although I'll probably squash them
down heavily into the original commits.

Dave

> -- 
> 2.21.0
> 
> _______________________________________________
> Virtio-fs mailing list
> Virtio-fs@redhat.com
> https://www.redhat.com/mailman/listinfo/virtio-fs
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK

Hi Stefan,

On 9/5/19 10:29 AM, Stefan Hajnoczi wrote:
> warn(3), warnx(3), err(3), and errx(3) print to stderr even when the --syslog
> option was given.  In this case messages to stderr are likely to be lost and
> this makes troubleshooting hard.  Use "fuse_log.h" APIs instead of <err.h>.
> 
> Stefan Hajnoczi (2):
>   virtiofsd: replace warn(3) and warnx(3) with fuse_warning()
>   virtiofsd: replace err(3) and errx(3) with fuse_err()

Is this a straight RESEND or are there any changes in this series?

I'm asking because IIRC your first series had:
- Reviewed-by: Jun Piao <piaojun@huawei.com>
- Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>

If this isn't a RESEND then I'll review it again.

Thanks,

Phil.

* Philippe Mathieu-Daudé (philmd@redhat.com) wrote:
> Hi Stefan,
> 
> On 9/5/19 10:29 AM, Stefan Hajnoczi wrote:
> > warn(3), warnx(3), err(3), and errx(3) print to stderr even when the --syslog
> > option was given.  In this case messages to stderr are likely to be lost and
> > this makes troubleshooting hard.  Use "fuse_log.h" APIs instead of <err.h>.
> > 
> > Stefan Hajnoczi (2):
> >   virtiofsd: replace warn(3) and warnx(3) with fuse_warning()
> >   virtiofsd: replace err(3) and errx(3) with fuse_err()
> 
> Is this a straight RESEND or are there any changes in this series?
> 
> I'm asking because IIRC your first series had:
> - Reviewed-by: Jun Piao <piaojun@huawei.com>
> - Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> 
> If this isn't a RESEND then I'll review it again.

I'll pick those reviews up.

Dave

> Thanks,
> 
> Phil.
> 
> _______________________________________________
> Virtio-fs mailing list
> Virtio-fs@redhat.com
> https://www.redhat.com/mailman/listinfo/virtio-fs
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK