[Qemu-devel] [PATCH v1 00/42] current testing/next queue (podman, docker, ci)

Alex Bennée posted 42 patches 4 years, 7 months ago
Test docker-clang@ubuntu failed
Test FreeBSD passed
Test checkpatch failed
Test docker-mingw@fedora passed
Failed in applying to current master (apply log)
.travis.yml                                   |  39 ++-
Makefile                                      |   1 +
Makefile.target                               |   3 -
configure                                     | 168 ++-----------
hw/misc/Makefile.objs                         |  90 +++----
qemu-doc.texi                                 |   6 +-
tests/Makefile.include                        |  25 +-
tests/acceptance/boot_linux_console.py        |  25 +-
tests/acceptance/linux_initrd.py              |   5 +-
tests/docker/Makefile.include                 |  61 +++--
tests/docker/common.rc                        |   4 +
tests/docker/docker.py                        |  51 ++--
.../dockerfiles/debian-alpha-cross.docker     |   7 +-
.../dockerfiles/debian-amd64-cross.docker     |  22 ++
.../dockerfiles/debian-arm64-cross.docker     |   7 +-
.../dockerfiles/debian-armel-cross.docker     |   3 +-
.../dockerfiles/debian-armhf-cross.docker     |   3 +-
.../debian-buster-arm64-cross.docker          |  16 --
.../dockerfiles/debian-hppa-cross.docker      |   5 +-
.../dockerfiles/debian-m68k-cross.docker      |   5 +-
.../dockerfiles/debian-mips-cross.docker      |   7 +-
.../dockerfiles/debian-mips64-cross.docker    |   5 +-
.../dockerfiles/debian-mips64el-cross.docker  |   3 +-
.../dockerfiles/debian-mipsel-cross.docker    |   2 +-
.../dockerfiles/debian-powerpc-cross.docker   |   8 +-
.../debian-powerpc-user-cross.docker          |  15 --
.../dockerfiles/debian-ppc64-cross.docker     |   7 +-
.../dockerfiles/debian-ppc64el-cross.docker   |   3 +-
.../dockerfiles/debian-riscv64-cross.docker   |   5 +-
.../dockerfiles/debian-s390x-cross.docker     |   3 +-
.../dockerfiles/debian-sh4-cross.docker       |   5 +-
tests/docker/dockerfiles/debian-sid.docker    |  41 ---
.../dockerfiles/debian-sparc64-cross.docker   |   5 +-
tests/docker/dockerfiles/ubuntu1804.docker    |   3 +
tests/docker/run                              |   4 +-
tests/docker/test-build                       |   1 -
tests/docker/test-mingw                       |   1 -
tests/docker/test-quick                       |   1 -
tests/tcg/.gitignore                          |   5 +
tests/tcg/Makefile.include                    |  88 -------
tests/tcg/Makefile.prereqs                    |  18 ++
tests/tcg/Makefile.probe                      |  31 ---
tests/tcg/Makefile.qemu                       |  95 +++++++
tests/tcg/{Makefile => Makefile.target}       |  15 +-
tests/tcg/aarch64/Makefile.include            |   8 -
tests/tcg/aarch64/Makefile.softmmu-target     |   4 +-
tests/tcg/aarch64/Makefile.target             |  12 +-
tests/tcg/alpha/Makefile.include              |   2 -
tests/tcg/alpha/Makefile.softmmu-target       |   4 +-
tests/tcg/arm/Makefile.include                |   8 -
tests/tcg/arm/Makefile.softmmu-target         |   6 +-
tests/tcg/configure.sh                        | 234 ++++++++++++++++++
tests/tcg/cris/Makefile.include               |   6 -
tests/tcg/hppa/Makefile.include               |   2 -
tests/tcg/i386/Makefile.include               |   9 -
tests/tcg/i386/Makefile.softmmu-target        |  12 +-
tests/tcg/i386/Makefile.target                |  13 +-
tests/tcg/m68k/Makefile.include               |   2 -
tests/tcg/minilib/Makefile.target             |   2 +-
tests/tcg/mips/Makefile.include               |  20 --
tests/tcg/ppc/Makefile.include                |  10 -
tests/tcg/riscv/Makefile.include              |  10 -
tests/tcg/s390x/Makefile.include              |   2 -
tests/tcg/sh4/Makefile.include                |   4 -
tests/tcg/sparc64/Makefile.include            |   2 -
tests/tcg/x86_64/Makefile.softmmu-target      |  36 +++
tests/tcg/x86_64/Makefile.target              |   7 +-
tests/tcg/xtensa/Makefile.include             |  11 -
tests/tcg/xtensa/Makefile.softmmu-target      |   4 +-
tests/vm/fedora                               |   2 +-
70 files changed, 693 insertions(+), 656 deletions(-)
create mode 100644 tests/docker/dockerfiles/debian-amd64-cross.docker
delete mode 100644 tests/docker/dockerfiles/debian-buster-arm64-cross.docker
delete mode 100644 tests/docker/dockerfiles/debian-powerpc-user-cross.docker
delete mode 100644 tests/docker/dockerfiles/debian-sid.docker
create mode 100644 tests/tcg/.gitignore
delete mode 100644 tests/tcg/Makefile.include
create mode 100644 tests/tcg/Makefile.prereqs
delete mode 100644 tests/tcg/Makefile.probe
create mode 100644 tests/tcg/Makefile.qemu
rename tests/tcg/{Makefile => Makefile.target} (90%)
delete mode 100644 tests/tcg/aarch64/Makefile.include
delete mode 100644 tests/tcg/alpha/Makefile.include
delete mode 100644 tests/tcg/arm/Makefile.include
create mode 100755 tests/tcg/configure.sh
delete mode 100644 tests/tcg/cris/Makefile.include
delete mode 100644 tests/tcg/hppa/Makefile.include
delete mode 100644 tests/tcg/i386/Makefile.include
delete mode 100644 tests/tcg/m68k/Makefile.include
delete mode 100644 tests/tcg/mips/Makefile.include
delete mode 100644 tests/tcg/ppc/Makefile.include
delete mode 100644 tests/tcg/riscv/Makefile.include
delete mode 100644 tests/tcg/s390x/Makefile.include
delete mode 100644 tests/tcg/sh4/Makefile.include
delete mode 100644 tests/tcg/sparc64/Makefile.include
create mode 100644 tests/tcg/x86_64/Makefile.softmmu-target
delete mode 100644 tests/tcg/xtensa/Makefile.include
[Qemu-devel] [PATCH v1 00/42] current testing/next queue (podman, docker, ci)
Posted by Alex Bennée 4 years, 7 months ago
Hi All,

Here is the current status of my testing/next queue. It brings
together a number of different series as well as some CI fixes that
may be coming in view different trees. So in order we have:

Some fixes to for podman. This is a relatively new alternative to
docker and it works well but needs a little tweak to ensure we can
also use it from cross compiling check-tcg tests.

Paolo's tcg Makefile disentanglement which reduces some of the
Makefile hackage by having a tcg check specific configure step. I've
made a few minor tweaks to the configure script to fix up -static
handling and setting of make variables.

There is then a set of clean-ups to the dockerfiles whhich allow them
to default a target list in the dockerfile environment which can then
be overridden. I then update a bunch of the images to buster which
allows us to drop the rather hokey sid based approach we were using.

The next major chunk is Phillipe's caching changes which make a
considerable difference when constantly rebuild the same tree,
especially if all you are messing around with is ancillary scripts.

Finally there are a few more CI fixes including one slightly hacky
change to deal with variation in python3 implementations.

Please review ;-)

Alex Bennée (27):
  configure: clean-up container cross compile detect
  tests/docker: fix "cc" command to work with podman
  tests/tcg: add .gitignore for in source builds
  tests/docker: move DEF_TARGET_LIST setting to common.rc
  tests/docker: set DEF_TARGET_LIST for some containers
  tests/docker: add Buster to DOCKER_PARTIAL_IMAGES
  tests/docker: move our arm64 cross compile to Buster
  tests/docker: move our powerpc cross compile to Buster
  tests/docker: move our Alpha cross compile to Buster
  tests/docker: move our HPPA cross compile to Buster
  tests/docker: move our m68k cross compile to Buster
  tests/docker: move our sparc64 cross compile to Buster
  tests/docker: move our sh4 cross compile to Buster
  tests/docker: move our mips64 cross compile to Buster
  tests/docker: move our riscv64 cross compile to Buster
  tests/docker: move our ppc64 cross compile to Buster
  tests/docker: drop debian-sid image
  tests/docker: drop powerpc-user image for QEMU cross builds
  tests/docker: add debian-xtensa-cross to DEBIAN_PARTIAL_IMAGES
  tests/docker: add debian9-mxe to DEBIAN_PARTIAL_IMAGES
  tests/docker: avoid $SHELL invoke bash directly
  tests/docker: add debian-amd64-cross for non-x86 hosts
  tests/docker: use --arch-only for installing deps
  tests/docker: add more images to PARTIAL_IMAGES when not on x86_64
  configure: check if --no-pie is supported first
  tests/docker: --disable-libssh on ubuntu1804 builds
  tests/docker: don't always encoding for subprocess.check_output

Cleber Rosa (1):
  Fedora images: use URLs from stable "archives.fedoraproject.org"

Paolo Bonzini (3):
  tests/tcg: use EXTRA_CFLAGS everywhere
  tests/tcg: cleanup Makefile inclusions
  tests/tcg: move configuration to a sub-shell script

Philippe Mathieu-Daudé (10):
  .travis.yml: Enable multiple caching features
  .travis.yml: Increase cache timeout from 3min to 20min
  .travis.yml: Cache Python PIP packages
  .travis.yml: Cache Avocado cache
  .travis.yml: Improve ccache use
  .travis.yml: Enable ccache on OSX
  .travis.yml: Document how the build matrix use caches
  .travis.yml: Cache Linux/GCC 'debug profile' jobs together
  .travis.yml: Cache Linux/GCC 'non-debug profile' jobs together
  .travis.yml: Cache Linux/Clang jobs together

Thomas Huth (1):
  hw/misc: Mark most objects as "common" code to speed up compilation a
    litte bit

 .travis.yml                                   |  39 ++-
 Makefile                                      |   1 +
 Makefile.target                               |   3 -
 configure                                     | 168 ++-----------
 hw/misc/Makefile.objs                         |  90 +++----
 qemu-doc.texi                                 |   6 +-
 tests/Makefile.include                        |  25 +-
 tests/acceptance/boot_linux_console.py        |  25 +-
 tests/acceptance/linux_initrd.py              |   5 +-
 tests/docker/Makefile.include                 |  61 +++--
 tests/docker/common.rc                        |   4 +
 tests/docker/docker.py                        |  51 ++--
 .../dockerfiles/debian-alpha-cross.docker     |   7 +-
 .../dockerfiles/debian-amd64-cross.docker     |  22 ++
 .../dockerfiles/debian-arm64-cross.docker     |   7 +-
 .../dockerfiles/debian-armel-cross.docker     |   3 +-
 .../dockerfiles/debian-armhf-cross.docker     |   3 +-
 .../debian-buster-arm64-cross.docker          |  16 --
 .../dockerfiles/debian-hppa-cross.docker      |   5 +-
 .../dockerfiles/debian-m68k-cross.docker      |   5 +-
 .../dockerfiles/debian-mips-cross.docker      |   7 +-
 .../dockerfiles/debian-mips64-cross.docker    |   5 +-
 .../dockerfiles/debian-mips64el-cross.docker  |   3 +-
 .../dockerfiles/debian-mipsel-cross.docker    |   2 +-
 .../dockerfiles/debian-powerpc-cross.docker   |   8 +-
 .../debian-powerpc-user-cross.docker          |  15 --
 .../dockerfiles/debian-ppc64-cross.docker     |   7 +-
 .../dockerfiles/debian-ppc64el-cross.docker   |   3 +-
 .../dockerfiles/debian-riscv64-cross.docker   |   5 +-
 .../dockerfiles/debian-s390x-cross.docker     |   3 +-
 .../dockerfiles/debian-sh4-cross.docker       |   5 +-
 tests/docker/dockerfiles/debian-sid.docker    |  41 ---
 .../dockerfiles/debian-sparc64-cross.docker   |   5 +-
 tests/docker/dockerfiles/ubuntu1804.docker    |   3 +
 tests/docker/run                              |   4 +-
 tests/docker/test-build                       |   1 -
 tests/docker/test-mingw                       |   1 -
 tests/docker/test-quick                       |   1 -
 tests/tcg/.gitignore                          |   5 +
 tests/tcg/Makefile.include                    |  88 -------
 tests/tcg/Makefile.prereqs                    |  18 ++
 tests/tcg/Makefile.probe                      |  31 ---
 tests/tcg/Makefile.qemu                       |  95 +++++++
 tests/tcg/{Makefile => Makefile.target}       |  15 +-
 tests/tcg/aarch64/Makefile.include            |   8 -
 tests/tcg/aarch64/Makefile.softmmu-target     |   4 +-
 tests/tcg/aarch64/Makefile.target             |  12 +-
 tests/tcg/alpha/Makefile.include              |   2 -
 tests/tcg/alpha/Makefile.softmmu-target       |   4 +-
 tests/tcg/arm/Makefile.include                |   8 -
 tests/tcg/arm/Makefile.softmmu-target         |   6 +-
 tests/tcg/configure.sh                        | 234 ++++++++++++++++++
 tests/tcg/cris/Makefile.include               |   6 -
 tests/tcg/hppa/Makefile.include               |   2 -
 tests/tcg/i386/Makefile.include               |   9 -
 tests/tcg/i386/Makefile.softmmu-target        |  12 +-
 tests/tcg/i386/Makefile.target                |  13 +-
 tests/tcg/m68k/Makefile.include               |   2 -
 tests/tcg/minilib/Makefile.target             |   2 +-
 tests/tcg/mips/Makefile.include               |  20 --
 tests/tcg/ppc/Makefile.include                |  10 -
 tests/tcg/riscv/Makefile.include              |  10 -
 tests/tcg/s390x/Makefile.include              |   2 -
 tests/tcg/sh4/Makefile.include                |   4 -
 tests/tcg/sparc64/Makefile.include            |   2 -
 tests/tcg/x86_64/Makefile.softmmu-target      |  36 +++
 tests/tcg/x86_64/Makefile.target              |   7 +-
 tests/tcg/xtensa/Makefile.include             |  11 -
 tests/tcg/xtensa/Makefile.softmmu-target      |   4 +-
 tests/vm/fedora                               |   2 +-
 70 files changed, 693 insertions(+), 656 deletions(-)
 create mode 100644 tests/docker/dockerfiles/debian-amd64-cross.docker
 delete mode 100644 tests/docker/dockerfiles/debian-buster-arm64-cross.docker
 delete mode 100644 tests/docker/dockerfiles/debian-powerpc-user-cross.docker
 delete mode 100644 tests/docker/dockerfiles/debian-sid.docker
 create mode 100644 tests/tcg/.gitignore
 delete mode 100644 tests/tcg/Makefile.include
 create mode 100644 tests/tcg/Makefile.prereqs
 delete mode 100644 tests/tcg/Makefile.probe
 create mode 100644 tests/tcg/Makefile.qemu
 rename tests/tcg/{Makefile => Makefile.target} (90%)
 delete mode 100644 tests/tcg/aarch64/Makefile.include
 delete mode 100644 tests/tcg/alpha/Makefile.include
 delete mode 100644 tests/tcg/arm/Makefile.include
 create mode 100755 tests/tcg/configure.sh
 delete mode 100644 tests/tcg/cris/Makefile.include
 delete mode 100644 tests/tcg/hppa/Makefile.include
 delete mode 100644 tests/tcg/i386/Makefile.include
 delete mode 100644 tests/tcg/m68k/Makefile.include
 delete mode 100644 tests/tcg/mips/Makefile.include
 delete mode 100644 tests/tcg/ppc/Makefile.include
 delete mode 100644 tests/tcg/riscv/Makefile.include
 delete mode 100644 tests/tcg/s390x/Makefile.include
 delete mode 100644 tests/tcg/sh4/Makefile.include
 delete mode 100644 tests/tcg/sparc64/Makefile.include
 create mode 100644 tests/tcg/x86_64/Makefile.softmmu-target
 delete mode 100644 tests/tcg/xtensa/Makefile.include

-- 
2.20.1


Re: [Qemu-devel] [PATCH v1 00/42] current testing/next queue (podman, docker, ci)
Posted by no-reply@patchew.org 4 years, 7 months ago
Patchew URL: https://patchew.org/QEMU/20190904203013.9028-1-alex.bennee@linaro.org/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Subject: [Qemu-devel] [PATCH  v1 00/42] current testing/next queue (podman, docker, ci)
Message-id: 20190904203013.9028-1-alex.bennee@linaro.org

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
0fbbd2b tests/docker: don't always encoding for subprocess.check_output
5b2ad81 tests/docker: --disable-libssh on ubuntu1804 builds
c3ee1ae Fedora images: use URLs from stable "archives.fedoraproject.org"
942403a .travis.yml: Cache Linux/Clang jobs together
5e27a63 .travis.yml: Cache Linux/GCC 'non-debug profile' jobs together
eb3387c .travis.yml: Cache Linux/GCC 'debug profile' jobs together
b88f2bb .travis.yml: Document how the build matrix use caches
a655c67 .travis.yml: Enable ccache on OSX
5ffee09 .travis.yml: Improve ccache use
aff75d2 .travis.yml: Cache Avocado cache
f16c75b .travis.yml: Cache Python PIP packages
0833369 .travis.yml: Increase cache timeout from 3min to 20min
0b7ee1a .travis.yml: Enable multiple caching features
cc73e57 configure: check if --no-pie is supported first
08b9a33 tests/docker: add more images to PARTIAL_IMAGES when not on x86_64
5cc1f1f tests/docker: use --arch-only for installing deps
0134450 tests/docker: add debian-amd64-cross for non-x86 hosts
2a70b8d tests/docker: avoid $SHELL invoke bash directly
3d28ab1 tests/docker: add debian9-mxe to DEBIAN_PARTIAL_IMAGES
324696f tests/docker: add debian-xtensa-cross to DEBIAN_PARTIAL_IMAGES
c465faa tests/docker: drop powerpc-user image for QEMU cross builds
213eeb6 tests/docker: drop debian-sid image
9f2f21c tests/docker: move our ppc64 cross compile to Buster
f898a09 tests/docker: move our riscv64 cross compile to Buster
a60a7b9 tests/docker: move our mips64 cross compile to Buster
2e05203 tests/docker: move our sh4 cross compile to Buster
dbcdf48 tests/docker: move our sparc64 cross compile to Buster
1c3befa tests/docker: move our m68k cross compile to Buster
654bcae tests/docker: move our HPPA cross compile to Buster
0e725a4 tests/docker: move our Alpha cross compile to Buster
ca3a13e tests/docker: move our powerpc cross compile to Buster
b92b820 tests/docker: move our arm64 cross compile to Buster
388f703 tests/docker: add Buster to DOCKER_PARTIAL_IMAGES
102d04a tests/docker: set DEF_TARGET_LIST for some containers
fc29026 tests/docker: move DEF_TARGET_LIST setting to common.rc
56cd636 tests/tcg: add .gitignore for in source builds
3bad540 tests/tcg: move configuration to a sub-shell script
5f89352 tests/tcg: cleanup Makefile inclusions
e9af276 tests/tcg: use EXTRA_CFLAGS everywhere
dac6b94 tests/docker: fix "cc" command to work with podman
eefeff4 configure: clean-up container cross compile detect
1cd7a8b hw/misc: Mark most objects as "common" code to speed up compilation a litte bit

=== OUTPUT BEGIN ===
1/42 Checking commit 1cd7a8bf605d (hw/misc: Mark most objects as "common" code to speed up compilation a litte bit)
2/42 Checking commit eefeff4f57f7 (configure: clean-up container cross compile detect)
3/42 Checking commit dac6b9434eb1 (tests/docker: fix "cc" command to work with podman)
4/42 Checking commit e9af276e922a (tests/tcg: use EXTRA_CFLAGS everywhere)
5/42 Checking commit 5f89352ea324 (tests/tcg: cleanup Makefile inclusions)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#84: 
rename from tests/tcg/Makefile.probe

total: 0 errors, 1 warnings, 341 lines checked

Patch 5/42 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
6/42 Checking commit 3bad54027509 (tests/tcg: move configuration to a sub-shell script)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#706: 
deleted file mode 100644

WARNING: line over 80 characters
#920: FILE: tests/tcg/configure.sh:174:
+      container_cross_cc=/opt/2018.02/xtensa-dc232b-elf/bin/xtensa-dc232b-elf-gcc

WARNING: line over 80 characters
#926: FILE: tests/tcg/configure.sh:180:
+  echo "# Automatically generated by configure - do not modify" > $config_target_mak

ERROR: line over 90 characters
#953: FILE: tests/tcg/configure.sh:207:
+    if ! do_compiler "$target_compiler" $target_compiler_cflags -o $TMPE $TMPC -static ; then

WARNING: line over 80 characters
#955: FILE: tests/tcg/configure.sh:209:
+      if ! do_compiler "$target_compiler" $target_compiler_cflags -o $TMPE $TMPC ; then

WARNING: line over 80 characters
#968: FILE: tests/tcg/configure.sh:222:
+  if test $got_cross_cc = no && test "$docker" != no && test -n "$container_image"; then

total: 1 errors, 5 warnings, 863 lines checked

Patch 6/42 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

7/42 Checking commit 56cd636ccbbb (tests/tcg: add .gitignore for in source builds)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#14: 
new file mode 100644

total: 0 errors, 1 warnings, 5 lines checked

Patch 7/42 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
8/42 Checking commit fc29026cb47e (tests/docker: move DEF_TARGET_LIST setting to common.rc)
9/42 Checking commit 102d04a5c59a (tests/docker: set DEF_TARGET_LIST for some containers)
10/42 Checking commit 388f70343172 (tests/docker: add Buster to DOCKER_PARTIAL_IMAGES)
11/42 Checking commit b92b82082115 (tests/docker: move our arm64 cross compile to Buster)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#57: 
deleted file mode 100644

total: 0 errors, 1 warnings, 40 lines checked

Patch 11/42 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
12/42 Checking commit ca3a13e95f3c (tests/docker: move our powerpc cross compile to Buster)
13/42 Checking commit 0e725a419d31 (tests/docker: move our Alpha cross compile to Buster)
14/42 Checking commit 654bcae3bead (tests/docker: move our HPPA cross compile to Buster)
15/42 Checking commit 1c3befa14744 (tests/docker: move our m68k cross compile to Buster)
16/42 Checking commit dbcdf486beab (tests/docker: move our sparc64 cross compile to Buster)
17/42 Checking commit 2e0520300fdf (tests/docker: move our sh4 cross compile to Buster)
18/42 Checking commit a60a7b9d64be (tests/docker: move our mips64 cross compile to Buster)
19/42 Checking commit f898a09c7fc6 (tests/docker: move our riscv64 cross compile to Buster)
20/42 Checking commit 9f2f21c480e7 (tests/docker: move our ppc64 cross compile to Buster)
21/42 Checking commit 213eeb6def1e (tests/docker: drop debian-sid image)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#28: 
deleted file mode 100644

total: 0 errors, 1 warnings, 8 lines checked

Patch 21/42 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
22/42 Checking commit c465faafdef8 (tests/docker: drop powerpc-user image for QEMU cross builds)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#35: 
deleted file mode 100644

total: 0 errors, 1 warnings, 14 lines checked

Patch 22/42 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
23/42 Checking commit 324696f9c362 (tests/docker: add debian-xtensa-cross to DEBIAN_PARTIAL_IMAGES)
24/42 Checking commit 3d28ab1cff6e (tests/docker: add debian9-mxe to DEBIAN_PARTIAL_IMAGES)
25/42 Checking commit 2a70b8df701a (tests/docker: avoid $SHELL invoke bash directly)
26/42 Checking commit 01344502cbaa (tests/docker: add debian-amd64-cross for non-x86 hosts)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#32: 
new file mode 100644

total: 0 errors, 1 warnings, 35 lines checked

Patch 26/42 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
27/42 Checking commit 5cc1f1fd5605 (tests/docker: use --arch-only for installing deps)
28/42 Checking commit 08b9a3310119 (tests/docker: add more images to PARTIAL_IMAGES when not on x86_64)
29/42 Checking commit cc73e576887a (configure: check if --no-pie is supported first)
30/42 Checking commit 0b7ee1a3bfea (.travis.yml: Enable multiple caching features)
31/42 Checking commit 083336916ba0 (.travis.yml: Increase cache timeout from 3min to 20min)
32/42 Checking commit f16c75bc40ac (.travis.yml: Cache Python PIP packages)
33/42 Checking commit aff75d22d044 (.travis.yml: Cache Avocado cache)
34/42 Checking commit 5ffee09da795 (.travis.yml: Improve ccache use)
35/42 Checking commit a655c67011d0 (.travis.yml: Enable ccache on OSX)
36/42 Checking commit b88f2bb3bd9b (.travis.yml: Document how the build matrix use caches)
37/42 Checking commit eb3387cf994d (.travis.yml: Cache Linux/GCC 'debug profile' jobs together)
38/42 Checking commit 5e27a63aee94 (.travis.yml: Cache Linux/GCC 'non-debug profile' jobs together)
39/42 Checking commit 942403a1ad9c (.travis.yml: Cache Linux/Clang jobs together)
40/42 Checking commit c3ee1aec4faf (Fedora images: use URLs from stable "archives.fedoraproject.org")
41/42 Checking commit 5b2ad81bb4a1 (tests/docker: --disable-libssh on ubuntu1804 builds)
42/42 Checking commit 0fbbd2b57dd7 (tests/docker: don't always encoding for subprocess.check_output)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20190904203013.9028-1-alex.bennee@linaro.org/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
Re: [Qemu-devel] [PATCH v1 00/42] current testing/next queue (podman, docker, ci)
Posted by Alex Bennée 4 years, 7 months ago
Alex Bennée <alex.bennee@linaro.org> writes:

> Hi All,
>
<snip>
>
> Please review ;-)

The following still need review:

unreviewed - 3bf0fc78ddf - Alex Bennée: configure: check if --no-pie is supported first
unreviewed - 91debbbd08e - Alex Bennée: tests/docker: add more images to PARTIAL_IMAGES when not on x86_64
unreviewed - aea7785222a - Alex Bennée: tests/docker: use --arch-only for installing deps
unreviewed - 01c19df4c75 - Alex Bennée: tests/docker: add debian-amd64-cross for non-x86 hosts
unreviewed - ba90db8ad06 - Alex Bennée: tests/docker: add debian-xtensa-cross to DEBIAN_PARTIAL_IMAGES
unreviewed - 0929a7cb881 - Alex Bennée: tests/docker: drop powerpc-user image for QEMU cross builds
unreviewed - cf2bf8f11b2 - Alex Bennée: tests/docker: drop debian-sid image
unreviewed - 160f58adec6 - Alex Bennée: tests/docker: move our ppc64 cross compile to Buster
unreviewed - a94f07dff2f - Alex Bennée: tests/docker: move our riscv64 cross compile to Buster
unreviewed - 174ab0f54ab - Alex Bennée: tests/docker: move our mips64 cross compile to Buster
unreviewed - a7bd356187e - Alex Bennée: tests/docker: move our sh4 cross compile to Buster
unreviewed - 6747f17e0fb - Alex Bennée: tests/docker: move our sparc64 cross compile to Buster
unreviewed - 1e220361d95 - Alex Bennée: tests/docker: move our m68k cross compile to Buster
unreviewed - 437dafd4044 - Alex Bennée: tests/docker: move our HPPA cross compile to Buster
unreviewed - a846639d89d - Alex Bennée: tests/docker: move our Alpha cross compile to Buster
unreviewed - 6dd1c889393 - Alex Bennée: tests/docker: move our powerpc cross compile to Buster
unreviewed - 3373c3eb84e - Alex Bennée: tests/docker: set DEF_TARGET_LIST for some containers
unreviewed - d14f1b84dc3 - Alex Bennée: tests/tcg: add .gitignore for in source builds
unreviewed - 659b98caba3 - Alex Bennée: tests/docker: handle missing encoding keyword for subprocess.check_output
unreviewed - 450795acac1 - Alex Bennée: tests/docker: fix "cc" command to work with podman
unreviewed - 131dc565937 - Alex Bennée: configure: clean-up container cross compile detect


>
> Alex Bennée (27):
>   configure: clean-up container cross compile detect
>   tests/docker: fix "cc" command to work with podman
>   tests/tcg: add .gitignore for in source builds
>   tests/docker: move DEF_TARGET_LIST setting to common.rc
>   tests/docker: set DEF_TARGET_LIST for some containers
>   tests/docker: add Buster to DOCKER_PARTIAL_IMAGES
>   tests/docker: move our arm64 cross compile to Buster
>   tests/docker: move our powerpc cross compile to Buster
>   tests/docker: move our Alpha cross compile to Buster
>   tests/docker: move our HPPA cross compile to Buster
>   tests/docker: move our m68k cross compile to Buster
>   tests/docker: move our sparc64 cross compile to Buster
>   tests/docker: move our sh4 cross compile to Buster
>   tests/docker: move our mips64 cross compile to Buster
>   tests/docker: move our riscv64 cross compile to Buster
>   tests/docker: move our ppc64 cross compile to Buster
>   tests/docker: drop debian-sid image
>   tests/docker: drop powerpc-user image for QEMU cross builds
>   tests/docker: add debian-xtensa-cross to DEBIAN_PARTIAL_IMAGES
>   tests/docker: add debian9-mxe to DEBIAN_PARTIAL_IMAGES
>   tests/docker: avoid $SHELL invoke bash directly
>   tests/docker: add debian-amd64-cross for non-x86 hosts
>   tests/docker: use --arch-only for installing deps
>   tests/docker: add more images to PARTIAL_IMAGES when not on x86_64
>   configure: check if --no-pie is supported first
>   tests/docker: --disable-libssh on ubuntu1804 builds
>   tests/docker: don't always encoding for subprocess.check_output
>
> Cleber Rosa (1):
>   Fedora images: use URLs from stable "archives.fedoraproject.org"
>
> Paolo Bonzini (3):
>   tests/tcg: use EXTRA_CFLAGS everywhere
>   tests/tcg: cleanup Makefile inclusions
>   tests/tcg: move configuration to a sub-shell script
>
> Philippe Mathieu-Daudé (10):
>   .travis.yml: Enable multiple caching features
>   .travis.yml: Increase cache timeout from 3min to 20min
>   .travis.yml: Cache Python PIP packages
>   .travis.yml: Cache Avocado cache
>   .travis.yml: Improve ccache use
>   .travis.yml: Enable ccache on OSX
>   .travis.yml: Document how the build matrix use caches
>   .travis.yml: Cache Linux/GCC 'debug profile' jobs together
>   .travis.yml: Cache Linux/GCC 'non-debug profile' jobs together
>   .travis.yml: Cache Linux/Clang jobs together
>
> Thomas Huth (1):
>   hw/misc: Mark most objects as "common" code to speed up compilation a
>     litte bit
>
>  .travis.yml                                   |  39 ++-
>  Makefile                                      |   1 +
>  Makefile.target                               |   3 -
>  configure                                     | 168 ++-----------
>  hw/misc/Makefile.objs                         |  90 +++----
>  qemu-doc.texi                                 |   6 +-
>  tests/Makefile.include                        |  25 +-
>  tests/acceptance/boot_linux_console.py        |  25 +-
>  tests/acceptance/linux_initrd.py              |   5 +-
>  tests/docker/Makefile.include                 |  61 +++--
>  tests/docker/common.rc                        |   4 +
>  tests/docker/docker.py                        |  51 ++--
>  .../dockerfiles/debian-alpha-cross.docker     |   7 +-
>  .../dockerfiles/debian-amd64-cross.docker     |  22 ++
>  .../dockerfiles/debian-arm64-cross.docker     |   7 +-
>  .../dockerfiles/debian-armel-cross.docker     |   3 +-
>  .../dockerfiles/debian-armhf-cross.docker     |   3 +-
>  .../debian-buster-arm64-cross.docker          |  16 --
>  .../dockerfiles/debian-hppa-cross.docker      |   5 +-
>  .../dockerfiles/debian-m68k-cross.docker      |   5 +-
>  .../dockerfiles/debian-mips-cross.docker      |   7 +-
>  .../dockerfiles/debian-mips64-cross.docker    |   5 +-
>  .../dockerfiles/debian-mips64el-cross.docker  |   3 +-
>  .../dockerfiles/debian-mipsel-cross.docker    |   2 +-
>  .../dockerfiles/debian-powerpc-cross.docker   |   8 +-
>  .../debian-powerpc-user-cross.docker          |  15 --
>  .../dockerfiles/debian-ppc64-cross.docker     |   7 +-
>  .../dockerfiles/debian-ppc64el-cross.docker   |   3 +-
>  .../dockerfiles/debian-riscv64-cross.docker   |   5 +-
>  .../dockerfiles/debian-s390x-cross.docker     |   3 +-
>  .../dockerfiles/debian-sh4-cross.docker       |   5 +-
>  tests/docker/dockerfiles/debian-sid.docker    |  41 ---
>  .../dockerfiles/debian-sparc64-cross.docker   |   5 +-
>  tests/docker/dockerfiles/ubuntu1804.docker    |   3 +
>  tests/docker/run                              |   4 +-
>  tests/docker/test-build                       |   1 -
>  tests/docker/test-mingw                       |   1 -
>  tests/docker/test-quick                       |   1 -
>  tests/tcg/.gitignore                          |   5 +
>  tests/tcg/Makefile.include                    |  88 -------
>  tests/tcg/Makefile.prereqs                    |  18 ++
>  tests/tcg/Makefile.probe                      |  31 ---
>  tests/tcg/Makefile.qemu                       |  95 +++++++
>  tests/tcg/{Makefile => Makefile.target}       |  15 +-
>  tests/tcg/aarch64/Makefile.include            |   8 -
>  tests/tcg/aarch64/Makefile.softmmu-target     |   4 +-
>  tests/tcg/aarch64/Makefile.target             |  12 +-
>  tests/tcg/alpha/Makefile.include              |   2 -
>  tests/tcg/alpha/Makefile.softmmu-target       |   4 +-
>  tests/tcg/arm/Makefile.include                |   8 -
>  tests/tcg/arm/Makefile.softmmu-target         |   6 +-
>  tests/tcg/configure.sh                        | 234 ++++++++++++++++++
>  tests/tcg/cris/Makefile.include               |   6 -
>  tests/tcg/hppa/Makefile.include               |   2 -
>  tests/tcg/i386/Makefile.include               |   9 -
>  tests/tcg/i386/Makefile.softmmu-target        |  12 +-
>  tests/tcg/i386/Makefile.target                |  13 +-
>  tests/tcg/m68k/Makefile.include               |   2 -
>  tests/tcg/minilib/Makefile.target             |   2 +-
>  tests/tcg/mips/Makefile.include               |  20 --
>  tests/tcg/ppc/Makefile.include                |  10 -
>  tests/tcg/riscv/Makefile.include              |  10 -
>  tests/tcg/s390x/Makefile.include              |   2 -
>  tests/tcg/sh4/Makefile.include                |   4 -
>  tests/tcg/sparc64/Makefile.include            |   2 -
>  tests/tcg/x86_64/Makefile.softmmu-target      |  36 +++
>  tests/tcg/x86_64/Makefile.target              |   7 +-
>  tests/tcg/xtensa/Makefile.include             |  11 -
>  tests/tcg/xtensa/Makefile.softmmu-target      |   4 +-
>  tests/vm/fedora                               |   2 +-
>  70 files changed, 693 insertions(+), 656 deletions(-)
>  create mode 100644 tests/docker/dockerfiles/debian-amd64-cross.docker
>  delete mode 100644 tests/docker/dockerfiles/debian-buster-arm64-cross.docker
>  delete mode 100644 tests/docker/dockerfiles/debian-powerpc-user-cross.docker
>  delete mode 100644 tests/docker/dockerfiles/debian-sid.docker
>  create mode 100644 tests/tcg/.gitignore
>  delete mode 100644 tests/tcg/Makefile.include
>  create mode 100644 tests/tcg/Makefile.prereqs
>  delete mode 100644 tests/tcg/Makefile.probe
>  create mode 100644 tests/tcg/Makefile.qemu
>  rename tests/tcg/{Makefile => Makefile.target} (90%)
>  delete mode 100644 tests/tcg/aarch64/Makefile.include
>  delete mode 100644 tests/tcg/alpha/Makefile.include
>  delete mode 100644 tests/tcg/arm/Makefile.include
>  create mode 100755 tests/tcg/configure.sh
>  delete mode 100644 tests/tcg/cris/Makefile.include
>  delete mode 100644 tests/tcg/hppa/Makefile.include
>  delete mode 100644 tests/tcg/i386/Makefile.include
>  delete mode 100644 tests/tcg/m68k/Makefile.include
>  delete mode 100644 tests/tcg/mips/Makefile.include
>  delete mode 100644 tests/tcg/ppc/Makefile.include
>  delete mode 100644 tests/tcg/riscv/Makefile.include
>  delete mode 100644 tests/tcg/s390x/Makefile.include
>  delete mode 100644 tests/tcg/sh4/Makefile.include
>  delete mode 100644 tests/tcg/sparc64/Makefile.include
>  create mode 100644 tests/tcg/x86_64/Makefile.softmmu-target
>  delete mode 100644 tests/tcg/xtensa/Makefile.include


--
Alex Bennée