[v1] Make the core libqtest library independe from global_qtest

[Qemu-devel] [PATCH 0/6] Make the core libqtest library independe from global_qtest

Thomas Huth posted 6 patches 6 years, 2 months ago

Diff against v2
Download series mbox

Test docker-clang@ubuntu failed

Test FreeBSD passed

Test checkpatch passed

Test docker-mingw@fedora passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20190903061849.21493-1-thuth@redhat.com

Maintainers: "Dr. David Alan Gilbert" <dgilbert@redhat.com>, Igor Mammedov <imammedo@redhat.com>, David Gibson <david@gibson.dropbear.id.au>, Stefan Hajnoczi <stefanha@redhat.com>, Corey Minyard <minyard@acm.org>, Laurent Vivier <lvivier@redhat.com>, Thomas Huth <thuth@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>, Stefan Berger <stefanb@linux.ibm.com>, Fam Zheng <fam@euphon.net>, Gerd Hoffmann <kraxel@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, John Snow <jsnow@redhat.com>, Marcel Apfelbaum <marcel.apfelbaum@gmail.com>, Jason Wang <jasowang@redhat.com>, Amit Shah <amit@kernel.org>, Juan Quintela <quintela@redhat.com>

There is a newer version of this series

MAINTAINERS                   |   2 +-
tests/ahci-test.c             |   1 -
tests/bios-tables-test.c      |   1 -
tests/cpu-plug-test.c         |   2 +-
tests/display-vga-test.c      |   2 +-
tests/e1000e-test.c           |   2 +-
tests/fdc-test.c              |   2 +-
tests/i440fx-test.c           |   2 +-
tests/i82801b11-test.c        |   2 +-
tests/intel-hda-test.c        |   2 +-
tests/ioh3420-test.c          |   2 +-
tests/ipmi-kcs-test.c         |   3 +-
tests/ivshmem-test.c          |   3 -
tests/libqos/e1000e.c         |  16 +-
tests/libqos/virtio.c         |  15 +-
tests/libqos/virtio.h         |   5 +-
tests/libqtest-single.h       | 315 ++++++++++++++++++++++++++++++++++
tests/libqtest.c              |  13 --
tests/libqtest.h              | 289 -------------------------------
tests/migration-test.c        |   6 +-
tests/qos-test.c              |   2 +-
tests/rtas-test.c             |   1 -
tests/rtc-test.c              |   2 +-
tests/rtl8139-test.c          |   2 +-
tests/test-netfilter.c        |   2 +-
tests/test-x86-cpuid-compat.c |   2 +-
tests/tmp105-test.c           |   2 +-
tests/tpm-crb-test.c          |   2 +-
tests/tpm-tests.c             |   2 +-
tests/tpm-tis-test.c          |   2 +-
tests/usb-hcd-ohci-test.c     |   2 +-
tests/usb-hcd-uhci-test.c     |   2 +-
tests/usb-hcd-xhci-test.c     |   2 +-
tests/vhost-user-test.c       |   2 +-
tests/virtio-blk-test.c       |  10 +-
tests/virtio-ccw-test.c       |   2 +-
tests/virtio-net-test.c       |   2 +-
tests/virtio-scsi-test.c      |   2 +-
tests/virtio-serial-test.c    |   2 +-
39 files changed, 373 insertions(+), 357 deletions(-)
create mode 100644 tests/libqtest-single.h

Expand all Fold all

[Qemu-devel] [PATCH 0/6] Make the core libqtest library independe from global_qtest

Posted by Thomas Huth 6 years, 2 months ago

global_qtest and the related wrapper functions often caused trouble in
the past - if they are used somewhere in the libqtest or libqos library
code, it's hard to write tests that properly track multiple test states
(like migration tests).

This patch series finally gets rid of the remaining global_qtest
dependencies in the core libqtest code. The first patches are used to
clean up some files that should not use global_qtest anymore, then the
wrapper functions and the global_qtest definition get moved to a separate
header file called libqtest-single.h - which then should only be used in
tests that track only a single test state.

Thomas Huth (6):
  tests/migration: Do not use functions anymore that rely on
    global_qtest
  tests/libqos/e1000e: Make e1000e libqos functions independent from
    global_qtest
  tests/libqos: Replace clock_step with qtest_clock_step in virtio code
  tests: Remove unnecessary global_qtest references
  tests/libqtest: Move global_test wrapper function into a separate
    header
  tests/libqtest: Use libqtest-single.h in tests that require
    global_qtest

 MAINTAINERS                   |   2 +-
 tests/ahci-test.c             |   1 -
 tests/bios-tables-test.c      |   1 -
 tests/cpu-plug-test.c         |   2 +-
 tests/display-vga-test.c      |   2 +-
 tests/e1000e-test.c           |   2 +-
 tests/fdc-test.c              |   2 +-
 tests/i440fx-test.c           |   2 +-
 tests/i82801b11-test.c        |   2 +-
 tests/intel-hda-test.c        |   2 +-
 tests/ioh3420-test.c          |   2 +-
 tests/ipmi-kcs-test.c         |   3 +-
 tests/ivshmem-test.c          |   3 -
 tests/libqos/e1000e.c         |  16 +-
 tests/libqos/virtio.c         |  15 +-
 tests/libqos/virtio.h         |   5 +-
 tests/libqtest-single.h       | 315 ++++++++++++++++++++++++++++++++++
 tests/libqtest.c              |  13 --
 tests/libqtest.h              | 289 -------------------------------
 tests/migration-test.c        |   6 +-
 tests/qos-test.c              |   2 +-
 tests/rtas-test.c             |   1 -
 tests/rtc-test.c              |   2 +-
 tests/rtl8139-test.c          |   2 +-
 tests/test-netfilter.c        |   2 +-
 tests/test-x86-cpuid-compat.c |   2 +-
 tests/tmp105-test.c           |   2 +-
 tests/tpm-crb-test.c          |   2 +-
 tests/tpm-tests.c             |   2 +-
 tests/tpm-tis-test.c          |   2 +-
 tests/usb-hcd-ohci-test.c     |   2 +-
 tests/usb-hcd-uhci-test.c     |   2 +-
 tests/usb-hcd-xhci-test.c     |   2 +-
 tests/vhost-user-test.c       |   2 +-
 tests/virtio-blk-test.c       |  10 +-
 tests/virtio-ccw-test.c       |   2 +-
 tests/virtio-net-test.c       |   2 +-
 tests/virtio-scsi-test.c      |   2 +-
 tests/virtio-serial-test.c    |   2 +-
 39 files changed, 373 insertions(+), 357 deletions(-)
 create mode 100644 tests/libqtest-single.h

-- 
2.18.1