[v6] delete created files when block_crypto_co_create_opts_luks fails

[Qemu-devel] [PATCH v6 0/4] delete created files when block_crypto_co_create_opts_luks fails

Daniel Henrique Barboza posted 4 patches 6 years, 2 months ago

Diff against v3 v4 v5 v7 v8 v9
Download series mbox

Test docker-clang@ubuntu passed

Test FreeBSD passed

Test checkpatch passed

Test docker-mingw@fedora passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20190902205842.1884-1-danielhb413@gmail.com

Maintainers: Kevin Wolf <kwolf@redhat.com>, Max Reitz <mreitz@redhat.com>

There is a newer version of this series

block.c                    | 78 ++++++++++++++++++++++++++++++++++++++
block/crypto.c             | 22 +++++++++++
block/file-posix.c         | 28 ++++++++++++++
include/block/block.h      |  1 +
include/block/block_int.h  |  6 +++
tests/qemu-iotests/259     | 67 ++++++++++++++++++++++++++++++++
tests/qemu-iotests/259.out | 11 ++++++
tests/qemu-iotests/group   |  1 +
8 files changed, 214 insertions(+)
create mode 100755 tests/qemu-iotests/259
create mode 100644 tests/qemu-iotests/259.out

Expand all Fold all

[Qemu-devel] [PATCH v6 0/4] delete created files when block_crypto_co_create_opts_luks fails

Posted by Daniel Henrique Barboza 6 years, 2 months ago

Changes from previous version 5 [1] suggested by John Snow:
- patch 2: return ENOMEDIUM with !drv, return negative error
codes in bdrv_delete_file
- patch 3: clarify the meaning of returning ENOENT in the
comment

[1] https://lists.gnu.org/archive/html/qemu-devel/2019-08/msg01173.html


Daniel Henrique Barboza (4):
  block: introducing 'bdrv_co_delete_file' interface
  block.c: adding bdrv_delete_file
  crypto.c: cleanup created file when block_crypto_co_create_opts_luks
    fails
  qemu-iotests: adding LUKS cleanup for non-UTF8 secret error

 block.c                    | 78 ++++++++++++++++++++++++++++++++++++++
 block/crypto.c             | 22 +++++++++++
 block/file-posix.c         | 28 ++++++++++++++
 include/block/block.h      |  1 +
 include/block/block_int.h  |  6 +++
 tests/qemu-iotests/259     | 67 ++++++++++++++++++++++++++++++++
 tests/qemu-iotests/259.out | 11 ++++++
 tests/qemu-iotests/group   |  1 +
 8 files changed, 214 insertions(+)
 create mode 100755 tests/qemu-iotests/259
 create mode 100644 tests/qemu-iotests/259.out

-- 
2.21.0

Re: [Qemu-devel] [PATCH v6 0/4] delete created files when block_crypto_co_create_opts_luks fails

Posted by Daniel Henrique Barboza 6 years, 2 months ago

Please ignore this series. I'll respin a v7 to actually do what
Kevin suggested in the v4 review.

Thanks,


DHB

On 9/2/19 5:58 PM, Daniel Henrique Barboza wrote:
> Changes from previous version 5 [1] suggested by John Snow:
> - patch 2: return ENOMEDIUM with !drv, return negative error
> codes in bdrv_delete_file
> - patch 3: clarify the meaning of returning ENOENT in the
> comment
>
> [1] https://lists.gnu.org/archive/html/qemu-devel/2019-08/msg01173.html
>
>
> Daniel Henrique Barboza (4):
>    block: introducing 'bdrv_co_delete_file' interface
>    block.c: adding bdrv_delete_file
>    crypto.c: cleanup created file when block_crypto_co_create_opts_luks
>      fails
>    qemu-iotests: adding LUKS cleanup for non-UTF8 secret error
>
>   block.c                    | 78 ++++++++++++++++++++++++++++++++++++++
>   block/crypto.c             | 22 +++++++++++
>   block/file-posix.c         | 28 ++++++++++++++
>   include/block/block.h      |  1 +
>   include/block/block_int.h  |  6 +++
>   tests/qemu-iotests/259     | 67 ++++++++++++++++++++++++++++++++
>   tests/qemu-iotests/259.out | 11 ++++++
>   tests/qemu-iotests/group   |  1 +
>   8 files changed, 214 insertions(+)
>   create mode 100755 tests/qemu-iotests/259
>   create mode 100644 tests/qemu-iotests/259.out
>