ppc/pnv: fix "bmc" node name in DT

[Qemu-devel] [PATCH] ppc/pnv: fix "bmc" node name in DT

Cédric Le Goater posted 1 patch 6 years, 2 months ago

Download mbox

Test docker-clang@ubuntu passed

Test FreeBSD passed

Test checkpatch passed

Test docker-mingw@fedora passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20190902092932.20200-1-clg@kaod.org

Maintainers: "Cédric Le Goater" <clg@kaod.org>, David Gibson <david@gibson.dropbear.id.au>

hw/ppc/pnv_bmc.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)

Expand all Fold all

[Qemu-devel] [PATCH] ppc/pnv: fix "bmc" node name in DT

Posted by Cédric Le Goater 6 years, 2 months ago

Fixes the dtc output :

ERROR (node_name_chars): //bmc: Bad character '/' in node name
Warning (avoid_unnecessary_addr_size): /bmc: unnecessary #address-cells/#size-cells without "ranges" or child "reg" property

Signed-off-by: Cédric Le Goater <clg@kaod.org>
---
 hw/ppc/pnv_bmc.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/hw/ppc/pnv_bmc.c b/hw/ppc/pnv_bmc.c
index e5eb6e5a70da..dc5e918cb79e 100644
--- a/hw/ppc/pnv_bmc.c
+++ b/hw/ppc/pnv_bmc.c
@@ -77,13 +77,10 @@ void pnv_dt_bmc_sensors(IPMIBmc *bmc, void *fdt)
     const struct ipmi_sdr_compact *sdr;
     uint16_t nextrec;
 
-    offset = fdt_add_subnode(fdt, 0, "/bmc");
+    offset = fdt_add_subnode(fdt, 0, "bmc");
     _FDT(offset);
 
     _FDT((fdt_setprop_string(fdt, offset, "name", "bmc")));
-    _FDT((fdt_setprop_cell(fdt, offset, "#address-cells", 0x1)));
-    _FDT((fdt_setprop_cell(fdt, offset, "#size-cells", 0x0)));
-
     offset = fdt_add_subnode(fdt, offset, "sensors");
     _FDT(offset);
 
-- 
2.21.0

Re: [Qemu-devel] [PATCH] ppc/pnv: fix "bmc" node name in DT

Posted by David Gibson 6 years, 2 months ago

On Mon, Sep 02, 2019 at 11:29:32AM +0200, Cédric Le Goater wrote:
> Fixes the dtc output :
> 
> ERROR (node_name_chars): //bmc: Bad character '/' in node name
> Warning (avoid_unnecessary_addr_size): /bmc: unnecessary #address-cells/#size-cells without "ranges" or child "reg" property
> 
> Signed-off-by: Cédric Le Goater <clg@kaod.org>

Applied to ppc-for-4.2, thanks.

> ---
>  hw/ppc/pnv_bmc.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/hw/ppc/pnv_bmc.c b/hw/ppc/pnv_bmc.c
> index e5eb6e5a70da..dc5e918cb79e 100644
> --- a/hw/ppc/pnv_bmc.c
> +++ b/hw/ppc/pnv_bmc.c
> @@ -77,13 +77,10 @@ void pnv_dt_bmc_sensors(IPMIBmc *bmc, void *fdt)
>      const struct ipmi_sdr_compact *sdr;
>      uint16_t nextrec;
>  
> -    offset = fdt_add_subnode(fdt, 0, "/bmc");
> +    offset = fdt_add_subnode(fdt, 0, "bmc");
>      _FDT(offset);
>  
>      _FDT((fdt_setprop_string(fdt, offset, "name", "bmc")));
> -    _FDT((fdt_setprop_cell(fdt, offset, "#address-cells", 0x1)));
> -    _FDT((fdt_setprop_cell(fdt, offset, "#size-cells", 0x0)));
> -
>      offset = fdt_add_subnode(fdt, offset, "sensors");
>      _FDT(offset);
>  

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson