Just passing NULL means we end up ignoring the bad dfilter spec
instead of reporting it and exiting as we should.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
 linux-user/main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/linux-user/main.c b/linux-user/main.c
index 47917bbb20f..50a031520ca 100644
--- a/linux-user/main.c
+++ b/linux-user/main.c
@@ -236,7 +236,7 @@ static void handle_arg_log(const char *arg)
 
 static void handle_arg_dfilter(const char *arg)
 {
-    qemu_set_dfilter_ranges(arg, NULL);
+    qemu_set_dfilter_ranges(arg, &error_fatal);
 }
 
 static void handle_arg_log_filename(const char *arg)
-- 
2.20.1

Le 30/08/2019 à 16:36, Alex Bennée a écrit :
> Just passing NULL means we end up ignoring the bad dfilter spec
> instead of reporting it and exiting as we should.
> 
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
>  linux-user/main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/linux-user/main.c b/linux-user/main.c
> index 47917bbb20f..50a031520ca 100644
> --- a/linux-user/main.c
> +++ b/linux-user/main.c
> @@ -236,7 +236,7 @@ static void handle_arg_log(const char *arg)
>  
>  static void handle_arg_dfilter(const char *arg)
>  {
> -    qemu_set_dfilter_ranges(arg, NULL);
> +    qemu_set_dfilter_ranges(arg, &error_fatal);
>  }
>  
>  static void handle_arg_log_filename(const char *arg)
> 

Reviewed-by: Laurent Vivier <laurent@vivier.eu>

Laurent Vivier <laurent@vivier.eu> writes:

> Le 30/08/2019 à 16:36, Alex Bennée a écrit :
>> Just passing NULL means we end up ignoring the bad dfilter spec
>> instead of reporting it and exiting as we should.
>>
>> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
>> ---
>>  linux-user/main.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/linux-user/main.c b/linux-user/main.c
>> index 47917bbb20f..50a031520ca 100644
>> --- a/linux-user/main.c
>> +++ b/linux-user/main.c
>> @@ -236,7 +236,7 @@ static void handle_arg_log(const char *arg)
>>
>>  static void handle_arg_dfilter(const char *arg)
>>  {
>> -    qemu_set_dfilter_ranges(arg, NULL);
>> +    qemu_set_dfilter_ranges(arg, &error_fatal);
>>  }
>>
>>  static void handle_arg_log_filename(const char *arg)
>>
>
> Reviewed-by: Laurent Vivier <laurent@vivier.eu>

Did you queue this or do you want me to resend?


--
Alex Bennée

Le 09/09/2019 à 16:00, Alex Bennée a écrit :
> 
> Laurent Vivier <laurent@vivier.eu> writes:
> 
>> Le 30/08/2019 à 16:36, Alex Bennée a écrit :
>>> Just passing NULL means we end up ignoring the bad dfilter spec
>>> instead of reporting it and exiting as we should.
>>>
>>> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
>>> ---
>>>  linux-user/main.c | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/linux-user/main.c b/linux-user/main.c
>>> index 47917bbb20f..50a031520ca 100644
>>> --- a/linux-user/main.c
>>> +++ b/linux-user/main.c
>>> @@ -236,7 +236,7 @@ static void handle_arg_log(const char *arg)
>>>
>>>  static void handle_arg_dfilter(const char *arg)
>>>  {
>>> -    qemu_set_dfilter_ranges(arg, NULL);
>>> +    qemu_set_dfilter_ranges(arg, &error_fatal);
>>>  }
>>>
>>>  static void handle_arg_log_filename(const char *arg)
>>>
>>
>> Reviewed-by: Laurent Vivier <laurent@vivier.eu>
> 
> Did you queue this or do you want me to resend?

I didn't but it's done now (no need to resend).

Thanks,
Laurent