[Qemu-devel] [PATCH 0/9] qapi: Schema language cleanups & doc improvements

Markus Armbruster posted 9 patches 4 years, 7 months ago
Test docker-clang@ubuntu passed
Test FreeBSD passed
Test checkpatch failed
Test docker-mingw@fedora passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20190828202641.24752-1-armbru@redhat.com
Maintainers: Michael Roth <mdroth@linux.vnet.ibm.com>, Markus Armbruster <armbru@redhat.com>
There is a newer version of this series
docs/devel/qapi-code-gen.txt                  | 1048 ++++++++++-------
tests/qapi-schema/qapi-schema-test.json       |    2 +-
tests/qapi-schema/string-control.json         |    2 +
...losed-string.json => string-unclosed.json} |    0
.../{unicode-str.json => string-unicode.json} |    0
scripts/qapi/common.py                        |   27 +-
tests/Makefile.include                        |    5 +-
tests/qapi-schema/qapi-schema-test.out        |    2 +-
tests/qapi-schema/string-control.err          |    1 +
...closed-string.exit => string-control.exit} |    0
...unclosed-string.out => string-control.out} |    0
tests/qapi-schema/string-unclosed.err         |    1 +
...{unicode-str.exit => string-unclosed.exit} |    0
.../{unicode-str.out => string-unclosed.out}  |    0
tests/qapi-schema/string-unicode.err          |    1 +
tests/qapi-schema/string-unicode.exit         |    1 +
tests/qapi-schema/string-unicode.out          |    0
tests/qapi-schema/unclosed-string.err         |    1 -
tests/qapi-schema/unicode-str.err             |    1 -
19 files changed, 622 insertions(+), 470 deletions(-)
create mode 100644 tests/qapi-schema/string-control.json
rename tests/qapi-schema/{unclosed-string.json => string-unclosed.json} (100%)
rename tests/qapi-schema/{unicode-str.json => string-unicode.json} (100%)
create mode 100644 tests/qapi-schema/string-control.err
rename tests/qapi-schema/{unclosed-string.exit => string-control.exit} (100%)
rename tests/qapi-schema/{unclosed-string.out => string-control.out} (100%)
create mode 100644 tests/qapi-schema/string-unclosed.err
rename tests/qapi-schema/{unicode-str.exit => string-unclosed.exit} (100%)
rename tests/qapi-schema/{unicode-str.out => string-unclosed.out} (100%)
create mode 100644 tests/qapi-schema/string-unicode.err
create mode 100644 tests/qapi-schema/string-unicode.exit
create mode 100644 tests/qapi-schema/string-unicode.out
delete mode 100644 tests/qapi-schema/unclosed-string.err
delete mode 100644 tests/qapi-schema/unicode-str.err
[Qemu-devel] [PATCH 0/9] qapi: Schema language cleanups & doc improvements
Posted by Markus Armbruster 4 years, 7 months ago
Markus Armbruster (9):
  qapi: Drop check_type()'s redundant parameter @allow_optional
  qapi: Drop support for boxed alternate for commands, events
  docs/devel/qapi-code-gen: Minor specification fixes
  qapi: Outlaw control characters in strings
  tests/qapi-schema: Consistently name string tests string-FOO
  docs/devel/qapi-code-gen: Reorder sections for readability
  docs/devel/qapi-code-gen: Rewrite compatibility considerations
  docs/devel/qapi-code-gen: Rewrite introduction to schema
  docs/devel/qapi-code-gen: Improve QAPI schema language doc

 docs/devel/qapi-code-gen.txt                  | 1048 ++++++++++-------
 tests/qapi-schema/qapi-schema-test.json       |    2 +-
 tests/qapi-schema/string-control.json         |    2 +
 ...losed-string.json => string-unclosed.json} |    0
 .../{unicode-str.json => string-unicode.json} |    0
 scripts/qapi/common.py                        |   27 +-
 tests/Makefile.include                        |    5 +-
 tests/qapi-schema/qapi-schema-test.out        |    2 +-
 tests/qapi-schema/string-control.err          |    1 +
 ...closed-string.exit => string-control.exit} |    0
 ...unclosed-string.out => string-control.out} |    0
 tests/qapi-schema/string-unclosed.err         |    1 +
 ...{unicode-str.exit => string-unclosed.exit} |    0
 .../{unicode-str.out => string-unclosed.out}  |    0
 tests/qapi-schema/string-unicode.err          |    1 +
 tests/qapi-schema/string-unicode.exit         |    1 +
 tests/qapi-schema/string-unicode.out          |    0
 tests/qapi-schema/unclosed-string.err         |    1 -
 tests/qapi-schema/unicode-str.err             |    1 -
 19 files changed, 622 insertions(+), 470 deletions(-)
 create mode 100644 tests/qapi-schema/string-control.json
 rename tests/qapi-schema/{unclosed-string.json => string-unclosed.json} (100%)
 rename tests/qapi-schema/{unicode-str.json => string-unicode.json} (100%)
 create mode 100644 tests/qapi-schema/string-control.err
 rename tests/qapi-schema/{unclosed-string.exit => string-control.exit} (100%)
 rename tests/qapi-schema/{unclosed-string.out => string-control.out} (100%)
 create mode 100644 tests/qapi-schema/string-unclosed.err
 rename tests/qapi-schema/{unicode-str.exit => string-unclosed.exit} (100%)
 rename tests/qapi-schema/{unicode-str.out => string-unclosed.out} (100%)
 create mode 100644 tests/qapi-schema/string-unicode.err
 create mode 100644 tests/qapi-schema/string-unicode.exit
 create mode 100644 tests/qapi-schema/string-unicode.out
 delete mode 100644 tests/qapi-schema/unclosed-string.err
 delete mode 100644 tests/qapi-schema/unicode-str.err

-- 
2.21.0


Re: [Qemu-devel] [PATCH 0/9] qapi: Schema language cleanups & doc improvements
Posted by no-reply@patchew.org 4 years, 7 months ago
Patchew URL: https://patchew.org/QEMU/20190828202641.24752-1-armbru@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [Qemu-devel] [PATCH 0/9] qapi: Schema language cleanups & doc improvements
Message-id: 20190828202641.24752-1-armbru@redhat.com
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
d27cc29 docs/devel/qapi-code-gen: Improve QAPI schema language doc
72397f6 docs/devel/qapi-code-gen: Rewrite introduction to schema
62b02fb docs/devel/qapi-code-gen: Rewrite compatibility considerations
97bf23f docs/devel/qapi-code-gen: Reorder sections for readability
dfd13e2 tests/qapi-schema: Consistently name string tests string-FOO
5e21c3b qapi: Outlaw control characters in strings
1cd34f8 docs/devel/qapi-code-gen: Minor specification fixes
ab6ab29 qapi: Drop support for boxed alternate for commands, events
29df3a5 qapi: Drop check_type()'s redundant parameter @allow_optional

=== OUTPUT BEGIN ===
1/9 Checking commit 29df3a54e53e (qapi: Drop check_type()'s redundant parameter @allow_optional)
2/9 Checking commit ab6ab29d80e0 (qapi: Drop support for boxed alternate for commands, events)
3/9 Checking commit 1cd34f8cbd0e (docs/devel/qapi-code-gen: Minor specification fixes)
4/9 Checking commit 5e21c3bbc6d3 (qapi: Outlaw control characters in strings)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#52: 
new file mode 100644

ERROR: Invalid UTF-8, patch and commit message should be encoded in UTF-8
#72: FILE: tests/qapi-schema/string-control.json:2:
+{ 'command': '⌦
────────────────────────────────────────────────────────────────────────
' }
               ^

total: 1 errors, 1 warnings, 20 lines checked

Patch 4/9 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

5/9 Checking commit dfd13e2b3dec (tests/qapi-schema: Consistently name string tests string-FOO)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#33: 
new file mode 100644

total: 0 errors, 1 warnings, 18 lines checked

Patch 5/9 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
6/9 Checking commit 97bf23fd9a0d (docs/devel/qapi-code-gen: Reorder sections for readability)
7/9 Checking commit 62b02fb7a675 (docs/devel/qapi-code-gen: Rewrite compatibility considerations)
8/9 Checking commit 72397f6335d8 (docs/devel/qapi-code-gen: Rewrite introduction to schema)
9/9 Checking commit d27cc292826e (docs/devel/qapi-code-gen: Improve QAPI schema language doc)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20190828202641.24752-1-armbru@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com