[Qemu-devel] [PULL v6 00/12] Machine + x86 queue, 2019-08-28

Eduardo Habkost posted 12 patches 4 years, 7 months ago
Test docker-clang@ubuntu passed
Test FreeBSD passed
Test checkpatch passed
Test docker-mingw@fedora passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20190828184026.5840-1-ehabkost@redhat.com
Maintainers: Shannon Zhao <shannon.zhaosl@gmail.com>, Igor Mitsyanko <i.mitsyanko@gmail.com>, Andrew Jeffery <andrew@aj.id.au>, "Edgar E. Iglesias" <edgar.iglesias@gmail.com>, Eric Blake <eblake@redhat.com>, Richard Henderson <rth@twiddle.net>, "Michael S. Tsirkin" <mst@redhat.com>, Beniamino Galvani <b.galvani@gmail.com>, Andrey Smirnov <andrew.smirnov@gmail.com>, "Philippe Mathieu-Daudé" <f4bug@amsat.org>, Andrew Baumann <Andrew.Baumann@microsoft.com>, David Gibson <david@gibson.dropbear.id.au>, Eduardo Habkost <ehabkost@redhat.com>, Peter Chubb <peter.chubb@nicta.com.au>, Peter Maydell <peter.maydell@linaro.org>, Andrzej Zaborowski <balrogg@gmail.com>, Jean-Christophe Dubois <jcd@tribudubois.net>, Paolo Bonzini <pbonzini@redhat.com>, Leif Lindholm <leif.lindholm@linaro.org>, Igor Mammedov <imammedo@redhat.com>, Alistair Francis <alistair@alistair23.me>, "Cédric Le Goater" <clg@kaod.org>, Marcel Apfelbaum <marcel.apfelbaum@gmail.com>, Joel Stanley <joel@jms.id.au>, Markus Armbruster <armbru@redhat.com>, Jan Kiszka <jan.kiszka@web.de>, Rob Herring <robh@kernel.org>, Radoslaw Biernacki <radoslaw.biernacki@linaro.org>
qapi/machine.json                        |  5 +-
include/hw/acpi/aml-build.h              |  2 +-
include/hw/arm/boot.h                    |  4 +-
include/hw/boards.h                      |  2 +
include/sysemu/numa.h                    | 17 +++--
include/sysemu/sysemu.h                  |  2 -
backends/hostmem-file.c                  |  4 +-
exec.c                                   |  5 +-
hw/acpi/aml-build.c                      | 10 ++-
hw/arm/aspeed.c                          |  5 +-
hw/arm/boot.c                            | 21 +++---
hw/arm/collie.c                          |  8 +--
hw/arm/cubieboard.c                      |  5 +-
hw/arm/exynos4_boards.c                  |  7 +-
hw/arm/highbank.c                        |  8 +--
hw/arm/imx25_pdk.c                       |  5 +-
hw/arm/integratorcp.c                    |  8 +--
hw/arm/kzm.c                             |  5 +-
hw/arm/mainstone.c                       |  5 +-
hw/arm/mcimx6ul-evk.c                    |  5 +-
hw/arm/mcimx7d-sabre.c                   |  5 +-
hw/arm/musicpal.c                        |  8 +--
hw/arm/nseries.c                         |  5 +-
hw/arm/omap_sx1.c                        |  5 +-
hw/arm/palm.c                            | 10 +--
hw/arm/raspi.c                           |  6 +-
hw/arm/realview.c                        |  5 +-
hw/arm/sabrelite.c                       |  5 +-
hw/arm/sbsa-ref.c                        | 12 ++--
hw/arm/spitz.c                           |  5 +-
hw/arm/tosa.c                            |  8 +--
hw/arm/versatilepb.c                     |  5 +-
hw/arm/vexpress.c                        |  5 +-
hw/arm/virt-acpi-build.c                 | 19 +++---
hw/arm/virt.c                            | 17 ++---
hw/arm/xilinx_zynq.c                     |  8 +--
hw/arm/xlnx-versal-virt.c                |  7 +-
hw/arm/xlnx-zcu102.c                     |  5 +-
hw/arm/z2.c                              |  8 +--
hw/core/machine-hmp-cmds.c               | 13 +++-
hw/core/machine-qmp-cmds.c               |  4 ++
hw/core/machine.c                        | 14 ++--
hw/core/numa.c                           | 87 ++++++++++++++----------
hw/i386/acpi-build.c                     |  4 +-
hw/i386/pc.c                             | 27 ++++++--
hw/i386/vmmouse.c                        |  1 +
hw/mem/pc-dimm.c                         |  2 +
hw/pci-bridge/pci_expander_bridge.c      |  9 ++-
hw/ppc/spapr.c                           | 36 ++++------
hw/ppc/spapr_pci.c                       |  4 +-
tests/acceptance/pc_cpu_hotplug_props.py | 35 ++++++++++
51 files changed, 265 insertions(+), 252 deletions(-)
create mode 100644 tests/acceptance/pc_cpu_hotplug_props.py
[Qemu-devel] [PULL v6 00/12] Machine + x86 queue, 2019-08-28
Posted by Eduardo Habkost 4 years, 7 months ago
Sorry for taking so long after 4.1.0 to send this.  I had to sort
out some conflicts with recent header cleanups.

The following changes since commit 23919ddfd56135cad3cb468a8f54d5a595f024f4:

  Merge remote-tracking branch 'remotes/aperard/tags/pull-xen-20190827' into staging (2019-08-27 15:52:36 +0100)

are available in the Git repository at:

  git://github.com/ehabkost/qemu.git tags/machine-next-pull-request

for you to fetch changes up to f4abcc0a75f1310dbe66b852ed97ec7caf2708d5:

  i386/vmmouse: Properly reset state (2019-08-27 16:50:14 -0300)

----------------------------------------------------------------
Machine + x86 queue, 2019-08-28

Bug fixes:
* Fix die-id validation regression (Eduardo Habkost)
* vmmouse: Properly reset state (Jan Kiszka)
* hostmem-file: fix pmem file size check (Stefan Hajnoczi)

Cleanups:
* NUMA code cleanups (Tao Xu)
* Remove stale externs from includes (Alex Bennée)

Features:
* qapi: report the default CPU type for each machine (Daniel P. Berrangé)

----------------------------------------------------------------

Queue for Machine Core patches


Alex Bennée (1):
  includes: remove stale [smp|max]_cpus externs

Daniel P. Berrangé (1):
  qapi: report the default CPU type for each machine

Eduardo Habkost (3):
  pc: Fix error message on die-id validation
  pc: Improve error message when die-id is omitted
  pc: Don't make die-id mandatory unless necessary

Jan Kiszka (1):
  i386/vmmouse: Properly reset state

Stefan Hajnoczi (1):
  hostmem-file: fix pmem file size check

Tao Xu (5):
  hw/arm: simplify arm_load_dtb
  numa: move numa global variable nb_numa_nodes into MachineState
  numa: move numa global variable have_numa_distance into MachineState
  numa: move numa global variable numa_info into MachineState
  numa: Introduce MachineClass::auto_enable_numa for implicit NUMA node

 qapi/machine.json                        |  5 +-
 include/hw/acpi/aml-build.h              |  2 +-
 include/hw/arm/boot.h                    |  4 +-
 include/hw/boards.h                      |  2 +
 include/sysemu/numa.h                    | 17 +++--
 include/sysemu/sysemu.h                  |  2 -
 backends/hostmem-file.c                  |  4 +-
 exec.c                                   |  5 +-
 hw/acpi/aml-build.c                      | 10 ++-
 hw/arm/aspeed.c                          |  5 +-
 hw/arm/boot.c                            | 21 +++---
 hw/arm/collie.c                          |  8 +--
 hw/arm/cubieboard.c                      |  5 +-
 hw/arm/exynos4_boards.c                  |  7 +-
 hw/arm/highbank.c                        |  8 +--
 hw/arm/imx25_pdk.c                       |  5 +-
 hw/arm/integratorcp.c                    |  8 +--
 hw/arm/kzm.c                             |  5 +-
 hw/arm/mainstone.c                       |  5 +-
 hw/arm/mcimx6ul-evk.c                    |  5 +-
 hw/arm/mcimx7d-sabre.c                   |  5 +-
 hw/arm/musicpal.c                        |  8 +--
 hw/arm/nseries.c                         |  5 +-
 hw/arm/omap_sx1.c                        |  5 +-
 hw/arm/palm.c                            | 10 +--
 hw/arm/raspi.c                           |  6 +-
 hw/arm/realview.c                        |  5 +-
 hw/arm/sabrelite.c                       |  5 +-
 hw/arm/sbsa-ref.c                        | 12 ++--
 hw/arm/spitz.c                           |  5 +-
 hw/arm/tosa.c                            |  8 +--
 hw/arm/versatilepb.c                     |  5 +-
 hw/arm/vexpress.c                        |  5 +-
 hw/arm/virt-acpi-build.c                 | 19 +++---
 hw/arm/virt.c                            | 17 ++---
 hw/arm/xilinx_zynq.c                     |  8 +--
 hw/arm/xlnx-versal-virt.c                |  7 +-
 hw/arm/xlnx-zcu102.c                     |  5 +-
 hw/arm/z2.c                              |  8 +--
 hw/core/machine-hmp-cmds.c               | 13 +++-
 hw/core/machine-qmp-cmds.c               |  4 ++
 hw/core/machine.c                        | 14 ++--
 hw/core/numa.c                           | 87 ++++++++++++++----------
 hw/i386/acpi-build.c                     |  4 +-
 hw/i386/pc.c                             | 27 ++++++--
 hw/i386/vmmouse.c                        |  1 +
 hw/mem/pc-dimm.c                         |  2 +
 hw/pci-bridge/pci_expander_bridge.c      |  9 ++-
 hw/ppc/spapr.c                           | 36 ++++------
 hw/ppc/spapr_pci.c                       |  4 +-
 tests/acceptance/pc_cpu_hotplug_props.py | 35 ++++++++++
 51 files changed, 265 insertions(+), 252 deletions(-)
 create mode 100644 tests/acceptance/pc_cpu_hotplug_props.py

-- 
2.21.0


Re: [Qemu-devel] [PULL v6 00/12] Machine + x86 queue, 2019-08-28
Posted by Peter Maydell 4 years, 7 months ago
On Wed, 28 Aug 2019 at 19:40, Eduardo Habkost <ehabkost@redhat.com> wrote:
>
> Sorry for taking so long after 4.1.0 to send this.  I had to sort
> out some conflicts with recent header cleanups.
>
> The following changes since commit 23919ddfd56135cad3cb468a8f54d5a595f024f4:
>
>   Merge remote-tracking branch 'remotes/aperard/tags/pull-xen-20190827' into staging (2019-08-27 15:52:36 +0100)
>
> are available in the Git repository at:
>
>   git://github.com/ehabkost/qemu.git tags/machine-next-pull-request
>
> for you to fetch changes up to f4abcc0a75f1310dbe66b852ed97ec7caf2708d5:
>
>   i386/vmmouse: Properly reset state (2019-08-27 16:50:14 -0300)
>
> ----------------------------------------------------------------
> Machine + x86 queue, 2019-08-28
>
> Bug fixes:
> * Fix die-id validation regression (Eduardo Habkost)
> * vmmouse: Properly reset state (Jan Kiszka)
> * hostmem-file: fix pmem file size check (Stefan Hajnoczi)
>
> Cleanups:
> * NUMA code cleanups (Tao Xu)
> * Remove stale externs from includes (Alex Bennée)
>
> Features:
> * qapi: report the default CPU type for each machine (Daniel P. Berrangé)
>
> ----------------------------------------------------------------

Hi. This generates extra warnings during 'make check'
that all look like:

qemu-system-ppc64: warning: Default splitting of RAM between nodes is
deprecated, Use '-numa node,memdev' to explictly define RAM allocation
per node

Can you suppress them, please (or fix them if they are
legitimate)?

thanks
-- PMM

Re: [Qemu-devel] [PULL v6 00/12] Machine + x86 queue, 2019-08-28
Posted by Eduardo Habkost 4 years, 7 months ago
On Tue, Sep 03, 2019 at 04:03:54PM +0100, Peter Maydell wrote:
> On Wed, 28 Aug 2019 at 19:40, Eduardo Habkost <ehabkost@redhat.com> wrote:
> >
> > Sorry for taking so long after 4.1.0 to send this.  I had to sort
> > out some conflicts with recent header cleanups.
> >
> > The following changes since commit 23919ddfd56135cad3cb468a8f54d5a595f024f4:
> >
> >   Merge remote-tracking branch 'remotes/aperard/tags/pull-xen-20190827' into staging (2019-08-27 15:52:36 +0100)
> >
> > are available in the Git repository at:
> >
> >   git://github.com/ehabkost/qemu.git tags/machine-next-pull-request
> >
> > for you to fetch changes up to f4abcc0a75f1310dbe66b852ed97ec7caf2708d5:
> >
> >   i386/vmmouse: Properly reset state (2019-08-27 16:50:14 -0300)
> >
> > ----------------------------------------------------------------
> > Machine + x86 queue, 2019-08-28
> >
> > Bug fixes:
> > * Fix die-id validation regression (Eduardo Habkost)
> > * vmmouse: Properly reset state (Jan Kiszka)
> > * hostmem-file: fix pmem file size check (Stefan Hajnoczi)
> >
> > Cleanups:
> > * NUMA code cleanups (Tao Xu)
> > * Remove stale externs from includes (Alex Bennée)
> >
> > Features:
> > * qapi: report the default CPU type for each machine (Daniel P. Berrangé)
> >
> > ----------------------------------------------------------------
> 
> Hi. This generates extra warnings during 'make check'
> that all look like:
> 
> qemu-system-ppc64: warning: Default splitting of RAM between nodes is
> deprecated, Use '-numa node,memdev' to explictly define RAM allocation
> per node
> 
> Can you suppress them, please (or fix them if they are
> legitimate)?

I'm removing the patch that causes the spurious warnings, and
I'll send a new pull request soon.

-- 
Eduardo