Hi Peter,

Here are the ARM semi-hosting cleanup patches and a small selection of
miscellaneous TCG clean-ups. If your happy taking them all through
your tree please do otherwise I'll poke Richard. I'm just trying to
reduce the delta for my next iteration of the plugin series.

The following patches need review
   04 - target arm remove run time semihosting checks
   05 - includes remove stale smp max _cpus externs

The first is the result of review comments, moving CONFIG_TCG ifdefs
around and the second is pretty trivial.

Alex Bennée (7):
  target/arm: handle M-profile semihosting at translate time
  target/arm: handle A-profile T32 semihosting at translate time
  target/arm: handle A-profile A32 semihosting at translate time
  target/arm: remove run time semihosting checks
  includes: remove stale [smp|max]_cpus externs
  accel/stubs: reduce headers from tcg-stub
  include/exec/cpu-defs.h: fix typo

Emilio G. Cota (2):
  tcg/README: fix typo s/afterwise/afterwards/
  atomic_template: fix indentation in GEN_ATOMIC_HELPER

 accel/stubs/tcg-stub.c      |  2 -
 accel/tcg/atomic_template.h |  2 +-
 include/exec/cpu-defs.h     |  2 +-
 include/sysemu/sysemu.h     |  2 -
 target/arm/helper.c         | 96 +++++++++----------------------------
 target/arm/m_helper.c       | 18 +++----
 target/arm/translate.c      | 64 +++++++++++++++++++++----
 tcg/README                  |  2 +-
 8 files changed, 87 insertions(+), 101 deletions(-)

-- 
2.20.1

On 8/28/19 6:52 PM, Alex Bennée wrote:
> Hi Peter,
> 
> Here are the ARM semi-hosting cleanup patches and a small selection of
> miscellaneous TCG clean-ups. If your happy taking them all through
> your tree please do otherwise I'll poke Richard. I'm just trying to
> reduce the delta for my next iteration of the plugin series.
> 
> The following patches need review
>    04 - target arm remove run time semihosting checks
>    05 - includes remove stale smp max _cpus externs
> 
> The first is the result of review comments, moving CONFIG_TCG ifdefs
> around and the second is pretty trivial.
> 
> Alex Bennée (7):
>   target/arm: handle M-profile semihosting at translate time
>   target/arm: handle A-profile T32 semihosting at translate time
>   target/arm: handle A-profile A32 semihosting at translate time
>   target/arm: remove run time semihosting checks
>   includes: remove stale [smp|max]_cpus externs
>   accel/stubs: reduce headers from tcg-stub
>   include/exec/cpu-defs.h: fix typo
> 
> Emilio G. Cota (2):
>   tcg/README: fix typo s/afterwise/afterwards/
>   atomic_template: fix indentation in GEN_ATOMIC_HELPER

Thanks for cleaning this!

Series except patch #8 which you dropped:
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>

On Wed, 28 Aug 2019 at 18:08, Alex Bennée <alex.bennee@linaro.org> wrote:
>
> Hi Peter,
>
> Here are the ARM semi-hosting cleanup patches and a small selection of
> miscellaneous TCG clean-ups. If your happy taking them all through
> your tree please do otherwise I'll poke Richard. I'm just trying to
> reduce the delta for my next iteration of the plugin series.
>
> The following patches need review
>    04 - target arm remove run time semihosting checks
>    05 - includes remove stale smp max _cpus externs
>
> The first is the result of review comments, moving CONFIG_TCG ifdefs
> around and the second is pretty trivial.
>
> Alex Bennée (7):
>   target/arm: handle M-profile semihosting at translate time
>   target/arm: handle A-profile T32 semihosting at translate time
>   target/arm: handle A-profile A32 semihosting at translate time

On closer testing, this patch breaks the semihosting test suite:

$ /home/petmay01/linaro/qemu-from-laptop/qemu/build/arm-clang//arm-linux-user/qemu-arm
 usertest-a32
hello world via semi_write0
qemu: uncaught target signal 11 (Segmentation fault) - core dumped
Segmentation fault (core dumped)

so I'm unqueueing the first 4 patches (but have kept the
misc unrelated other fixes).

thanks
-- PMM

Peter Maydell <peter.maydell@linaro.org> writes:

> On Wed, 28 Aug 2019 at 18:08, Alex Bennée <alex.bennee@linaro.org> wrote:
>>
>> Hi Peter,
>>
>> Here are the ARM semi-hosting cleanup patches and a small selection of
>> miscellaneous TCG clean-ups. If your happy taking them all through
>> your tree please do otherwise I'll poke Richard. I'm just trying to
>> reduce the delta for my next iteration of the plugin series.
>>
>> The following patches need review
>>    04 - target arm remove run time semihosting checks
>>    05 - includes remove stale smp max _cpus externs
>>
>> The first is the result of review comments, moving CONFIG_TCG ifdefs
>> around and the second is pretty trivial.
>>
>> Alex Bennée (7):
>>   target/arm: handle M-profile semihosting at translate time
>>   target/arm: handle A-profile T32 semihosting at translate time
>>   target/arm: handle A-profile A32 semihosting at translate time
>
> On closer testing, this patch breaks the semihosting test suite:
>
> $ /home/petmay01/linaro/qemu-from-laptop/qemu/build/arm-clang//arm-linux-user/qemu-arm
>  usertest-a32
> hello world via semi_write0
> qemu: uncaught target signal 11 (Segmentation fault) - core dumped
> Segmentation fault (core dumped)

That must of broken on re-base, I'll re-spin and fix.

>
> so I'm unqueueing the first 4 patches (but have kept the
> misc unrelated other fixes).
>
> thanks
> -- PMM


--
Alex Bennée

On Wed, 28 Aug 2019 at 18:08, Alex Bennée <alex.bennee@linaro.org> wrote:
>
> Hi Peter,
>
> Here are the ARM semi-hosting cleanup patches and a small selection of
> miscellaneous TCG clean-ups. If your happy taking them all through
> your tree please do otherwise I'll poke Richard. I'm just trying to
> reduce the delta for my next iteration of the plugin series.
>
> The following patches need review
>    04 - target arm remove run time semihosting checks
>    05 - includes remove stale smp max _cpus externs
>
> The first is the result of review comments, moving CONFIG_TCG ifdefs
> around and the second is pretty trivial.
>
> Alex Bennée (7):
>   target/arm: handle M-profile semihosting at translate time
>   target/arm: handle A-profile T32 semihosting at translate time
>   target/arm: handle A-profile A32 semihosting at translate time
>   target/arm: remove run time semihosting checks
>   includes: remove stale [smp|max]_cpus externs
>   accel/stubs: reduce headers from tcg-stub
>   include/exec/cpu-defs.h: fix typo
>
> Emilio G. Cota (2):
>   tcg/README: fix typo s/afterwise/afterwards/
>   atomic_template: fix indentation in GEN_ATOMIC_HELPER

Series, except for patch 8, applied to target-arm.next.

thanks
-- PMM