file-posix: fix request_alignment typo

[Qemu-devel] [PATCH] file-posix: fix request_alignment typo

Stefan Hajnoczi posted 1 patch 6 years, 2 months ago

Download mbox

Test docker-clang@ubuntu passed

Test FreeBSD passed

Test checkpatch passed

Test docker-mingw@fedora passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20190827101328.4062-1-stefanha@redhat.com

Maintainers: Max Reitz <mreitz@redhat.com>, Kevin Wolf <kwolf@redhat.com>

block/file-posix.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Expand all Fold all

[Qemu-devel] [PATCH] file-posix: fix request_alignment typo

Posted by Stefan Hajnoczi 6 years, 2 months ago

Fixes: a6b257a08e3d72219f03e461a52152672fec0612
       ("file-posix: Handle undetectable alignment")
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
 block/file-posix.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/block/file-posix.c b/block/file-posix.c
index fbeb0068db..67abd1f01c 100644
--- a/block/file-posix.c
+++ b/block/file-posix.c
@@ -380,7 +380,7 @@ static void raw_probe_alignment(BlockDriverState *bs, int fd, Error **errp)
         for (i = 0; i < ARRAY_SIZE(alignments); i++) {
             align = alignments[i];
             if (raw_is_io_aligned(fd, buf + align, max_align)) {
-                /* Fallback to request_aligment. */
+                /* Fallback to request_alignment. */
                 s->buf_align = (align != 1) ? align : bs->bl.request_alignment;
                 break;
             }
-- 
2.21.0

Re: [Qemu-devel] [PATCH] file-posix: fix request_alignment typo

Posted by Thomas Huth 6 years, 2 months ago

On 27/08/2019 12.13, Stefan Hajnoczi wrote:
> Fixes: a6b257a08e3d72219f03e461a52152672fec0612
>        ("file-posix: Handle undetectable alignment")
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> ---
>  block/file-posix.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/block/file-posix.c b/block/file-posix.c
> index fbeb0068db..67abd1f01c 100644
> --- a/block/file-posix.c
> +++ b/block/file-posix.c
> @@ -380,7 +380,7 @@ static void raw_probe_alignment(BlockDriverState *bs, int fd, Error **errp)
>          for (i = 0; i < ARRAY_SIZE(alignments); i++) {
>              align = alignments[i];
>              if (raw_is_io_aligned(fd, buf + align, max_align)) {
> -                /* Fallback to request_aligment. */
> +                /* Fallback to request_alignment. */
>                  s->buf_align = (align != 1) ? align : bs->bl.request_alignment;
>                  break;
>              }
> 

Reviewed-by: Thomas Huth <thuth@redhat.com>

Re: [Qemu-devel] [PATCH] file-posix: fix request_alignment typo

Posted by Max Reitz 6 years, 2 months ago

On 27.08.19 12:13, Stefan Hajnoczi wrote:
> Fixes: a6b257a08e3d72219f03e461a52152672fec0612
>        ("file-posix: Handle undetectable alignment")
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> ---
>  block/file-posix.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Thanks, applied to my block branch:

https://git.xanclic.moe/XanClic/qemu/commits/branch/block

Max