[Qemu-devel] [PATCH 0/2] virtiofsd: use "fuse_log.h" APIs instead of <err.h>

Stefan Hajnoczi posted 2 patches 4 years, 8 months ago
Failed in applying to current master (apply log)
contrib/virtiofsd/passthrough_ll.c | 143 ++++++++++++++++++-----------
contrib/virtiofsd/seccomp.c        |  15 ++-
2 files changed, 99 insertions(+), 59 deletions(-)
[Qemu-devel] [PATCH 0/2] virtiofsd: use "fuse_log.h" APIs instead of <err.h>
Posted by Stefan Hajnoczi 4 years, 8 months ago
warn(3), warnx(3), err(3), and errx(3) print to stderr even when the --syslog
option was given.  In this case messages to stderr are likely to be lost and
this makes troubleshooting hard.  Use "fuse_log.h" APIs instead of <err.h>.

Stefan Hajnoczi (2):
  virtiofsd: replace warn(3) and warnx(3) with fuse_warning()
  virtiofsd: replace err(3) and errx(3) with fuse_err()

 contrib/virtiofsd/passthrough_ll.c | 143 ++++++++++++++++++-----------
 contrib/virtiofsd/seccomp.c        |  15 ++-
 2 files changed, 99 insertions(+), 59 deletions(-)

-- 
2.21.0


Re: [Qemu-devel] [PATCH 0/2] virtiofsd: use "fuse_log.h" APIs instead of <err.h>
Posted by Philippe Mathieu-Daudé 4 years, 8 months ago
On 8/23/19 11:23 AM, Stefan Hajnoczi wrote:
> warn(3), warnx(3), err(3), and errx(3) print to stderr even when the --syslog
> option was given.  In this case messages to stderr are likely to be lost and
> this makes troubleshooting hard.  Use "fuse_log.h" APIs instead of <err.h>.
> 
> Stefan Hajnoczi (2):
>   virtiofsd: replace warn(3) and warnx(3) with fuse_warning()
>   virtiofsd: replace err(3) and errx(3) with fuse_err()

Series:
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>