[v2] Fix bug in nios2 and m68k semihosting

[Qemu-devel] [PATCH V2 0/2] Fix bug in nios2 and m68k semihosting

Sandra Loosemore posted 2 patches 4 years, 8 months ago

Diff against v1
Download series mbox

Test docker-clang@ubuntu passed

Test FreeBSD passed

Test docker-mingw@fedora passed

Test checkpatch passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20190821175029.21868-1-sandra@codesourcery.com

Maintainers: Laurent Vivier <laurent@vivier.eu>, Marek Vasut <marex@denx.de>, Chris Wulff <crwulff@gmail.com>

target/m68k/m68k-semi.c   | 4 ++--
target/nios2/nios2-semi.c | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)

Expand all Fold all

[Qemu-devel] [PATCH V2 0/2] Fix bug in nios2 and m68k semihosting

Posted by Sandra Loosemore 4 years, 8 months ago

I noticed recently that the exit semihosting call on nios2 was
ignoring its parameter and always returning status 0 instead.  It
turns out the handler was retrieving the value of the wrong register.
Since the nios2 semihosting implementation was basically
cut-and-pasted from that for m68k, I checked m68k also and it had the
same bug.  This set of patches fixes both of them.

There are no changes to the actual patches from V1, only more
informative commit messages with links to the respective semihosting
protocol documents in newlib.

Sandra Loosemore (2):
  target/nios2: Fix bug in semihosted exit handling
  target/m68k: Fix bug in semihosted exit handling

 target/m68k/m68k-semi.c   | 4 ++--
 target/nios2/nios2-semi.c | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

-- 
2.8.1