1. Patchew
  2. QEMU
  3. View series

[Qemu-devel] [PATCH v3 0/4] iotests: use python logging

John Snow posted 4 patches 4 years, 8 months ago
Test docker-clang@ubuntu passed
Test FreeBSD passed
Test asan failed
Test docker-mingw@fedora passed
Test checkpatch failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20190820235243.26092-1-jsnow@redhat.com
Maintainers: Kevin Wolf <kwolf@redhat.com>, Max Reitz <mreitz@redhat.com>
There is a newer version of this series
tests/qemu-iotests/030        |   4 +-
tests/qemu-iotests/149        |   3 +-
tests/qemu-iotests/194        |   3 +-
tests/qemu-iotests/202        |   3 +-
tests/qemu-iotests/203        |   3 +-
tests/qemu-iotests/206        |   2 +-
tests/qemu-iotests/207        |   4 +-
tests/qemu-iotests/208        |   2 +-
tests/qemu-iotests/209        |   2 +-
tests/qemu-iotests/210        |   4 +-
tests/qemu-iotests/211        |   4 +-
tests/qemu-iotests/212        |   4 +-
tests/qemu-iotests/213        |   4 +-
tests/qemu-iotests/216        |   3 +-
tests/qemu-iotests/218        |   2 +-
tests/qemu-iotests/219        |   2 +-
tests/qemu-iotests/222        |   5 +-
tests/qemu-iotests/224        |   3 +-
tests/qemu-iotests/228        |   3 +-
tests/qemu-iotests/234        |   3 +-
tests/qemu-iotests/235        |   4 +-
tests/qemu-iotests/236        |   2 +-
tests/qemu-iotests/237        |   2 +-
tests/qemu-iotests/238        |   2 +
tests/qemu-iotests/242        |   2 +-
tests/qemu-iotests/245        |   1 +
tests/qemu-iotests/245.out    |  24 ++++----
tests/qemu-iotests/246        |   2 +-
tests/qemu-iotests/248        |   2 +-
tests/qemu-iotests/254        |   2 +-
tests/qemu-iotests/255        |   2 +-
tests/qemu-iotests/256        |   2 +-
tests/qemu-iotests/258        |   8 +--
tests/qemu-iotests/262        |   3 +-
tests/qemu-iotests/iotests.py | 108 ++++++++++++++++++++++------------
35 files changed, 124 insertions(+), 105 deletions(-)
[Qemu-devel] [PATCH v3 0/4] iotests: use python logging
Posted by John Snow 4 years, 8 months ago 
This series uses python logging to enable output conditionally on
iotests.log(). We unify an initialization call (which also enables
debugging output for those tests with -d) and then make the switch
inside of iotests.

It will help alleviate the need to create logged/unlogged versions
of all the various helpers we have made.

V3:
 - Rebased for 4.1+; now based on main branch.

V2:
 - Added all of the other python tests I missed to use script_initialize
 - Refactored the common setup as per Ehabkost's suggestion
 - Added protocol arguments to common initialization,
   but this isn't strictly required.

John Snow (4):
  iotests: add script_initialize
  iotest 258: use script_main
  iotests: add protocol support to initialization info
  iotests: use python logging for iotests.log()

 tests/qemu-iotests/030        |   4 +-
 tests/qemu-iotests/149        |   3 +-
 tests/qemu-iotests/194        |   3 +-
 tests/qemu-iotests/202        |   3 +-
 tests/qemu-iotests/203        |   3 +-
 tests/qemu-iotests/206        |   2 +-
 tests/qemu-iotests/207        |   4 +-
 tests/qemu-iotests/208        |   2 +-
 tests/qemu-iotests/209        |   2 +-
 tests/qemu-iotests/210        |   4 +-
 tests/qemu-iotests/211        |   4 +-
 tests/qemu-iotests/212        |   4 +-
 tests/qemu-iotests/213        |   4 +-
 tests/qemu-iotests/216        |   3 +-
 tests/qemu-iotests/218        |   2 +-
 tests/qemu-iotests/219        |   2 +-
 tests/qemu-iotests/222        |   5 +-
 tests/qemu-iotests/224        |   3 +-
 tests/qemu-iotests/228        |   3 +-
 tests/qemu-iotests/234        |   3 +-
 tests/qemu-iotests/235        |   4 +-
 tests/qemu-iotests/236        |   2 +-
 tests/qemu-iotests/237        |   2 +-
 tests/qemu-iotests/238        |   2 +
 tests/qemu-iotests/242        |   2 +-
 tests/qemu-iotests/245        |   1 +
 tests/qemu-iotests/245.out    |  24 ++++----
 tests/qemu-iotests/246        |   2 +-
 tests/qemu-iotests/248        |   2 +-
 tests/qemu-iotests/254        |   2 +-
 tests/qemu-iotests/255        |   2 +-
 tests/qemu-iotests/256        |   2 +-
 tests/qemu-iotests/258        |   8 +--
 tests/qemu-iotests/262        |   3 +-
 tests/qemu-iotests/iotests.py | 108 ++++++++++++++++++++++------------
 35 files changed, 124 insertions(+), 105 deletions(-)

-- 
2.21.0
Re: [Qemu-devel] [PATCH v3 0/4] iotests: use python logging
Posted by no-reply@patchew.org 4 years, 8 months ago 
Patchew URL: https://patchew.org/QEMU/20190820235243.26092-1-jsnow@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Subject: [Qemu-devel] [PATCH v3 0/4] iotests: use python logging
Message-id: 20190820235243.26092-1-jsnow@redhat.com

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/20190820235243.26092-1-jsnow@redhat.com -> patchew/20190820235243.26092-1-jsnow@redhat.com
Submodule 'capstone' (https://git.qemu.org/git/capstone.git) registered for path 'capstone'
Submodule 'dtc' (https://git.qemu.org/git/dtc.git) registered for path 'dtc'
Submodule 'roms/QemuMacDrivers' (https://git.qemu.org/git/QemuMacDrivers.git) registered for path 'roms/QemuMacDrivers'
Submodule 'roms/SLOF' (https://git.qemu.org/git/SLOF.git) registered for path 'roms/SLOF'
Submodule 'roms/edk2' (https://git.qemu.org/git/edk2.git) registered for path 'roms/edk2'
Submodule 'roms/ipxe' (https://git.qemu.org/git/ipxe.git) registered for path 'roms/ipxe'
Submodule 'roms/openbios' (https://git.qemu.org/git/openbios.git) registered for path 'roms/openbios'
Submodule 'roms/openhackware' (https://git.qemu.org/git/openhackware.git) registered for path 'roms/openhackware'
Submodule 'roms/opensbi' (https://git.qemu.org/git/opensbi.git) registered for path 'roms/opensbi'
Submodule 'roms/qemu-palcode' (https://git.qemu.org/git/qemu-palcode.git) registered for path 'roms/qemu-palcode'
Submodule 'roms/seabios' (https://git.qemu.org/git/seabios.git/) registered for path 'roms/seabios'
Submodule 'roms/seabios-hppa' (https://git.qemu.org/git/seabios-hppa.git) registered for path 'roms/seabios-hppa'
Submodule 'roms/sgabios' (https://git.qemu.org/git/sgabios.git) registered for path 'roms/sgabios'
Submodule 'roms/skiboot' (https://git.qemu.org/git/skiboot.git) registered for path 'roms/skiboot'
Submodule 'roms/u-boot' (https://git.qemu.org/git/u-boot.git) registered for path 'roms/u-boot'
Submodule 'roms/u-boot-sam460ex' (https://git.qemu.org/git/u-boot-sam460ex.git) registered for path 'roms/u-boot-sam460ex'
Submodule 'slirp' (https://git.qemu.org/git/libslirp.git) registered for path 'slirp'
Submodule 'tests/fp/berkeley-softfloat-3' (https://git.qemu.org/git/berkeley-softfloat-3.git) registered for path 'tests/fp/berkeley-softfloat-3'
Submodule 'tests/fp/berkeley-testfloat-3' (https://git.qemu.org/git/berkeley-testfloat-3.git) registered for path 'tests/fp/berkeley-testfloat-3'
Submodule 'ui/keycodemapdb' (https://git.qemu.org/git/keycodemapdb.git) registered for path 'ui/keycodemapdb'
Cloning into 'capstone'...
Submodule path 'capstone': checked out '22ead3e0bfdb87516656453336160e0a37b066bf'
Cloning into 'dtc'...
Submodule path 'dtc': checked out '88f18909db731a627456f26d779445f84e449536'
Cloning into 'roms/QemuMacDrivers'...
Submodule path 'roms/QemuMacDrivers': checked out '90c488d5f4a407342247b9ea869df1c2d9c8e266'
Cloning into 'roms/SLOF'...
Submodule path 'roms/SLOF': checked out 'ba1ab360eebe6338bb8d7d83a9220ccf7e213af3'
Cloning into 'roms/edk2'...
Submodule path 'roms/edk2': checked out '20d2e5a125e34fc8501026613a71549b2a1a3e54'
Submodule 'SoftFloat' (https://github.com/ucb-bar/berkeley-softfloat-3.git) registered for path 'ArmPkg/Library/ArmSoftFloatLib/berkeley-softfloat-3'
Submodule 'CryptoPkg/Library/OpensslLib/openssl' (https://github.com/openssl/openssl) registered for path 'CryptoPkg/Library/OpensslLib/openssl'
Cloning into 'ArmPkg/Library/ArmSoftFloatLib/berkeley-softfloat-3'...
Submodule path 'roms/edk2/ArmPkg/Library/ArmSoftFloatLib/berkeley-softfloat-3': checked out 'b64af41c3276f97f0e181920400ee056b9c88037'
Cloning into 'CryptoPkg/Library/OpensslLib/openssl'...
Submodule path 'roms/edk2/CryptoPkg/Library/OpensslLib/openssl': checked out '50eaac9f3337667259de725451f201e784599687'
Submodule 'boringssl' (https://boringssl.googlesource.com/boringssl) registered for path 'boringssl'
Submodule 'krb5' (https://github.com/krb5/krb5) registered for path 'krb5'
Submodule 'pyca.cryptography' (https://github.com/pyca/cryptography.git) registered for path 'pyca-cryptography'
Cloning into 'boringssl'...
Submodule path 'roms/edk2/CryptoPkg/Library/OpensslLib/openssl/boringssl': checked out '2070f8ad9151dc8f3a73bffaa146b5e6937a583f'
Cloning into 'krb5'...
Submodule path 'roms/edk2/CryptoPkg/Library/OpensslLib/openssl/krb5': checked out 'b9ad6c49505c96a088326b62a52568e3484f2168'
Cloning into 'pyca-cryptography'...
Submodule path 'roms/edk2/CryptoPkg/Library/OpensslLib/openssl/pyca-cryptography': checked out '09403100de2f6f1cdd0d484dcb8e620f1c335c8f'
Cloning into 'roms/ipxe'...
Submodule path 'roms/ipxe': checked out 'de4565cbe76ea9f7913a01f331be3ee901bb6e17'
Cloning into 'roms/openbios'...
Submodule path 'roms/openbios': checked out 'c79e0ecb84f4f1ee3f73f521622e264edd1bf174'
Cloning into 'roms/openhackware'...
Submodule path 'roms/openhackware': checked out 'c559da7c8eec5e45ef1f67978827af6f0b9546f5'
Cloning into 'roms/opensbi'...
Submodule path 'roms/opensbi': checked out 'ce228ee0919deb9957192d723eecc8aaae2697c6'
Cloning into 'roms/qemu-palcode'...
Submodule path 'roms/qemu-palcode': checked out 'bf0e13698872450164fa7040da36a95d2d4b326f'
Cloning into 'roms/seabios'...
Submodule path 'roms/seabios': checked out 'a5cab58e9a3fb6e168aba919c5669bea406573b4'
Cloning into 'roms/seabios-hppa'...
Submodule path 'roms/seabios-hppa': checked out '0f4fe84658165e96ce35870fd19fc634e182e77b'
Cloning into 'roms/sgabios'...
Submodule path 'roms/sgabios': checked out 'cbaee52287e5f32373181cff50a00b6c4ac9015a'
Cloning into 'roms/skiboot'...
Submodule path 'roms/skiboot': checked out '261ca8e779e5138869a45f174caa49be6a274501'
Cloning into 'roms/u-boot'...
Submodule path 'roms/u-boot': checked out 'd3689267f92c5956e09cc7d1baa4700141662bff'
Cloning into 'roms/u-boot-sam460ex'...
Submodule path 'roms/u-boot-sam460ex': checked out '60b3916f33e617a815973c5a6df77055b2e3a588'
Cloning into 'slirp'...
Submodule path 'slirp': checked out '126c04acbabd7ad32c2b018fe10dfac2a3bc1210'
Cloning into 'tests/fp/berkeley-softfloat-3'...
Submodule path 'tests/fp/berkeley-softfloat-3': checked out 'b64af41c3276f97f0e181920400ee056b9c88037'
Cloning into 'tests/fp/berkeley-testfloat-3'...
Submodule path 'tests/fp/berkeley-testfloat-3': checked out '5a59dcec19327396a011a17fd924aed4fec416b3'
Cloning into 'ui/keycodemapdb'...
Submodule path 'ui/keycodemapdb': checked out '6b3d716e2b6472eb7189d3220552280ef3d832ce'
Switched to a new branch 'test'
4313fed iotests: use python logging for iotests.log()
931c048 iotests: add protocol support to initialization info
0ab5b9c iotest 258: use script_main
d74dc52 iotests: add script_initialize

=== OUTPUT BEGIN ===
1/4 Checking commit d74dc52c7465 (iotests: add script_initialize)
ERROR: Missing Signed-off-by: line(s)

total: 1 errors, 0 warnings, 356 lines checked

Patch 1/4 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

2/4 Checking commit 0ab5b9cea52b (iotest 258: use script_main)
ERROR: Missing Signed-off-by: line(s)

total: 1 errors, 0 warnings, 17 lines checked

Patch 2/4 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

3/4 Checking commit 931c0485c36f (iotests: add protocol support to initialization info)
ERROR: Missing Signed-off-by: line(s)

total: 1 errors, 0 warnings, 67 lines checked

Patch 3/4 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

4/4 Checking commit 4313fed9d4d0 (iotests: use python logging for iotests.log())
ERROR: Missing Signed-off-by: line(s)

total: 1 errors, 0 warnings, 141 lines checked

Patch 4/4 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20190820235243.26092-1-jsnow@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
Re: [Qemu-devel] [PATCH v3 0/4] iotests: use python logging
Posted by John Snow 4 years, 8 months ago 

On 8/20/19 8:10 PM, no-reply@patchew.org wrote:
> Patchew URL: https://patchew.org/QEMU/20190820235243.26092-1-jsnow@redhat.com/
> 
> 
> 
> Hi,
> 
> This series seems to have some coding style problems. See output below for
> more information:
> 
> Type: series
> Subject: [Qemu-devel] [PATCH v3 0/4] iotests: use python logging
> Message-id: 20190820235243.26092-1-jsnow@redhat.com
> 

I have to remember that apparently git-publish does not seem to "save"
my setting for adding my signed-off-by if I don't explicitly request it.

Sorry about that. You may assume:

Signed-off-by: John Snow <jsnow@redhat.com>

for all patches in this series.
Re: [Qemu-devel] [PATCH v3 0/4] iotests: use python logging
Posted by John Snow 4 years, 8 months ago 
Gentle ping. This should be fairly easy to review, I hope; the worst of
it is making sure that no tests remain that don't engage an entry point
in iotests.py anymore.

On 8/20/19 7:52 PM, John Snow wrote:
> This series uses python logging to enable output conditionally on
> iotests.log(). We unify an initialization call (which also enables
> debugging output for those tests with -d) and then make the switch
> inside of iotests.
> 
> It will help alleviate the need to create logged/unlogged versions
> of all the various helpers we have made.
> 
> V3:
>  - Rebased for 4.1+; now based on main branch.
> 
> V2:
>  - Added all of the other python tests I missed to use script_initialize
>  - Refactored the common setup as per Ehabkost's suggestion
>  - Added protocol arguments to common initialization,
>    but this isn't strictly required.
> 
> John Snow (4):
>   iotests: add script_initialize
>   iotest 258: use script_main
>   iotests: add protocol support to initialization info
>   iotests: use python logging for iotests.log()
> 
>  tests/qemu-iotests/030        |   4 +-
>  tests/qemu-iotests/149        |   3 +-
>  tests/qemu-iotests/194        |   3 +-
>  tests/qemu-iotests/202        |   3 +-
>  tests/qemu-iotests/203        |   3 +-
>  tests/qemu-iotests/206        |   2 +-
>  tests/qemu-iotests/207        |   4 +-
>  tests/qemu-iotests/208        |   2 +-
>  tests/qemu-iotests/209        |   2 +-
>  tests/qemu-iotests/210        |   4 +-
>  tests/qemu-iotests/211        |   4 +-
>  tests/qemu-iotests/212        |   4 +-
>  tests/qemu-iotests/213        |   4 +-
>  tests/qemu-iotests/216        |   3 +-
>  tests/qemu-iotests/218        |   2 +-
>  tests/qemu-iotests/219        |   2 +-
>  tests/qemu-iotests/222        |   5 +-
>  tests/qemu-iotests/224        |   3 +-
>  tests/qemu-iotests/228        |   3 +-
>  tests/qemu-iotests/234        |   3 +-
>  tests/qemu-iotests/235        |   4 +-
>  tests/qemu-iotests/236        |   2 +-
>  tests/qemu-iotests/237        |   2 +-
>  tests/qemu-iotests/238        |   2 +
>  tests/qemu-iotests/242        |   2 +-
>  tests/qemu-iotests/245        |   1 +
>  tests/qemu-iotests/245.out    |  24 ++++----
>  tests/qemu-iotests/246        |   2 +-
>  tests/qemu-iotests/248        |   2 +-
>  tests/qemu-iotests/254        |   2 +-
>  tests/qemu-iotests/255        |   2 +-
>  tests/qemu-iotests/256        |   2 +-
>  tests/qemu-iotests/258        |   8 +--
>  tests/qemu-iotests/262        |   3 +-
>  tests/qemu-iotests/iotests.py | 108 ++++++++++++++++++++++------------
>  35 files changed, 124 insertions(+), 105 deletions(-)
>

Patchew 2.1-devel-0870f84

© 2016 - 2024 Red Hat, Inc.