Any particular reason? I guess an "itch."
On 8/19/19 4:18 PM, Max Reitz wrote:
> Signed-off-by: Max Reitz <mreitz@redhat.com>
> ---
> tests/qemu-iotests/iotests.py | 14 +++++++++++---
> 1 file changed, 11 insertions(+), 3 deletions(-)
>
> diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py
> index 8f315538e9..f6492b355f 100644
> --- a/tests/qemu-iotests/iotests.py
> +++ b/tests/qemu-iotests/iotests.py
> @@ -884,9 +884,17 @@ def qemu_pipe(*args):
> def supported_formats(read_only=False):
> '''Set 'read_only' to True to check ro-whitelist
> Otherwise, rw-whitelist is checked'''
> - format_message = qemu_pipe("-drive", "format=help")
> - line = 1 if read_only else 0
> - return format_message.splitlines()[line].split(":")[1].split()
> +
> + if not hasattr(supported_formats, "formats"):
> + supported_formats.formats = {}
> +
> + if read_only not in supported_formats.formats:
> + format_message = qemu_pipe("-drive", "format=help")
> + line = 1 if read_only else 0
> + supported_formats.formats[read_only] = \
> + format_message.splitlines()[line].split(":")[1].split()
> +
Seems a little odd to use a boolean as a dict key, but I guess it works
and is fine.
> + return supported_formats.formats[read_only]
>
> def skip_if_unsupported(required_formats=[], read_only=False):
> '''Skip Test Decorator
>
Eh, why not.
Reviewed-by: John Snow <jsnow@redhat.com>