BZ#1733165: network-get-interfaces Chinese NIC name

[Qemu-devel] [PATCH 0/1] BZ#1733165: network-get-interfaces Chinese NIC name

Bishara AbuHattoum posted 1 patch 6 years, 2 months ago

Download series mbox

Test docker-clang@ubuntu passed

Test FreeBSD passed

Test asan passed

Test docker-mingw@fedora passed

Test checkpatch passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20190819131620.1302-1-bishara@daynix.com

Maintainers: Michael Roth <mdroth@linux.vnet.ibm.com>

qga/commands-win32.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)

Expand all Fold all

[Qemu-devel] [PATCH 0/1] BZ#1733165: network-get-interfaces Chinese NIC name

Posted by Bishara AbuHattoum 6 years, 2 months ago

https://bugzilla.redhat.com/show_bug.cgi?id=1733165

Uppon renaming a NIC to a Chinese name and invoking the network get
interfaces command, guest-network-get-interfaces, the returned name
field has the (\ufffd) value for each Chinese character the NIC name
had, this value is the indication that the code page does not have the
decoding information for the given character.

The suggested fix is to use the CP_UTF8 code page for decoding the NIC's
name instead of the CP_ACP code page.

Bishara AbuHattoum (1):
  qga-win: network-get-interfaces command name field bug fix

 qga/commands-win32.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

-- 
2.17.2

Re: [Qemu-devel] [PATCH 0/1] BZ#1733165: network-get-interfaces Chinese NIC name

Posted by Bishara AbuHattoum 6 years, 2 months ago

PING

On Mon, Aug 19, 2019 at 4:22 PM Bishara AbuHattoum <bishara@daynix.com>
wrote:

> https://bugzilla.redhat.com/show_bug.cgi?id=1733165
>
> Uppon renaming a NIC to a Chinese name and invoking the network get
> interfaces command, guest-network-get-interfaces, the returned name
> field has the (\ufffd) value for each Chinese character the NIC name
> had, this value is the indication that the code page does not have the
> decoding information for the given character.
>
> The suggested fix is to use the CP_UTF8 code page for decoding the NIC's
> name instead of the CP_ACP code page.
>
> Bishara AbuHattoum (1):
>   qga-win: network-get-interfaces command name field bug fix
>
>  qga/commands-win32.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
>
> --
> 2.17.2
>
>
>