[v1] Fix MemoryRegionSection alignment and comparison

[Qemu-devel] [PATCH 0/2] Fix MemoryRegionSection alignment and comparison

Dr. David Alan Gilbert (git) posted 2 patches 4 years, 8 months ago

Diff against v2
Download series mbox

Test docker-mingw@fedora passed

Test FreeBSD passed

Test asan passed

Test docker-clang@ubuntu passed

Test checkpatch passed

Test s390x failed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20190813102936.32195-1-dgilbert@redhat.com

Maintainers: Paolo Bonzini <pbonzini@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>

There is a newer version of this series

hw/virtio/vhost.c     |  9 +++++++--
include/exec/memory.h | 14 +++++++++++++-
2 files changed, 20 insertions(+), 3 deletions(-)

Expand all Fold all

[Qemu-devel] [PATCH 0/2] Fix MemoryRegionSection alignment and comparison

Posted by Dr. David Alan Gilbert (git) 4 years, 8 months ago

From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>

This fixes a symptom I've seen on vhost-user on aarch64 where the
daemon would be falsely notified of memory region changes that didn't
exist.
The underlying problem was me memcmp'ing MemoryRegionSections even
though they had padding in.

(Discovered while getting virtiofs working on aarch)

Dave


Dr. David Alan Gilbert (2):
  memory: Align and add helper for comparing MemoryRegionSections
  vhost: Fix memory region section comparison

 hw/virtio/vhost.c     |  9 +++++++--
 include/exec/memory.h | 14 +++++++++++++-
 2 files changed, 20 insertions(+), 3 deletions(-)

-- 
2.21.0

Re: [Qemu-devel] [PATCH 0/2] Fix MemoryRegionSection alignment and comparison

Posted by Paolo Bonzini 4 years, 8 months ago

On 13/08/19 12:29, Dr. David Alan Gilbert (git) wrote:
> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
> 
> This fixes a symptom I've seen on vhost-user on aarch64 where the
> daemon would be falsely notified of memory region changes that didn't
> exist.
> The underlying problem was me memcmp'ing MemoryRegionSections even
> though they had padding in.
> 
> (Discovered while getting virtiofs working on aarch)
> 
> Dave
> 
> 
> Dr. David Alan Gilbert (2):
>   memory: Align and add helper for comparing MemoryRegionSections
>   vhost: Fix memory region section comparison
> 
>  hw/virtio/vhost.c     |  9 +++++++--
>  include/exec/memory.h | 14 +++++++++++++-
>  2 files changed, 20 insertions(+), 3 deletions(-)
> 

Acked-by: Paolo Bonzini <pbonzini@redhat.com>

I think it can be merged through the vhost tree.

Paolo