[v1] decodetree improvements

[Qemu-devel] [PATCH 0/3] decodetree improvements

Richard Henderson posted 3 patches 6 years, 3 months ago

Diff against v1 v1 v2
Download series mbox

Test FreeBSD passed

Test docker-mingw@fedora passed

Test asan passed

Test docker-clang@ubuntu passed

Test checkpatch passed

Test s390x failed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20190809154153.31763-1-richard.henderson@linaro.org

Maintainers: Paolo Bonzini <pbonzini@redhat.com>, Sagar Karandikar <sagark@eecs.berkeley.edu>, Eduardo Habkost <ehabkost@redhat.com>, Palmer Dabbelt <palmer@sifive.com>, Alistair Francis <Alistair.Francis@wdc.com>, Richard Henderson <rth@twiddle.net>, Cleber Rosa <crosa@redhat.com>, Bastian Koppelmann <kbastian@mail.uni-paderborn.de>

There is a newer version of this series

target/riscv/translate.c          | 19 +-------
docs/devel/decodetree.rst         |  8 +++-
scripts/decodetree.py             | 76 ++++++++++++++++++++++++++-----
tests/decode/err_field6.decode    |  5 ++
tests/decode/succ_function.decode |  6 +++
5 files changed, 83 insertions(+), 31 deletions(-)
create mode 100644 tests/decode/err_field6.decode
create mode 100644 tests/decode/succ_function.decode

Expand all Fold all

[Qemu-devel] [PATCH 0/3] decodetree improvements

Posted by Richard Henderson 6 years, 3 months ago

These are split out from my decodetree coversion of the AArch32
base instruction sets.

The first patch has been tidied per review from Peter.  I now
diagnose nonsense fields containing no bits.  I eliminated the
unused integer argument passed to the named function.  I improved
the documentation.

The second patch is new, a suggestion from Phillipe.  This then
enables the third patch, tidying up the existing usage in riscv.


r~


Richard Henderson (3):
  decodetree: Allow !function with no input bits
  decodetree: Suppress redundant declaration warnings
  target/riscv: Remove redundant declaration pragmas

 target/riscv/translate.c          | 19 +-------
 docs/devel/decodetree.rst         |  8 +++-
 scripts/decodetree.py             | 76 ++++++++++++++++++++++++++-----
 tests/decode/err_field6.decode    |  5 ++
 tests/decode/succ_function.decode |  6 +++
 5 files changed, 83 insertions(+), 31 deletions(-)
 create mode 100644 tests/decode/err_field6.decode
 create mode 100644 tests/decode/succ_function.decode

-- 
2.17.1