[v2] Tame a few "touch this, recompile the world" headers

[Qemu-devel] [PATCH v2 10/29] ide: Include hw/ide/internal a bit less outside hw/ide/

Markus Armbruster posted 29 patches 6 years, 6 months ago

Diff against v1 v3 v4
Download mbox

Maintainers: Giuseppe Lettieri <g.lettieri@iet.unipi.it>, Andrzej Zaborowski <balrogg@gmail.com>, Stafford Horne <shorne@gmail.com>, Xiao Guangrong <xiaoguangrong.eric@gmail.com>, Aleksandar Markovic <amarkovic@wavecomp.com>, Riku Voipio <riku.voipio@iki.fi>, Michael Walle <michael@walle.cc>, Juan Quintela <quintela@redhat.com>, Pierre Morel <pmorel@linux.ibm.com>, Bastian Koppelmann <kbastian@mail.uni-paderborn.de>, "Philippe Mathieu-Daudé" <f4bug@amsat.org>, Markus Armbruster <armbru@redhat.com>, BALATON Zoltan <balaton@eik.bme.hu>, Stefan Weil <sw@weilnetz.de>, Corey Minyard <minyard@acm.org>, Leif Lindholm <leif.lindholm@linaro.org>, Beniamino Galvani <b.galvani@gmail.com>, "Michael S. Tsirkin" <mst@redhat.com>, Amit Shah <amit@kernel.org>, Sagar Karandikar <sagark@eecs.berkeley.edu>, Collin Walling <walling@linux.ibm.com>, "Daniel P. Berrangé" <berrange@redhat.com>, Yuval Shaia <yuval.shaia@oracle.com>, Liu Yuan <namei.unix@gmail.com>, Alex Williamson <alex.williamson@redhat.com>, Peter Chubb <peter.chubb@nicta.com.au>, Anthony Perard <anthony.perard@citrix.com>, Andrew Jeffery <andrew@aj.id.au>, Alistair Francis <Alistair.Francis@wdc.com>, Richard Henderson <rth@twiddle.net>, Luigi Rizzo <rizzo@iet.unipi.it>, Anthony Green <green@moxielogic.com>, Shannon Zhao <shannon.zhaosl@gmail.com>, Peter Lieven <pl@kamp.de>, Jason Wang <jasowang@redhat.com>, Laurent Vivier <laurent@vivier.eu>, Corey Minyard <cminyard@mvista.com>, Vincenzo Maffione <v.maffione@gmail.com>, James Hogan <jhogan@kernel.org>, Gonglei <arei.gonglei@huawei.com>, Christian Borntraeger <borntraeger@de.ibm.com>, Fabien Chouteau <chouteau@adacore.com>, "Cédric Le Goater" <clg@kaod.org>, David Gibson <david@gibson.dropbear.id.au>, Marek Vasut <marex@denx.de>, Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>, Alberto Garcia <berto@igalia.com>, Laurent Vivier <lvivier@redhat.com>, Max Filippov <jcmvbkbc@gmail.com>, KONRAD Frederic <frederic.konrad@adacore.com>, "Hervé Poussineau" <hpoussin@reactos.org>, Keith Busch <keith.busch@intel.com>, Stefano Stabellini <sstabellini@kernel.org>, zhanghailiang <zhang.zhanghailiang@huawei.com>, Eric Blake <eblake@redhat.com>, David Hildenbrand <david@redhat.com>, Paul Burton <pburton@wavecomp.com>, Jan Kiszka <jan.kiszka@web.de>, Igor Mitsyanko <i.mitsyanko@gmail.com>, Joel Stanley <joel@jms.id.au>, Stefan Berger <stefanb@linux.ibm.com>, Peter Maydell <peter.maydell@linaro.org>, Jia Liu <proljc@gmail.com>, Igor Mammedov <imammedo@redhat.com>, Helge Deller <deller@gmx.de>, Fam Zheng <fam@euphon.net>, Jiri Pirko <jiri@resnulli.us>, "Edgar E. Iglesias" <edgar.iglesias@gmail.com>, Magnus Damm <magnus.damm@gmail.com>, Samuel Thibault <samuel.thibault@ens-lyon.org>, Stefan Hajnoczi <stefanha@redhat.com>, Xie Changlong <xiechanglong.d@gmail.com>, Thomas Huth <huth@tuxfamily.org>, Marcelo Tosatti <mtosatti@redhat.com>, "Philippe Mathieu-Daudé" <philmd@redhat.com>, John Snow <jsnow@redhat.com>, Guan Xuetao <gxt@mprc.pku.edu.cn>, Palmer Dabbelt <palmer@sifive.com>, Gerd Hoffmann <kraxel@redhat.com>, Andrey Smirnov <andrew.smirnov@gmail.com>, Thomas Huth <thuth@redhat.com>, Hannes Reinecke <hare@suse.com>, Jiri Slaby <jslaby@suse.cz>, Kevin Wolf <kwolf@redhat.com>, Pavel Dovgalyuk <pavel.dovgaluk@ispras.ru>, Subbaraya Sundeep <sundeep.lkml@gmail.com>, Andrew Baumann <Andrew.Baumann@microsoft.com>, Alistair Francis <alistair@alistair23.me>, Rob Herring <robh@kernel.org>, Halil Pasic <pasic@linux.ibm.com>, Paolo Bonzini <pbonzini@redhat.com>, Aurelien Jarno <aurelien@aurel32.net>, Dmitry Fleytman <dmitry.fleytman@gmail.com>, Cornelia Huck <cohuck@redhat.com>, "Alex Bennée" <alex.bennee@linaro.org>, Eduardo Habkost <ehabkost@redhat.com>, Radoslaw Biernacki <radoslaw.biernacki@linaro.org>, Eric Farman <farman@linux.ibm.com>, Wen Congyang <wencongyang2@huawei.com>, Max Reitz <mreitz@redhat.com>, Chris Wulff <crwulff@gmail.com>, Eric Auger <eric.auger@redhat.com>, Greg Kurz <groug@kaod.org>, Paul Durrant <paul.durrant@citrix.com>, Antony Pavlov <antonynpavlov@gmail.com>, Michael Roth <mdroth@linux.vnet.ibm.com>, Marcel Apfelbaum <marcel.apfelbaum@gmail.com>, Jean-Christophe Dubois <jcd@tribudubois.net>, Tony Krowiak <akrowiak@linux.ibm.com>, Ben Warren <ben@skyportsystems.com>, "Marc-André Lureau" <marcandre.lureau@redhat.com>, Aleksandar Rikalo <arikalo@wavecomp.com>, "Dr. David Alan Gilbert" <dgilbert@redhat.com>, Laszlo Ersek <lersek@redhat.com>, Artyom Tarasenko <atar4qemu@gmail.com>

There is a newer version of this series

Expand all Fold all

[Qemu-devel] [PATCH v2 10/29] ide: Include hw/ide/internal a bit less outside hw/ide/

Posted by Markus Armbruster 6 years, 6 months ago

According to hw/ide/internal's file comment, only files in hw/ide/ are
supposed to include it.  Drag reality slightly closer to supposition.

Three includes outside hw/ide remain: hw/arm/sbsa-ref.c,
include/hw/ide/pci.h, and include/hw/misc/macio/macio.h.  Turns out
board code needs ide-internal.h to wire up IDE stuff.  More cleanup is
needed.  Left for another day.

Cc: John Snow <jsnow@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
 hw/arm/allwinner-a10.c         | 1 +
 hw/arm/cubieboard.c            | 1 +
 hw/arm/xlnx-zynqmp.c           | 1 +
 hw/ide/ahci_internal.h         | 1 +
 hw/ppc/mac.h                   | 1 -
 include/hw/arm/allwinner-a10.h | 1 -
 include/hw/arm/xlnx-zynqmp.h   | 1 -
 include/hw/misc/mos6522.h      | 1 -
 8 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/hw/arm/allwinner-a10.c b/hw/arm/allwinner-a10.c
index 35e906ca54..3b0d3eccdd 100644
--- a/hw/arm/allwinner-a10.c
+++ b/hw/arm/allwinner-a10.c
@@ -16,6 +16,7 @@
  */
 
 #include "qemu/osdep.h"
+#include "exec/address-spaces.h"
 #include "qapi/error.h"
 #include "qemu/module.h"
 #include "cpu.h"
diff --git a/hw/arm/cubieboard.c b/hw/arm/cubieboard.c
index f7c8a5985a..38e0ca0f53 100644
--- a/hw/arm/cubieboard.c
+++ b/hw/arm/cubieboard.c
@@ -16,6 +16,7 @@
  */
 
 #include "qemu/osdep.h"
+#include "exec/address-spaces.h"
 #include "qapi/error.h"
 #include "cpu.h"
 #include "hw/sysbus.h"
diff --git a/hw/arm/xlnx-zynqmp.c b/hw/arm/xlnx-zynqmp.c
index a60830d37a..0f587e63d3 100644
--- a/hw/arm/xlnx-zynqmp.c
+++ b/hw/arm/xlnx-zynqmp.c
@@ -24,6 +24,7 @@
 #include "hw/boards.h"
 #include "exec/address-spaces.h"
 #include "sysemu/kvm.h"
+#include "sysemu/sysemu.h"
 #include "kvm_arm.h"
 
 #define GIC_NUM_SPI_INTR 160
diff --git a/hw/ide/ahci_internal.h b/hw/ide/ahci_internal.h
index 95ecddcd3c..73424516da 100644
--- a/hw/ide/ahci_internal.h
+++ b/hw/ide/ahci_internal.h
@@ -25,6 +25,7 @@
 #define HW_IDE_AHCI_INTERNAL_H
 
 #include "hw/ide/ahci.h"
+#include "hw/ide/internal.h"
 #include "hw/sysbus.h"
 
 #define AHCI_MEM_BAR_SIZE         0x1000
diff --git a/hw/ppc/mac.h b/hw/ppc/mac.h
index a741300ac9..6af87d1fa0 100644
--- a/hw/ppc/mac.h
+++ b/hw/ppc/mac.h
@@ -30,7 +30,6 @@
 #include "exec/memory.h"
 #include "hw/boards.h"
 #include "hw/sysbus.h"
-#include "hw/ide/internal.h"
 #include "hw/input/adb.h"
 #include "hw/misc/mos6522.h"
 #include "hw/pci/pci_host.h"
diff --git a/include/hw/arm/allwinner-a10.h b/include/hw/arm/allwinner-a10.h
index 7182ce5c4b..101b72a71d 100644
--- a/include/hw/arm/allwinner-a10.h
+++ b/include/hw/arm/allwinner-a10.h
@@ -7,7 +7,6 @@
 #include "hw/timer/allwinner-a10-pit.h"
 #include "hw/intc/allwinner-a10-pic.h"
 #include "hw/net/allwinner_emac.h"
-#include "hw/ide/pci.h"
 #include "hw/ide/ahci.h"
 
 #include "sysemu/sysemu.h"
diff --git a/include/hw/arm/xlnx-zynqmp.h b/include/hw/arm/xlnx-zynqmp.h
index 6cb65e7537..d7483c3b42 100644
--- a/include/hw/arm/xlnx-zynqmp.h
+++ b/include/hw/arm/xlnx-zynqmp.h
@@ -22,7 +22,6 @@
 #include "hw/intc/arm_gic.h"
 #include "hw/net/cadence_gem.h"
 #include "hw/char/cadence_uart.h"
-#include "hw/ide/pci.h"
 #include "hw/ide/ahci.h"
 #include "hw/sd/sdhci.h"
 #include "hw/ssi/xilinx_spips.h"
diff --git a/include/hw/misc/mos6522.h b/include/hw/misc/mos6522.h
index 03d9f0c059..493c907537 100644
--- a/include/hw/misc/mos6522.h
+++ b/include/hw/misc/mos6522.h
@@ -29,7 +29,6 @@
 
 #include "exec/memory.h"
 #include "hw/sysbus.h"
-#include "hw/ide/internal.h"
 #include "hw/input/adb.h"
 
 /* Bits in ACR */
-- 
2.21.0

Re: [Qemu-devel] [PATCH v2 10/29] ide: Include hw/ide/internal a bit less outside hw/ide/

Posted by John Snow 6 years, 6 months ago


On 8/6/19 11:14 AM, Markus Armbruster wrote:
> According to hw/ide/internal's file comment, only files in hw/ide/ are
> supposed to include it.  Drag reality slightly closer to supposition.
> 

The downside of having your internal include ripped away and stuck in
the includes/ folder.

> Three includes outside hw/ide remain: hw/arm/sbsa-ref.c,
> include/hw/ide/pci.h, and include/hw/misc/macio/macio.h.  Turns out
> board code needs ide-internal.h to wire up IDE stuff.  More cleanup is
> needed.  Left for another day.
> 

Yuh. This is mostly why I haven't touched it.

> Cc: John Snow <jsnow@redhat.com>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>

Thank you.

Reviewed-by: John Snow <jsnow@redhat.com>

> ---
>  hw/arm/allwinner-a10.c         | 1 +
>  hw/arm/cubieboard.c            | 1 +
>  hw/arm/xlnx-zynqmp.c           | 1 +
>  hw/ide/ahci_internal.h         | 1 +
>  hw/ppc/mac.h                   | 1 -
>  include/hw/arm/allwinner-a10.h | 1 -
>  include/hw/arm/xlnx-zynqmp.h   | 1 -
>  include/hw/misc/mos6522.h      | 1 -
>  8 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/hw/arm/allwinner-a10.c b/hw/arm/allwinner-a10.c
> index 35e906ca54..3b0d3eccdd 100644
> --- a/hw/arm/allwinner-a10.c
> +++ b/hw/arm/allwinner-a10.c
> @@ -16,6 +16,7 @@
>   */
>  
>  #include "qemu/osdep.h"
> +#include "exec/address-spaces.h"
>  #include "qapi/error.h"
>  #include "qemu/module.h"
>  #include "cpu.h"
> diff --git a/hw/arm/cubieboard.c b/hw/arm/cubieboard.c
> index f7c8a5985a..38e0ca0f53 100644
> --- a/hw/arm/cubieboard.c
> +++ b/hw/arm/cubieboard.c
> @@ -16,6 +16,7 @@
>   */
>  
>  #include "qemu/osdep.h"
> +#include "exec/address-spaces.h"
>  #include "qapi/error.h"
>  #include "cpu.h"
>  #include "hw/sysbus.h"
> diff --git a/hw/arm/xlnx-zynqmp.c b/hw/arm/xlnx-zynqmp.c
> index a60830d37a..0f587e63d3 100644
> --- a/hw/arm/xlnx-zynqmp.c
> +++ b/hw/arm/xlnx-zynqmp.c
> @@ -24,6 +24,7 @@
>  #include "hw/boards.h"
>  #include "exec/address-spaces.h"
>  #include "sysemu/kvm.h"
> +#include "sysemu/sysemu.h"
>  #include "kvm_arm.h"
>  
>  #define GIC_NUM_SPI_INTR 160
> diff --git a/hw/ide/ahci_internal.h b/hw/ide/ahci_internal.h
> index 95ecddcd3c..73424516da 100644
> --- a/hw/ide/ahci_internal.h
> +++ b/hw/ide/ahci_internal.h
> @@ -25,6 +25,7 @@
>  #define HW_IDE_AHCI_INTERNAL_H
>  
>  #include "hw/ide/ahci.h"
> +#include "hw/ide/internal.h"
>  #include "hw/sysbus.h"
>  
>  #define AHCI_MEM_BAR_SIZE         0x1000
> diff --git a/hw/ppc/mac.h b/hw/ppc/mac.h
> index a741300ac9..6af87d1fa0 100644
> --- a/hw/ppc/mac.h
> +++ b/hw/ppc/mac.h
> @@ -30,7 +30,6 @@
>  #include "exec/memory.h"
>  #include "hw/boards.h"
>  #include "hw/sysbus.h"
> -#include "hw/ide/internal.h"
>  #include "hw/input/adb.h"
>  #include "hw/misc/mos6522.h"
>  #include "hw/pci/pci_host.h"
> diff --git a/include/hw/arm/allwinner-a10.h b/include/hw/arm/allwinner-a10.h
> index 7182ce5c4b..101b72a71d 100644
> --- a/include/hw/arm/allwinner-a10.h
> +++ b/include/hw/arm/allwinner-a10.h
> @@ -7,7 +7,6 @@
>  #include "hw/timer/allwinner-a10-pit.h"
>  #include "hw/intc/allwinner-a10-pic.h"
>  #include "hw/net/allwinner_emac.h"
> -#include "hw/ide/pci.h"
>  #include "hw/ide/ahci.h"
>  
>  #include "sysemu/sysemu.h"
> diff --git a/include/hw/arm/xlnx-zynqmp.h b/include/hw/arm/xlnx-zynqmp.h
> index 6cb65e7537..d7483c3b42 100644
> --- a/include/hw/arm/xlnx-zynqmp.h
> +++ b/include/hw/arm/xlnx-zynqmp.h
> @@ -22,7 +22,6 @@
>  #include "hw/intc/arm_gic.h"
>  #include "hw/net/cadence_gem.h"
>  #include "hw/char/cadence_uart.h"
> -#include "hw/ide/pci.h"
>  #include "hw/ide/ahci.h"
>  #include "hw/sd/sdhci.h"
>  #include "hw/ssi/xilinx_spips.h"
> diff --git a/include/hw/misc/mos6522.h b/include/hw/misc/mos6522.h
> index 03d9f0c059..493c907537 100644
> --- a/include/hw/misc/mos6522.h
> +++ b/include/hw/misc/mos6522.h
> @@ -29,7 +29,6 @@
>  
>  #include "exec/memory.h"
>  #include "hw/sysbus.h"
> -#include "hw/ide/internal.h"
>  #include "hw/input/adb.h"
>  
>  /* Bits in ACR */
>

Re: [Qemu-devel] [PATCH v2 10/29] ide: Include hw/ide/internal a bit less outside hw/ide/

Posted by Philippe Mathieu-Daudé 6 years, 6 months ago

On 8/6/19 11:40 PM, John Snow wrote:
> On 8/6/19 11:14 AM, Markus Armbruster wrote:
>> According to hw/ide/internal's file comment, only files in hw/ide/ are
>> supposed to include it.  Drag reality slightly closer to supposition.
>>
> 
> The downside of having your internal include ripped away and stuck in
> the includes/ folder.

Not sure this is a 'downside', it looks more than proper design issue to
me (often the case with very old subsystems).

>> Three includes outside hw/ide remain: hw/arm/sbsa-ref.c,
>> include/hw/ide/pci.h, and include/hw/misc/macio/macio.h.  Turns out
>> board code needs ide-internal.h to wire up IDE stuff.  More cleanup is
>> needed.  Left for another day.
>>
> 
> Yuh. This is mostly why I haven't touched it.
> 
>> Cc: John Snow <jsnow@redhat.com>
>> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> 
> Thank you.
> 
> Reviewed-by: John Snow <jsnow@redhat.com>

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>

>> ---
>>  hw/arm/allwinner-a10.c         | 1 +
>>  hw/arm/cubieboard.c            | 1 +
>>  hw/arm/xlnx-zynqmp.c           | 1 +
>>  hw/ide/ahci_internal.h         | 1 +
>>  hw/ppc/mac.h                   | 1 -
>>  include/hw/arm/allwinner-a10.h | 1 -
>>  include/hw/arm/xlnx-zynqmp.h   | 1 -
>>  include/hw/misc/mos6522.h      | 1 -
>>  8 files changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/hw/arm/allwinner-a10.c b/hw/arm/allwinner-a10.c
>> index 35e906ca54..3b0d3eccdd 100644
>> --- a/hw/arm/allwinner-a10.c
>> +++ b/hw/arm/allwinner-a10.c
>> @@ -16,6 +16,7 @@
>>   */
>>  
>>  #include "qemu/osdep.h"
>> +#include "exec/address-spaces.h"
>>  #include "qapi/error.h"
>>  #include "qemu/module.h"
>>  #include "cpu.h"
>> diff --git a/hw/arm/cubieboard.c b/hw/arm/cubieboard.c
>> index f7c8a5985a..38e0ca0f53 100644
>> --- a/hw/arm/cubieboard.c
>> +++ b/hw/arm/cubieboard.c
>> @@ -16,6 +16,7 @@
>>   */
>>  
>>  #include "qemu/osdep.h"
>> +#include "exec/address-spaces.h"
>>  #include "qapi/error.h"
>>  #include "cpu.h"
>>  #include "hw/sysbus.h"
>> diff --git a/hw/arm/xlnx-zynqmp.c b/hw/arm/xlnx-zynqmp.c
>> index a60830d37a..0f587e63d3 100644
>> --- a/hw/arm/xlnx-zynqmp.c
>> +++ b/hw/arm/xlnx-zynqmp.c
>> @@ -24,6 +24,7 @@
>>  #include "hw/boards.h"
>>  #include "exec/address-spaces.h"
>>  #include "sysemu/kvm.h"
>> +#include "sysemu/sysemu.h"
>>  #include "kvm_arm.h"
>>  
>>  #define GIC_NUM_SPI_INTR 160
>> diff --git a/hw/ide/ahci_internal.h b/hw/ide/ahci_internal.h
>> index 95ecddcd3c..73424516da 100644
>> --- a/hw/ide/ahci_internal.h
>> +++ b/hw/ide/ahci_internal.h
>> @@ -25,6 +25,7 @@
>>  #define HW_IDE_AHCI_INTERNAL_H
>>  
>>  #include "hw/ide/ahci.h"
>> +#include "hw/ide/internal.h"
>>  #include "hw/sysbus.h"
>>  
>>  #define AHCI_MEM_BAR_SIZE         0x1000
>> diff --git a/hw/ppc/mac.h b/hw/ppc/mac.h
>> index a741300ac9..6af87d1fa0 100644
>> --- a/hw/ppc/mac.h
>> +++ b/hw/ppc/mac.h
>> @@ -30,7 +30,6 @@
>>  #include "exec/memory.h"
>>  #include "hw/boards.h"
>>  #include "hw/sysbus.h"
>> -#include "hw/ide/internal.h"
>>  #include "hw/input/adb.h"
>>  #include "hw/misc/mos6522.h"
>>  #include "hw/pci/pci_host.h"
>> diff --git a/include/hw/arm/allwinner-a10.h b/include/hw/arm/allwinner-a10.h
>> index 7182ce5c4b..101b72a71d 100644
>> --- a/include/hw/arm/allwinner-a10.h
>> +++ b/include/hw/arm/allwinner-a10.h
>> @@ -7,7 +7,6 @@
>>  #include "hw/timer/allwinner-a10-pit.h"
>>  #include "hw/intc/allwinner-a10-pic.h"
>>  #include "hw/net/allwinner_emac.h"
>> -#include "hw/ide/pci.h"
>>  #include "hw/ide/ahci.h"
>>  
>>  #include "sysemu/sysemu.h"
>> diff --git a/include/hw/arm/xlnx-zynqmp.h b/include/hw/arm/xlnx-zynqmp.h
>> index 6cb65e7537..d7483c3b42 100644
>> --- a/include/hw/arm/xlnx-zynqmp.h
>> +++ b/include/hw/arm/xlnx-zynqmp.h
>> @@ -22,7 +22,6 @@
>>  #include "hw/intc/arm_gic.h"
>>  #include "hw/net/cadence_gem.h"
>>  #include "hw/char/cadence_uart.h"
>> -#include "hw/ide/pci.h"
>>  #include "hw/ide/ahci.h"
>>  #include "hw/sd/sdhci.h"
>>  #include "hw/ssi/xilinx_spips.h"
>> diff --git a/include/hw/misc/mos6522.h b/include/hw/misc/mos6522.h
>> index 03d9f0c059..493c907537 100644
>> --- a/include/hw/misc/mos6522.h
>> +++ b/include/hw/misc/mos6522.h
>> @@ -29,7 +29,6 @@
>>  
>>  #include "exec/memory.h"
>>  #include "hw/sysbus.h"
>> -#include "hw/ide/internal.h"
>>  #include "hw/input/adb.h"
>>  
>>  /* Bits in ACR */
>>
>

Re: [Qemu-devel] [PATCH v2 10/29] ide: Include hw/ide/internal a bit less outside hw/ide/

Posted by John Snow 6 years, 6 months ago

On 8/7/19 8:29 AM, Philippe Mathieu-Daudé wrote:
> On 8/6/19 11:40 PM, John Snow wrote:
>> On 8/6/19 11:14 AM, Markus Armbruster wrote:
>>> According to hw/ide/internal's file comment, only files in hw/ide/ are
>>> supposed to include it.  Drag reality slightly closer to supposition.
>>>
>>
>> The downside of having your internal include ripped away and stuck in
>> the includes/ folder.
> 
> Not sure this is a 'downside', it looks more than proper design issue to
> me (often the case with very old subsystems).
> 

For context, the "internal" header here used to actually be internal. It
was moved wholesale to the "public" includes directory, which makes it
easier for people to start stealing things from inside of it, which
causes trouble.

--js