[Qemu-devel] [PULL 3/3] docs: correct kconfig option

Paolo Bonzini posted 3 patches 6 years, 6 months ago
Maintainers: Eduardo Habkost <ehabkost@redhat.com>, Richard Henderson <rth@twiddle.net>, Fam Zheng <fam@euphon.net>, Paolo Bonzini <pbonzini@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>, Marcelo Tosatti <mtosatti@redhat.com>
[Qemu-devel] [PULL 3/3] docs: correct kconfig option
Posted by Paolo Bonzini 6 years, 6 months ago
From: Marc-André Lureau <marcandre.lureau@redhat.com>

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <20190723120804.29565-1-marcandre.lureau@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 docs/devel/kconfig.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/docs/devel/kconfig.rst b/docs/devel/kconfig.rst
index d6f8eb0977..b7bca44704 100644
--- a/docs/devel/kconfig.rst
+++ b/docs/devel/kconfig.rst
@@ -267,7 +267,7 @@ the default configuration by uncommenting lines in the first group,
 or commenting out lines in the second group.
 
 It is also possible to run QEMU's configure script with the
-``--with-default-devices`` option.  When this is done, everything defaults
+``--without-default-devices`` option.  When this is done, everything defaults
 to ``n`` unless it is ``select``ed or explicitly switched on in the
 ``.mak`` files.  In other words, ``default`` and ``imply`` directives
 are disabled.  When QEMU is built with this option, the user will probably
-- 
2.21.0


Re: [Qemu-devel] [PULL 3/3] docs: correct kconfig option
Posted by Philippe Mathieu-Daudé 6 years, 6 months ago
On 7/24/19 3:13 PM, Paolo Bonzini wrote:
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
> 
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> Message-Id: <20190723120804.29565-1-marcandre.lureau@redhat.com>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

Not a big deal bug I reviewed this one:
https://lists.gnu.org/archive/html/qemu-devel/2019-07/msg05128.html
(wondering if patchwork/patchew is loosing mails/tags).

> ---
>  docs/devel/kconfig.rst | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/docs/devel/kconfig.rst b/docs/devel/kconfig.rst
> index d6f8eb0977..b7bca44704 100644
> --- a/docs/devel/kconfig.rst
> +++ b/docs/devel/kconfig.rst
> @@ -267,7 +267,7 @@ the default configuration by uncommenting lines in the first group,
>  or commenting out lines in the second group.
>  
>  It is also possible to run QEMU's configure script with the
> -``--with-default-devices`` option.  When this is done, everything defaults
> +``--without-default-devices`` option.  When this is done, everything defaults
>  to ``n`` unless it is ``select``ed or explicitly switched on in the
>  ``.mak`` files.  In other words, ``default`` and ``imply`` directives
>  are disabled.  When QEMU is built with this option, the user will probably
> 

Re: [Qemu-devel] [PULL 3/3] docs: correct kconfig option
Posted by Paolo Bonzini 6 years, 6 months ago
On 24/07/19 15:23, Philippe Mathieu-Daudé wrote:
> On 7/24/19 3:13 PM, Paolo Bonzini wrote:
>> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>>
>> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
>> Message-Id: <20190723120804.29565-1-marcandre.lureau@redhat.com>
>> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> 
> Not a big deal bug I reviewed this one:
> https://lists.gnu.org/archive/html/qemu-devel/2019-07/msg05128.html
> (wondering if patchwork/patchew is loosing mails/tags).

No, I just applied it before your review.

Paolo

>> ---
>>  docs/devel/kconfig.rst | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/docs/devel/kconfig.rst b/docs/devel/kconfig.rst
>> index d6f8eb0977..b7bca44704 100644
>> --- a/docs/devel/kconfig.rst
>> +++ b/docs/devel/kconfig.rst
>> @@ -267,7 +267,7 @@ the default configuration by uncommenting lines in the first group,
>>  or commenting out lines in the second group.
>>  
>>  It is also possible to run QEMU's configure script with the
>> -``--with-default-devices`` option.  When this is done, everything defaults
>> +``--without-default-devices`` option.  When this is done, everything defaults
>>  to ``n`` unless it is ``select``ed or explicitly switched on in the
>>  ``.mak`` files.  In other words, ``default`` and ``imply`` directives
>>  are disabled.  When QEMU is built with this option, the user will probably
>>