1. Patchew
  2. QEMU
  3. View series

[Qemu-devel] [PATCH for-4.1] configure: Clarify URL to source downloads

Peter Maydell posted 1 patch 4 years, 9 months ago
Test docker-clang@ubuntu passed
Test s390x passed
Test asan passed
Test docker-mingw@fedora passed
Test FreeBSD passed
Test checkpatch passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20190718131659.20783-1-peter.maydell@linaro.org
configure | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[Qemu-devel] [PATCH for-4.1] configure: Clarify URL to source downloads
Posted by Peter Maydell 4 years, 9 months ago 
If configure detects that it's being run on a source tree which
is missing git modules, it prints an error messages suggesting
that the user downloads a correct source archive from the project
website. However https://www.qemu.org/download/ is a link to a
page with multiple tabs, with the default being the one telling
users how to get binaries from their distro. Clarify the URL
we print to include the #source anchor, so that the browser will
go directly to the source-tarball instructions.

Reported-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Suggested-by: Stefan Weil <sw@weilnetz.de>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
 configure | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/configure b/configure
index eb635c3b9a5..bf79bbd0e8d 100755
--- a/configure
+++ b/configure
@@ -322,7 +322,7 @@ else
         echo "to acquire QEMU source archives. Non-GIT builds are only"
         echo "supported with source archives linked from:"
         echo
-        echo "  https://www.qemu.org/download/"
+        echo "  https://www.qemu.org/download/#source"
         echo
         echo "Developers working with GIT can use scripts/archive-source.sh"
         echo "if they need to create valid source archives."
-- 
2.20.1
Re: [Qemu-devel] [PATCH for-4.1] configure: Clarify URL to source downloads
Posted by Peter Maydell 4 years, 9 months ago 
On Thu, 18 Jul 2019 at 14:17, Peter Maydell <peter.maydell@linaro.org> wrote:
>
> If configure detects that it's being run on a source tree which
> is missing git modules, it prints an error messages suggesting
> that the user downloads a correct source archive from the project
> website. However https://www.qemu.org/download/ is a link to a
> page with multiple tabs, with the default being the one telling
> users how to get binaries from their distro. Clarify the URL
> we print to include the #source anchor, so that the browser will
> go directly to the source-tarball instructions.
>
> Reported-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> Suggested-by: Stefan Weil <sw@weilnetz.de>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
>  configure | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

I'll put this in master via my target-arm.next tree, since
I'm doing a pullreq anyway today.

thanks
-- PMM
Re: [Qemu-devel] [PATCH for-4.1] configure: Clarify URL to source downloads
Posted by Philippe Mathieu-Daudé 4 years, 9 months ago 
On 7/18/19 3:16 PM, Peter Maydell wrote:
> If configure detects that it's being run on a source tree which
> is missing git modules, it prints an error messages suggesting
> that the user downloads a correct source archive from the project
> website. However https://www.qemu.org/download/ is a link to a
> page with multiple tabs, with the default being the one telling
> users how to get binaries from their distro. Clarify the URL
> we print to include the #source anchor, so that the browser will
> go directly to the source-tarball instructions.
> 
> Reported-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> Suggested-by: Stefan Weil <sw@weilnetz.de>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
>  configure | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/configure b/configure
> index eb635c3b9a5..bf79bbd0e8d 100755
> --- a/configure
> +++ b/configure
> @@ -322,7 +322,7 @@ else
>          echo "to acquire QEMU source archives. Non-GIT builds are only"
>          echo "supported with source archives linked from:"
>          echo
> -        echo "  https://www.qemu.org/download/"
> +        echo "  https://www.qemu.org/download/#source"

Thanks Peter and Stefan.

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>

>          echo
>          echo "Developers working with GIT can use scripts/archive-source.sh"
>          echo "if they need to create valid source archives."
>
Re: [Qemu-devel] [PATCH for-4.1] configure: Clarify URL to source downloads
Posted by Stefan Weil 4 years, 9 months ago 
Am 18.07.2019 um 15:47 schrieb Philippe Mathieu-Daudé:
> On 7/18/19 3:16 PM, Peter Maydell wrote:
>> If configure detects that it's being run on a source tree which
>> is missing git modules, it prints an error messages suggesting
>> that the user downloads a correct source archive from the project
>> website. However https://www.qemu.org/download/ is a link to a
>> page with multiple tabs, with the default being the one telling
>> users how to get binaries from their distro. Clarify the URL
>> we print to include the #source anchor, so that the browser will
>> go directly to the source-tarball instructions.
>>
>> Reported-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>> Suggested-by: Stefan Weil <sw@weilnetz.de>
>> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
>> ---
>>  configure | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/configure b/configure
>> index eb635c3b9a5..bf79bbd0e8d 100755
>> --- a/configure
>> +++ b/configure
>> @@ -322,7 +322,7 @@ else
>>          echo "to acquire QEMU source archives. Non-GIT builds are only"
>>          echo "supported with source archives linked from:"
>>          echo
>> -        echo "  https://www.qemu.org/download/"
>> +        echo "  https://www.qemu.org/download/#source"
> Thanks Peter and Stefan.
>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>


Reviewed-by: Stefan Weil <sw@weilnetz.de>

Thanks,
Stefan
Re: [Qemu-devel] [PATCH for-4.1] configure: Clarify URL to source downloads
Posted by Thomas Huth 4 years, 9 months ago 
On 18/07/2019 15.16, Peter Maydell wrote:
> If configure detects that it's being run on a source tree which
> is missing git modules, it prints an error messages suggesting
> that the user downloads a correct source archive from the project
> website. However https://www.qemu.org/download/ is a link to a
> page with multiple tabs, with the default being the one telling
> users how to get binaries from their distro. Clarify the URL
> we print to include the #source anchor, so that the browser will
> go directly to the source-tarball instructions.
> 
> Reported-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> Suggested-by: Stefan Weil <sw@weilnetz.de>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
>  configure | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/configure b/configure
> index eb635c3b9a5..bf79bbd0e8d 100755
> --- a/configure
> +++ b/configure
> @@ -322,7 +322,7 @@ else
>          echo "to acquire QEMU source archives. Non-GIT builds are only"
>          echo "supported with source archives linked from:"
>          echo
> -        echo "  https://www.qemu.org/download/"
> +        echo "  https://www.qemu.org/download/#source"
>          echo
>          echo "Developers working with GIT can use scripts/archive-source.sh"
>          echo "if they need to create valid source archives."
> 

Reviewed-by: Thomas Huth <thuth@redhat.com>

Patchew 2.1-devel-0870f84

© 2016 - 2024 Red Hat, Inc.