[v1] Series to implement suspend for ppc/spapr

[Qemu-devel] [PATCH 0/3] Series to implement suspend for ppc/spapr

Nicholas Piggin posted 3 patches 4 years, 9 months ago

Diff against v2 v2
Download series mbox

Test asan passed

Test docker-mingw@fedora passed

Test checkpatch passed

Test s390x passed

Test FreeBSD passed

Test docker-clang@ubuntu passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20190718103951.10027-1-npiggin@gmail.com

Maintainers: Paolo Bonzini <pbonzini@redhat.com>, Eduardo Habkost <ehabkost@redhat.com>, David Gibson <david@gibson.dropbear.id.au>, Marcel Apfelbaum <marcel.apfelbaum@gmail.com>

There is a newer version of this series

hw/ppc/spapr.c         | 11 +++++++++++
hw/ppc/spapr_rtas.c    | 32 ++++++++++++++++++++++++++++++++
include/hw/boards.h    |  1 +
include/hw/ppc/spapr.h |  3 ++-
vl.c                   | 31 +++++++++++++++++++++++++++++--
5 files changed, 75 insertions(+), 3 deletions(-)

Expand all Fold all

[Qemu-devel] [PATCH 0/3] Series to implement suspend for ppc/spapr

Posted by Nicholas Piggin 4 years, 9 months ago

Any comments on this series would be welcome. Hopefully someone who
knows i386 can give some feedback on the possible bug fix, and
whether the new wakeup method will suit i386.

Thanks,
Nick

Nicholas Piggin (3):
  qmp: don't emit the RESET event on wakeup
  machine: Add wakeup method to MachineClass
  spapr: Implement ibm,suspend-me

 hw/ppc/spapr.c         | 11 +++++++++++
 hw/ppc/spapr_rtas.c    | 32 ++++++++++++++++++++++++++++++++
 include/hw/boards.h    |  1 +
 include/hw/ppc/spapr.h |  3 ++-
 vl.c                   | 31 +++++++++++++++++++++++++++++--
 5 files changed, 75 insertions(+), 3 deletions(-)

-- 
2.20.1

Re: [Qemu-devel] [PATCH 0/3] Series to implement suspend for ppc/spapr

Posted by Paolo Bonzini 4 years, 9 months ago

On 18/07/19 12:39, Nicholas Piggin wrote:
> Any comments on this series would be welcome. Hopefully someone who
> knows i386 can give some feedback on the possible bug fix, and
> whether the new wakeup method will suit i386.

Looks good, though only i386 supports wakeup so perhaps it's better to
DTRT and move the reset to the PC machine's wakeup method.  Then pseries
need not implement mc->wakeup at all.

Paolo

> Thanks,
> Nick
> 
> Nicholas Piggin (3):
>   qmp: don't emit the RESET event on wakeup
>   machine: Add wakeup method to MachineClass
>   spapr: Implement ibm,suspend-me
> 
>  hw/ppc/spapr.c         | 11 +++++++++++
>  hw/ppc/spapr_rtas.c    | 32 ++++++++++++++++++++++++++++++++
>  include/hw/boards.h    |  1 +
>  include/hw/ppc/spapr.h |  3 ++-
>  vl.c                   | 31 +++++++++++++++++++++++++++++--
>  5 files changed, 75 insertions(+), 3 deletions(-)
>

Re: [Qemu-devel] [PATCH 0/3] Series to implement suspend for ppc/spapr

Posted by Nicholas Piggin 4 years, 9 months ago

Paolo Bonzini's on July 18, 2019 9:08 pm:
> On 18/07/19 12:39, Nicholas Piggin wrote:
>> Any comments on this series would be welcome. Hopefully someone who
>> knows i386 can give some feedback on the possible bug fix, and
>> whether the new wakeup method will suit i386.
> 
> Looks good, though only i386 supports wakeup so perhaps it's better to
> DTRT and move the reset to the PC machine's wakeup method.  Then pseries
> need not implement mc->wakeup at all.

Yeah that probably makes more sense because the i386 patch should be 
quite trivial. I will try that and re-send.

Thanks,
Nick