[Qemu-devel] [PATCH v3 0/4] Enable iotests during "make check"

Thomas Huth posted 4 patches 4 years, 9 months ago
Test asan failed
Test docker-mingw@fedora passed
Test FreeBSD passed
Test s390x passed
Test checkpatch passed
Test docker-clang@ubuntu passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20190717111947.30356-1-thuth@redhat.com
Maintainers: Max Reitz <mreitz@redhat.com>, Thomas Huth <thuth@redhat.com>, Kevin Wolf <kwolf@redhat.com>
.gitlab-ci.yml              |  13 ++--
tests/Makefile.include      |  10 +--
tests/check-block.sh        |  44 ++++++++++---
tests/qemu-iotests-quick.sh |   8 ---
tests/qemu-iotests/check    |   4 +-
tests/qemu-iotests/group    | 120 ++++++++++++++++++------------------
6 files changed, 107 insertions(+), 92 deletions(-)
delete mode 100755 tests/qemu-iotests-quick.sh
[Qemu-devel] [PATCH v3 0/4] Enable iotests during "make check"
Posted by Thomas Huth 4 years, 9 months ago
Let's enable the block iotests during "make check" again, to avoid that
they get broken so easily by accident (like we've seen many times in the
past).

v3:
 - Added dependency for "check-block" so that the *-softmmu targets are
   now built first
 - Added 197 and 215 back to gitlab-ci.yml (there is no problem if they
   do not run in parallel with the qtests)
 - Removed 122 from the "auto" group (does not work on ZFS according to
   Alex)
 - Removed 181 and 201 from the "auto" group (they do not work if the
   default machine of QEMU does not support migration)

v2:
 - Added new patch to allow tests without groups, removed the "o_direct"
   group again.
 - Removed some more tests from the "auto" group, like 197 and 215 which
   were sometimes causing the CI pipelines to fail on gitlab
 - Added a patch to remove the "duplicated" tests from the gitlab-ci.yml
   file.

Thomas Huth (4):
  tests/qemu-iotests/check: Allow tests without groups
  tests/qemu-iotests/group: Remove some more tests from the "auto" group
  tests: Run the iotests during "make check" again
  gitlab-ci: Remove qcow2 tests that are handled by "make check" already

 .gitlab-ci.yml              |  13 ++--
 tests/Makefile.include      |  10 +--
 tests/check-block.sh        |  44 ++++++++++---
 tests/qemu-iotests-quick.sh |   8 ---
 tests/qemu-iotests/check    |   4 +-
 tests/qemu-iotests/group    | 120 ++++++++++++++++++------------------
 6 files changed, 107 insertions(+), 92 deletions(-)
 delete mode 100755 tests/qemu-iotests-quick.sh

-- 
2.21.0


Re: [Qemu-devel] [PATCH v3 0/4] Enable iotests during "make check"
Posted by Alex Bennée 4 years, 9 months ago
Thomas Huth <thuth@redhat.com> writes:

> Let's enable the block iotests during "make check" again, to avoid that
> they get broken so easily by accident (like we've seen many times in the
> past).

Queued to testing/next, thanks.
>
> v3:
>  - Added dependency for "check-block" so that the *-softmmu targets are
>    now built first
>  - Added 197 and 215 back to gitlab-ci.yml (there is no problem if they
>    do not run in parallel with the qtests)
>  - Removed 122 from the "auto" group (does not work on ZFS according to
>    Alex)
>  - Removed 181 and 201 from the "auto" group (they do not work if the
>    default machine of QEMU does not support migration)
>
> v2:
>  - Added new patch to allow tests without groups, removed the "o_direct"
>    group again.
>  - Removed some more tests from the "auto" group, like 197 and 215 which
>    were sometimes causing the CI pipelines to fail on gitlab
>  - Added a patch to remove the "duplicated" tests from the gitlab-ci.yml
>    file.
>
> Thomas Huth (4):
>   tests/qemu-iotests/check: Allow tests without groups
>   tests/qemu-iotests/group: Remove some more tests from the "auto" group
>   tests: Run the iotests during "make check" again
>   gitlab-ci: Remove qcow2 tests that are handled by "make check" already
>
>  .gitlab-ci.yml              |  13 ++--
>  tests/Makefile.include      |  10 +--
>  tests/check-block.sh        |  44 ++++++++++---
>  tests/qemu-iotests-quick.sh |   8 ---
>  tests/qemu-iotests/check    |   4 +-
>  tests/qemu-iotests/group    | 120 ++++++++++++++++++------------------
>  6 files changed, 107 insertions(+), 92 deletions(-)
>  delete mode 100755 tests/qemu-iotests-quick.sh


--
Alex Bennée