kconfig: do not select VMMOUSE

[Qemu-devel] [PATCH] kconfig: do not select VMMOUSE

Paolo Bonzini posted 1 patch 4 years, 9 months ago

Download mbox

Test docker-clang@ubuntu passed

Test FreeBSD passed

Test asan passed

Test docker-mingw@fedora passed

Test s390x passed

Test checkpatch passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20190716211343.10792-1-pbonzini@redhat.com

Maintainers: Eduardo Habkost <ehabkost@redhat.com>, Marcel Apfelbaum <marcel.apfelbaum@gmail.com>, Richard Henderson <rth@twiddle.net>, Paolo Bonzini <pbonzini@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>

hw/i386/Kconfig | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

Expand all Fold all

[Qemu-devel] [PATCH] kconfig: do not select VMMOUSE

Posted by Paolo Bonzini 4 years, 9 months ago

Just make it a default device, so that it is automatically removed if VMPORT
is not included in the binary (as is the case with --with-default-devices).

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 hw/i386/Kconfig | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/hw/i386/Kconfig b/hw/i386/Kconfig
index b9c96ac361..83a5d9c7c4 100644
--- a/hw/i386/Kconfig
+++ b/hw/i386/Kconfig
@@ -59,7 +59,6 @@ config I440FX
     select IDE_PIIX
     select DIMM
     select SMBIOS
-    select VMMOUSE
     select FW_CFG_DMA
 
 config ISAPC
@@ -85,7 +84,6 @@ config Q35
     select AHCI_ICH9
     select DIMM
     select SMBIOS
-    select VMMOUSE
     select FW_CFG_DMA
 
 config VTD
@@ -99,4 +97,5 @@ config VMPORT
 
 config VMMOUSE
     bool
+    default y
     depends on VMPORT
-- 
2.21.0

Re: [Qemu-devel] [PATCH] kconfig: do not select VMMOUSE

Posted by Montes, Julio 4 years, 9 months ago

Thanks Paolo

On Tue, 2019-07-16 at 23:13 +0200, Paolo Bonzini wrote:
> Just make it a default device, so that it is automatically removed if
> VMPORT
> is not included in the binary (as is the case with --with-default-
> devices).
> 
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  hw/i386/Kconfig | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/hw/i386/Kconfig b/hw/i386/Kconfig
> index b9c96ac361..83a5d9c7c4 100644
> --- a/hw/i386/Kconfig
> +++ b/hw/i386/Kconfig
> @@ -59,7 +59,6 @@ config I440FX
>      select IDE_PIIX
>      select DIMM
>      select SMBIOS
> -    select VMMOUSE
>      select FW_CFG_DMA
>  
>  config ISAPC
> @@ -85,7 +84,6 @@ config Q35
>      select AHCI_ICH9
>      select DIMM
>      select SMBIOS
> -    select VMMOUSE
>      select FW_CFG_DMA
>  
>  config VTD
> @@ -99,4 +97,5 @@ config VMPORT
>  
>  config VMMOUSE
>      bool
> +    default y
>      depends on VMPORT

Reviewed-by: Julio Montes <julio.montes@intel.com>
Tested-by: Julio
Montes <julio.montes@intel.com>

Re: [Qemu-devel] [PATCH] kconfig: do not select VMMOUSE

Posted by Philippe Mathieu-Daudé 4 years, 9 months ago

On 7/16/19 11:13 PM, Paolo Bonzini wrote:
> Just make it a default device, so that it is automatically removed if VMPORT
> is not included in the binary (as is the case with --with-default-devices).
> 
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  hw/i386/Kconfig | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/hw/i386/Kconfig b/hw/i386/Kconfig
> index b9c96ac361..83a5d9c7c4 100644
> --- a/hw/i386/Kconfig
> +++ b/hw/i386/Kconfig
> @@ -59,7 +59,6 @@ config I440FX
>      select IDE_PIIX
>      select DIMM
>      select SMBIOS
> -    select VMMOUSE
>      select FW_CFG_DMA
>  
>  config ISAPC
> @@ -85,7 +84,6 @@ config Q35
>      select AHCI_ICH9
>      select DIMM
>      select SMBIOS
> -    select VMMOUSE
>      select FW_CFG_DMA
>  
>  config VTD
> @@ -99,4 +97,5 @@ config VMPORT
>  
>  config VMMOUSE
>      bool
> +    default y
>      depends on VMPORT
> 

Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>