hw/lm32/Kconfig: Milkymist One provides a USB 1.1 Controller

[Qemu-devel] [PATCH-for-4.1] hw/lm32/Kconfig: Milkymist One provides a USB 1.1 Controller

Philippe Mathieu-Daudé posted 1 patch 4 years, 9 months ago

Download mbox

Test docker-clang@ubuntu passed

Test s390x passed

Test asan passed

Test docker-mingw@fedora passed

Test FreeBSD passed

Test checkpatch passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20190714124755.14356-1-philmd@redhat.com

Maintainers: Michael Walle <michael@walle.cc>

hw/lm32/Kconfig | 1 +
1 file changed, 1 insertion(+)

Expand all Fold all

[Qemu-devel] [PATCH-for-4.1] hw/lm32/Kconfig: Milkymist One provides a USB 1.1 Controller

Posted by Philippe Mathieu-Daudé 4 years, 9 months ago

The Milkymist SoftUSB block provides the OHCI USB standard
(missed in 0858746b835).

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
 hw/lm32/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/hw/lm32/Kconfig b/hw/lm32/Kconfig
index 3d09c2dd6f..ed2e3060b0 100644
--- a/hw/lm32/Kconfig
+++ b/hw/lm32/Kconfig
@@ -11,3 +11,4 @@ config MILKYMIST
     select PFLASH_CFI01
     select FRAMEBUFFER
     select SD
+    select USB_OHCI
-- 
2.20.1

Re: [Qemu-devel] [PATCH-for-4.1] hw/lm32/Kconfig: Milkymist One provides a USB 1.1 Controller

Posted by Philippe Mathieu-Daudé 4 years, 9 months ago

On 7/14/19 2:47 PM, Philippe Mathieu-Daudé wrote:
> The Milkymist SoftUSB block provides the OHCI USB standard
> (missed in 0858746b835).
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
>  hw/lm32/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/hw/lm32/Kconfig b/hw/lm32/Kconfig
> index 3d09c2dd6f..ed2e3060b0 100644
> --- a/hw/lm32/Kconfig
> +++ b/hw/lm32/Kconfig
> @@ -11,3 +11,4 @@ config MILKYMIST
>      select PFLASH_CFI01
>      select FRAMEBUFFER
>      select SD
> +    select USB_OHCI
> 

Markus asked me how I noticed that, if it was auditing the code.

I ran 'qemu-system-lm32 -device help' and noticed all the USB devices
had disappeared.

Re: [Qemu-devel] [PATCH-for-4.1] hw/lm32/Kconfig: Milkymist One provides a USB 1.1 Controller

Posted by Paolo Bonzini 4 years, 9 months ago

On 15/07/19 13:47, Philippe Mathieu-Daudé wrote:
> On 7/14/19 2:47 PM, Philippe Mathieu-Daudé wrote:
>> The Milkymist SoftUSB block provides the OHCI USB standard
>> (missed in 0858746b835).
>>
>> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>> ---
>>  hw/lm32/Kconfig | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/hw/lm32/Kconfig b/hw/lm32/Kconfig
>> index 3d09c2dd6f..ed2e3060b0 100644
>> --- a/hw/lm32/Kconfig
>> +++ b/hw/lm32/Kconfig
>> @@ -11,3 +11,4 @@ config MILKYMIST
>>      select PFLASH_CFI01
>>      select FRAMEBUFFER
>>      select SD
>> +    select USB_OHCI
>>
> 
> Markus asked me how I noticed that, if it was auditing the code.
> 
> I ran 'qemu-system-lm32 -device help' and noticed all the USB devices
> had disappeared.
> 

Queued, thanks.

Paolo